Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Fix `-Wunsafe-buffer-usage` exclusions for wallet files

In a Release build Issue General Zcash support

Lead item brave-browser#41664 · opened by supermassive · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#26253 merged 2024-11-06 into master by supermassive
    Fix UNSAFE_TODO for wallet
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description
  • brave-core#26803 merged 2024-12-04 into master by supermassive
    Fix UNSAFE_TODO for wallet [part 3 of N]
    Linked by: “Resolves/Fixes” line in the PR description

Release notes

No platform changelog lists this item.

Validation

Not QA-tested (QA/No).

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

No milestone set.

Platforms (OS labels): Android, Desktop, iOS

Owner: supermassive · PR authors: supermassive

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...e8405573: behind); later builds of the same history include it (brave-core#26253)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...e8405573: behind); later builds of the same history include it (brave-core#26253)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...e8405573: behind); later builds of the same history include it (brave-core#26253)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...e8405573: behind); later builds of the same history include it (brave-core#26253)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...e8405573: behind); later builds of the same history include it (brave-core#26253)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...e8405573: behind); later builds of the same history include it (brave-core#26253)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...e8405573: behind); later builds of the same history include it (brave-core#26253)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...e8405573: behind); later builds of the same history include it (brave-core#26253)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...e8405573: behind); later builds of the same history include it (brave-core#26253)

Linked sub-issues

Members and their history

Issue

brave-browser#41664 Fix `-Wunsafe-buffer-usage` exclusions for wallet files

State: closed (completed) · created · closed · updated · discovered via linked:brave/brave-core#26253, linked:brave/brave-core#26803

QA/No dev-concern release-notes/exclude feature/web3/wallet OS/Android OS/Desktop OS/iOS feature/web3/wallet/core

Description Remove all UNSAFE_TODO and #pragma allow_unsafe_buffers in wallet files

Timeline (13 of 16 events)
  1. 2024-10-31 16:27 Referenced by brave-core#26253 by yrliou
  2. 2024-11-06 04:38 Closed completed brave-core#26253 by supermassive
  3. 2024-11-06 04:38 Milestone set 1.73.x - Nightly by brave-builds
  4. 2024-11-06 08:15 Label added QA/No by supermassive
  5. 2024-11-06 08:15 Label added release-notes/exclude by supermassive
  6. 2024-11-06 08:15 Label added OS/Android by supermassive
  7. 2024-11-06 08:15 Label added OS/Desktop by supermassive
  8. 2024-11-06 08:15 Label added OS/iOS by supermassive
  9. 2024-11-07 18:00 Reopened by yrliou
  10. 2024-11-07 18:00 Milestone removed 1.74.x - Beta by yrliou
  11. 2024-12-04 06:10 Milestone set 1.75.x - Nightly by brave-builds
  12. 2025-02-05 03:19 Milestone removed 1.75.x - Release by kjozwiak
  13. 2025-02-06 09:19 Closed completed by supermassive
Pull request

brave-core#26253 Fix UNSAFE_TODO for wallet

State: merged 2024-11-06 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash

feature/web3/wallet feature/web3/wallet/core puLL-Merge

Resolves https://github.com/brave/brave-browser/issues/41664 Fixing #pragma allow_unsafe_buffers and UNSAFE_TODO in wallet. Mostly this comes with using base::span (with compile-time size preferably) and adjusting dependent code. Submitter Checklist: - [ ] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [ ] There is a ticket for my issue - [ ] Used Github auto-closing keywords in the PR description…

Timeline (7 of 12 events)
  1. 2024-10-29 07:16 Converted to draft by supermassive
  2. 2024-11-01 11:24 Ready for review by supermassive
  3. 2024-11-06 04:38 Merged master by supermassive
  4. 2024-11-06 04:38 Closed by supermassive
  5. 2024-11-06 04:38 Milestone set 1.73.x - Nightly by github-actions
  6. 2024-11-06 18:12 Milestone removed 1.73.x - Nightly by bsclifton
  7. 2024-11-06 18:12 Milestone set 1.74.x - Nightly by bsclifton
Pull request

brave-core#26803 Fix UNSAFE_TODO for wallet [part 3 of N]

State: merged 2024-12-04 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash

feature/web3/wallet feature/web3/wallet/core puLL-Merge

Resolves https://github.com/brave/brave-browser/issues/41664?issue=brave%7Cbrave-browser%7C42593 Submitter Checklist: - [ ] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [ ] There is a ticket for my issue - [ ] Used Github auto-closing keywords in the PR description above - [ ] Wrote a good PR/commit description - [ ] Squashed any review feedback or "fixup" commits before merge, so that history…

Timeline (3 of 6 events)
  1. 2024-12-04 06:10 Merged master by supermassive
  2. 2024-12-04 06:10 Closed by supermassive
  3. 2024-12-04 06:10 Milestone set 1.75.x - Nightly by github-actions