Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Fix -Wunsafe-buffer-usage exclusions for wallet files [3/N]

In a Release build Issue General Zcash support

Lead item brave-browser#42593 · opened by supermassive · last source update

Part of Fix `-Wunsafe-buffer-usage` exclusions for wallet files (brave-browser#41664).

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#26803 merged 2024-12-04 into master by supermassive
    Fix UNSAFE_TODO for wallet [part 3 of N]
    Linked by: GitHub closing reference

Release notes

No platform changelog lists this item.

Validation

No QA label.

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

No milestone set.

Platforms (OS labels): none

Owner: supermassive · PR authors: supermassive

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...25fa26ea: behind); later builds of the same history include it (brave-core#26803)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...25fa26ea: behind); later builds of the same history include it (brave-core#26803)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...25fa26ea: behind); later builds of the same history include it (brave-core#26803)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...25fa26ea: behind); later builds of the same history include it (brave-core#26803)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...25fa26ea: behind); later builds of the same history include it (brave-core#26803)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...25fa26ea: behind); later builds of the same history include it (brave-core#26803)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...25fa26ea: behind); later builds of the same history include it (brave-core#26803)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...25fa26ea: behind); later builds of the same history include it (brave-core#26803)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...25fa26ea: behind); later builds of the same history include it (brave-core#26803)

Members and their history

Issue

brave-browser#42593 Fix -Wunsafe-buffer-usage exclusions for wallet files [3/N]

State: closed (completed) · created · closed · updated · discovered via linked:brave/brave-core#26803

dev-concern feature/web3/wallet feature/web3/wallet/core

Description Fix -Wunsafe-buffer-usage exclusions for wallet files [3/N]

Timeline (2 of 5 events)
  1. 2024-11-29 09:14 Referenced by brave-core#26803 by supermassive
  2. 2024-12-04 06:10 Closed completed brave-core#26803 by supermassive
Pull request

brave-core#26803 Fix UNSAFE_TODO for wallet [part 3 of N]

State: merged 2024-12-04 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash

feature/web3/wallet feature/web3/wallet/core puLL-Merge

Resolves https://github.com/brave/brave-browser/issues/41664?issue=brave%7Cbrave-browser%7C42593 Submitter Checklist: - [ ] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [ ] There is a ticket for my issue - [ ] Used Github auto-closing keywords in the PR description above - [ ] Wrote a good PR/commit description - [ ] Squashed any review feedback or "fixup" commits before merge, so that history…

Timeline (3 of 6 events)
  1. 2024-12-04 06:10 Merged master by supermassive
  2. 2024-12-04 06:10 Closed by supermassive
  3. 2024-12-04 06:10 Milestone set 1.75.x - Nightly by github-actions