Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Fix -Wunsafe-buffer-usage exclusions for wallet files [2/N]

In a Release build Issue General Zcash support

Lead item brave-browser#42200 · opened by supermassive · last source update

Part of Fix `-Wunsafe-buffer-usage` exclusions for wallet files (brave-browser#41664).

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#26469 merged 2024-11-18 into master by supermassive
    Fix UNSAFE_TODO for wallet [part 2 of N]
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description
  • brave-core#26819 merged 2024-12-06 into 1.74.x by emerick
    Upgrade from Chromium 131 to Chromium 132 1.74.x
    Linked by: “Resolves/Fixes” line in the PR description

Release notes

No platform changelog lists this item.

Validation

Not QA-tested (QA/No).

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.74.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: supermassive · PR authors: supermassive, emerick

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...af020d2b: behind); later builds of the same history include it (brave-core#26469)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...af020d2b: behind); later builds of the same history include it (brave-core#26469)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...af020d2b: behind); later builds of the same history include it (brave-core#26469)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...af020d2b: behind); later builds of the same history include it (brave-core#26469)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...af020d2b: behind); later builds of the same history include it (brave-core#26469)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...af020d2b: behind); later builds of the same history include it (brave-core#26469)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...af020d2b: behind); later builds of the same history include it (brave-core#26469)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...af020d2b: behind); later builds of the same history include it (brave-core#26469)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...af020d2b: behind); later builds of the same history include it (brave-core#26469)

Members and their history

Issue

brave-browser#42200 Fix -Wunsafe-buffer-usage exclusions for wallet files [2/N]

State: closed (completed) · created · closed · updated · discovered via linked:brave/brave-core#26469

QA/No dev-concern release-notes/exclude feature/web3/wallet OS/Desktop feature/web3/wallet/core

Description Fix -Wunsafe-buffer-usage exclusions for wallet files [2/N]

Timeline (9 of 12 events)
  1. 2024-11-11 07:29 Referenced by brave-core#26469 by supermassive
  2. 2024-11-18 10:09 Closed completed brave-core#26469 by supermassive
  3. 2024-11-18 10:10 Milestone set 1.75.x - Nightly by brave-builds
  4. 2024-11-22 11:11 Label added QA/No by supermassive
  5. 2024-11-22 11:11 Label added release-notes/exclude by supermassive
  6. 2024-11-22 11:11 Label added OS/Desktop by supermassive
  7. 2024-12-02 21:48 Referenced by brave-core#26819 by emerick
  8. 2024-12-06 04:02 Milestone removed 1.75.x - Nightly by brave-builds
  9. 2024-12-06 04:02 Milestone set 1.74.x - Beta by brave-builds
Pull request

brave-core#26469 Fix UNSAFE_TODO for wallet [part 2 of N]

State: merged 2024-11-18 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:zcash is:pr

feature/web3/wallet feature/web3/wallet/core puLL-Merge

Resolves https://github.com/brave/brave-browser/issues/42200 Submitter Checklist: - [ ] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [ ] There is a ticket for my issue - [ ] Used Github auto-closing keywords in the PR description above - [ ] Wrote a good PR/commit description - [ ] Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the…

Timeline (4 of 7 events)
  1. 2024-11-18 10:09 Merged master by supermassive
  2. 2024-11-18 10:09 Closed by supermassive
  3. 2024-11-18 10:10 Milestone set 1.75.x - Nightly by github-actions
  4. 2024-12-02 21:48 Referenced by brave-core#26819 by emerick
Uplift PR → 1.74.x

brave-core#26819 Upgrade from Chromium 131 to Chromium 132 1.74.x

State: merged 2024-12-06 · created · closed · updated · discovered via mentions:brave/brave-core#26469

CI/run-network-audit CI/run-audit-deps CI/storybook-url CI/run-upstream-tests feature/web3/wallet feature/web3/wallet/core

Resolves https://github.com/brave/brave-browser/issues/41761 Resolves https://github.com/brave/brave-browser/issues/42532 Uplift from https://github.com/brave/brave-core/pull/26068 Resolves https://github.com/brave/brave-browser/issues/42223 Uplift from https://github.com/brave/brave-core/pull/26493 Resolves https://github.com/brave/brave-browser/issues/42241 Uplift from https://github.com/brave/brave-core/pull/26508 Resolves [No issue] Uplift from…

Timeline (3 of 9 events)
  1. 2024-12-02 21:12 Milestone set 1.74.x - Beta by emerick
  2. 2024-12-06 04:02 Merged 1.74.x by kjozwiak
  3. 2024-12-06 04:02 Closed by kjozwiak