Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Drop signing fields from Eth TxData

In a Release build Pull request Testnet, tests & tooling

Lead item brave-core#35012 · opened by supermassive · last source update

Issue state

No tracked issue; this group is led by a pull request.

Implementation

  • brave-core#35012 merged 2026-04-08 into master by supermassive
    Drop signing fields from Eth TxData
    Linked by: issue timeline (closing cross-reference or closed by this PR)

Release notes

No platform changelog lists this item.

Validation

No QA label.

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.91.x - Release

A milestone is a target set by Brave, not a release promise. Brave renames milestones as branches move from Nightly to Beta to Release.

Platforms (OS labels): none

Owner: unassigned · PR authors: supermassive

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...1938ece2: behind); later builds of the same history include it (brave-core#35012)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...1938ece2: behind); later builds of the same history include it (brave-core#35012)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...1938ece2: behind); later builds of the same history include it (brave-core#35012)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...1938ece2: behind); later builds of the same history include it (brave-core#35012)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...1938ece2: behind); later builds of the same history include it (brave-core#35012)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...1938ece2: behind); later builds of the same history include it (brave-core#35012)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...1938ece2: behind); later builds of the same history include it (brave-core#35012)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...1938ece2: behind); later builds of the same history include it (brave-core#35012)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...1938ece2: behind); later builds of the same history include it (brave-core#35012)

Members and their history

Pull request

brave-core#35012 Drop signing fields from Eth TxData

State: merged 2026-04-08 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:zcash is:pr

CI/storybook-url feature/web3/wallet feature/web3/wallet/core puLL-Merge

Resolves 1) Remove these fields from TxData. [code] Signed-only transaction should not be stored in TxData. Instead signatures should be provided by TxService::GetEthSignedTransaction. 2) Store v as hex string in tx json, so it is not truncated on load. 3) Replace TxService::AddUnapprovedTransaction with per coin methods.

Timeline (4 of 10 events)
  1. 2026-03-27 10:40 Ready for review by supermassive
  2. 2026-04-08 15:08 Merged master by supermassive
  3. 2026-04-08 15:08 Closed by supermassive
  4. 2026-04-08 15:09 Milestone set 1.91.x - Nightly by github-actions

Recorded changes

  1. PR merged

    Merged: Drop signing fields from Eth TxData

    Merged into brave-core master on 2026-04-08. Only builds cut from master after this merge (Nightly first) can contain it; whether a published build does is checked per build (see build presence on the item). Beta and Release get it only after a branch cut or an uplift.

    brave-core#35012
    Evidence
    • merged 2026-04-08T15:08:13Z
    • repository brave/brave-core
    • base branch master

    Source time: · Detected: · Backfilled from source history

    2026-04-08T15:08:13Z