Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

[CodeHealth][cr146] `base::Contains` dissallowed when `.contains` suffices

In a Release build Pull request Testnet, tests & tooling

Lead item brave-core#33631 · opened by cdesouza-chromium · last source update

Issue state

No tracked issue; this group is led by a pull request.

Implementation

  • brave-core#33631 merged 2026-02-04 into master by cdesouza-chromium
    [CodeHealth][cr146] `base::Contains` dissallowed when `.contains` suffices
    Linked by: issue timeline (closing cross-reference or closed by this PR)

Release notes

No platform changelog lists this item.

Validation

No QA label.

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.88.x - Release

A milestone is a target set by Brave, not a release promise. Brave renames milestones as branches move from Nightly to Beta to Release.

Platforms (OS labels): none

Owner: unassigned · PR authors: cdesouza-chromium

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...95794072: behind); later builds of the same history include it (brave-core#33631)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...95794072: behind); later builds of the same history include it (brave-core#33631)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...95794072: behind); later builds of the same history include it (brave-core#33631)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...95794072: behind); later builds of the same history include it (brave-core#33631)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...95794072: behind); later builds of the same history include it (brave-core#33631)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...95794072: behind); later builds of the same history include it (brave-core#33631)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...95794072: behind); later builds of the same history include it (brave-core#33631)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...95794072: behind); later builds of the same history include it (brave-core#33631)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...95794072: behind); later builds of the same history include it (brave-core#33631)

Members and their history

Pull request

brave-core#33631 [CodeHealth][cr146] `base::Contains` dissallowed when `.contains` suffices

State: merged 2026-02-04 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:zcash is:pr

CI/run-network-audit feature/web3/wallet feature/web3/wallet/core puLL-Merge

This is being enforced by the compiler through a concept, and it only applies for cases where base::Contains is used without a projection. This change also carries out IWYU for base::Contains. Chromium changes: https://chromium.googlesource.com/chromium/src/+/4a17af8403373b7f7e7546ef61f30dfbe883d617 [code] Bug: https://github.com/brave/brave-browser/issues/42557

Timeline (4 of 8 events)
  1. 2026-02-04 16:22 Merged master by cdesouza-chromium
  2. 2026-02-04 16:22 Closed by cdesouza-chromium
  3. 2026-02-04 16:23 Milestone set 1.88.x - Nightly by github-actions
  4. 2026-02-10 14:23 Referenced by brave-browser#52732 by kjozwiak

Recorded changes

  1. PR merged

    Merged: [CodeHealth][cr146] `base::Contains` dissallowed when `.contains` suffices

    Merged into brave-core master on 2026-02-04. Only builds cut from master after this merge (Nightly first) can contain it; whether a published build does is checked per build (see build presence on the item). Beta and Release get it only after a branch cut or an uplift.

    brave-core#33631
    Evidence
    • merged 2026-02-04T16:22:50Z
    • repository brave/brave-core
    • base branch master

    Source time: · Detected: · Backfilled from source history

    2026-02-04T16:22:50Z