Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Wallet - Remove vestigial default base cryptocurrency setting

PR in progress Issue General Zcash support

Lead item brave-browser#59539 · opened by kdenhartog · last source update

This issue is open on GitHub. Fixes sometimes land through pull requests that do not link the issue (for example a later refactor); this tracker follows only explicit links (closing references, “Resolves” lines, brave_<issue> branch names, uplifts and the issue timeline).

Issue state

Open

Open.

Implementation

  • brave-core#40863 open into master by MarkusNuo
    [Wallet] Remove default base cryptocurrency setting
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

No platform changelog lists this item.

Validation

Not QA-tested (QA/No).

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

No milestone set.

Platforms (OS labels): Desktop

Owner: unassigned · PR authors: MarkusNuo

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopUnknown 1.97.59no merged PR is linked, so presence in this build is unknownUnknown 1.98.47no merged PR is linked, so presence in this build is unknownUnknown 1.100.5no merged PR is linked, so presence in this build is unknown
AndroidUnknown 1.97.57no merged PR is linked, so presence in this build is unknownUnknown 1.98.52no merged PR is linked, so presence in this build is unknownUnknown 1.100.5no merged PR is linked, so presence in this build is unknown
iOSUnknown 1.96.62no merged PR is linked, so presence in this build is unknownUnknown 1.99.44no merged PR is linked, so presence in this build is unknownUnknown 1.100.7no merged PR is linked, so presence in this build is unknown

Members and their history

Issue

brave-browser#59539 Wallet - Remove vestigial default base cryptocurrency setting

State: open · created · updated · discovered via search:zec · matched body:zec

priority/P3 QA/No release-notes/exclude feature/settings feature/web3/wallet OS/Desktop feature/web3/wallet/core

The "Default base cryptocurrency" dropdown in brave://settings/web3 is a no-op: the preference is stored and a change notification fires, but no feature (Buy, Swap, Portfolio) reads its value to pick a default asset — those screens use their own hardcoded defaults. It gives users the false impression the choice affects wallet behavior (reported by community in #51665, where selecting a value appears to do nothing). We should remove the setting and its plumbing rather than…

Timeline (16 of 23 events)
  1. 2026-09-30 23:09 Referenced by brave-browser#33034 by kdenhartog
  2. 2026-09-30 23:09 Referenced by brave-browser#59532 by kdenhartog
  3. 2026-09-30 23:09 Referenced by brave-browser#51665 by kdenhartog
  4. 2026-09-30 23:10 Label added QA/No by kdenhartog
  5. 2026-09-30 23:10 Label added release-notes/exclude by kdenhartog
  6. 2026-09-30 23:10 Label removed QA/No by kdenhartog
  7. 2026-09-30 23:10 Label removed release-notes/exclude by kdenhartog
  8. 2026-09-30 23:10 Label added OS/Desktop by kdenhartog
  9. 2026-09-30 23:11 Label added priority/P3 by kdenhartog
  10. 2026-09-30 23:11 Label added QA/No by kdenhartog
  11. 2026-09-30 23:11 Label removed QA/No by kdenhartog
  12. 2026-09-30 23:11 Label added priority/P3 by kdenhartog
  13. 2026-09-30 23:11 Label added release-notes/exclude by kdenhartog
  14. 2026-09-30 23:11 Label added OS/Desktop by kdenhartog
  15. 2026-09-30 23:12 Label added QA/No by kdenhartog
  16. 2026-10-16 08:45 Referenced by brave-core#40863 (will close) by MarkusNuo
Pull request

brave-core#40863 [Wallet] Remove default base cryptocurrency setting

State: open · created · updated · discovered via linked:brave/brave-browser#59539

Resolves https://github.com/brave/brave-browser/issues/59539 The "Default base cryptocurrency" setting in brave://settings/web3 had no effect: no wallet client used the stored value. This removes the setting, its mojom API, the change event and the UI plumbing on desktop, Android and iOS. The old pref is cleared from existing profiles on startup. Checked locally (Windows): build, presubmit, gn_check, BraveWalletServiceUnitTest, wallet prefs/utils/migration unit tests and…

Also mentioned by (not linked as fixes): brave-browser#59532, brave-browser#51665