Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

fix: Zcash Ironwood transactions miscalculate fees and action counts

In a Release build Bug Ironwood pool & migration

Lead item brave-browser#58957 · opened by kdenhartog · last source update

This issue is open on GitHub. Fixes sometimes land through pull requests that do not link the issue (for example a later refactor); this tracker follows only explicit links (closing references, “Resolves” lines, brave_<issue> branch names, uplifts and the issue timeline).

Issue state

Open

Open.

Implementation

  • brave-core#39877 merged 2026-09-16 into master by cypt4
    [ZCash] Fix ironwood fee calculation
    Linked by: branch name brave_58957 (weaker evidence; titles share a keyword)

Release notes

No platform changelog lists this item.

Validation

QA required (QA/Yes).

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

No milestone set.

Platforms (OS labels): none

Owner: unassigned · PR authors: cypt4

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.97.56 (GitHub compare v1.97.56...482afb5b: behind); later builds of the same history include it (brave-core#39877)Included 1.98.47in v1.97.56 (GitHub compare v1.97.56...482afb5b: behind); later builds of the same history include it (brave-core#39877)Included 1.100.5in v1.97.56 (GitHub compare v1.97.56...482afb5b: behind); later builds of the same history include it (brave-core#39877)
AndroidIncluded 1.97.57in v1.97.56 (GitHub compare v1.97.56...482afb5b: behind); later builds of the same history include it (brave-core#39877)Included 1.98.52in v1.97.56 (GitHub compare v1.97.56...482afb5b: behind); later builds of the same history include it (brave-core#39877)Included 1.100.5in v1.97.56 (GitHub compare v1.97.56...482afb5b: behind); later builds of the same history include it (brave-core#39877)
iOSNot included 1.96.62GitHub compare v1.96.62...482afb5b: diverged (brave-core#39877)Included 1.99.44in v1.97.56 (GitHub compare v1.97.56...482afb5b: behind); later builds of the same history include it (brave-core#39877)Included 1.100.7in v1.97.56 (GitHub compare v1.97.56...482afb5b: behind); later builds of the same history include it (brave-core#39877)

Members and their history

Issue

brave-browser#58957 fix: Zcash Ironwood transactions miscalculate fees and action counts

State: open · created · updated · discovered via label:feature/web3/wallet/zcash, search:ironwood, search:orchard wallet, search:shielded wallet, search:zcash · matched label:feature/web3/wallet/zcash, title:zcash, body:zcash

bug priority/P2 QA/Yes release-notes/exclude feature/web3/wallet feature/web3/wallet/zcash

Transactions spending from the Zcash Ironwood pool or transferring funds into Ironwood miscalculate required ZIP-317 transfer fees and action counts. The fee calculation assumes all shielded inputs and change belong to the legacy Orchard pool rather than Ironwood, leading to double-counted actions or incorrect fee estimates. This can cause users to overpay transaction fees or result in transaction creation failures. Technical Context & Implementation Details Problem…

Timeline (3 of 6 events)
  1. 2026-09-14 13:00 Label added priority/P2 by kdenhartog
  2. 2026-09-14 13:00 Label added QA/Yes by kdenhartog
  3. 2026-09-14 13:00 Label added release-notes/exclude by kdenhartog
Pull request

brave-core#39877 [ZCash] Fix ironwood fee calculation

State: merged 2026-09-16 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:ironwood is:pr, search:orchard is:pr, search:zcash is:pr · matched title:zcash

feature/web3/wallet feature/web3/wallet/core

- Resolves

Timeline (4 of 8 events)
  1. 2026-09-16 08:16 Ready for review by cypt4
  2. 2026-09-16 16:00 Merged master by cypt4
  3. 2026-09-16 16:00 Closed by cypt4
  4. 2026-09-16 16:00 Milestone set 1.97.x - Nightly by brave-builds

Recorded changes

  1. In a build Ironwood / migration

    In Android Release 1.97.56: fix: Zcash Ironwood transactions miscalculate fees and action counts

    The merged code (brave-core#39877) is now part of the Android Release build 1.97.56. This shows the code is in the build, not that every platform exposes the feature.

    brave-browser#58957
    Evidence
    • GitHub compare v1.97.56...482afb5b: behind

    Source time: · Detected: · Backfilled from source history

    2026-10-07T03:18:14Z
  2. PR merged Ironwood / migration

    Merged: [ZCash] Fix ironwood fee calculation

    Merged into brave-core master on 2026-09-16. Only builds cut from master after this merge (Nightly first) can contain it; whether a published build does is checked per build (see build presence on the item). Beta and Release get it only after a branch cut or an uplift.

    brave-core#39877
    Evidence
    • merged 2026-09-16T16:00:18Z
    • repository brave/brave-core
    • base branch master

    Source time: · Detected: · Backfilled from source history

    2026-09-16T16:00:18Z
  3. New issue

    New bug report: fix: Zcash Ironwood transactions miscalculate fees and action counts

    Opened in brave-browser#58957. This is a report or request, not a confirmed change to Brave Wallet.

    brave-browser#58957
    Evidence
    • created 2026-09-14T13:00:05Z

    Source time: · Detected: · Backfilled from source history

    2026-09-14T13:00:05Z