Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

fix: reject fractional Zcash account birthday blocks

In release notes Bug Sync, scanning & storage

Lead item brave-browser#58757 · opened by iAnonymous3000 · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#39811 merged 2026-09-11 into master by Douglashdaniel
    [Wallet]: Reject fractional Zcash birthday blocks
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

  • Desktop 1.97.56: “Updated wallet to reject incorrect Zcash account birthday height. (#58757)” changelog line

Release notes are per platform. Lines come from each platform’s Stable changelog. A platform without an entry is not covered by these lines.

Validation

QA required (QA/Yes).

  • QA Pass-macOS (Desktop only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.97.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: Douglashdaniel · PR authors: Douglashdaniel

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.97.56 (GitHub compare v1.97.56...748099ff: behind); later builds of the same history include it (brave-core#39811)Included 1.98.47in v1.97.56 (GitHub compare v1.97.56...748099ff: behind); later builds of the same history include it (brave-core#39811)Included 1.100.5in v1.97.56 (GitHub compare v1.97.56...748099ff: behind); later builds of the same history include it (brave-core#39811)
AndroidIncluded 1.97.57in v1.97.56 (GitHub compare v1.97.56...748099ff: behind); later builds of the same history include it (brave-core#39811)Included 1.98.52in v1.97.56 (GitHub compare v1.97.56...748099ff: behind); later builds of the same history include it (brave-core#39811)Included 1.100.5in v1.97.56 (GitHub compare v1.97.56...748099ff: behind); later builds of the same history include it (brave-core#39811)
iOSNot included 1.96.62GitHub compare v1.96.62...748099ff: diverged (brave-core#39811)Included 1.99.44in v1.97.56 (GitHub compare v1.97.56...748099ff: behind); later builds of the same history include it (brave-core#39811)Included 1.100.7in v1.97.56 (GitHub compare v1.97.56...748099ff: behind); later builds of the same history include it (brave-core#39811)

Members and their history

Issue

brave-browser#58757 fix: reject fractional Zcash account birthday blocks

State: closed (completed) · created · closed · updated · discovered via label:feature/web3/wallet/zcash, search:zcash · matched label:feature/web3/wallet/zcash, title:zcash

bug OS/macOS QA Pass-macOS priority/P4 QA/Yes release-notes/include feature/web3/wallet OS/Desktop front-end-change feature/web3/wallet/zcash

On macOS Nightly 1.97.1, entering 1687104.5 in Shield account → Advanced settings leaves Shield account enabled, although a block height must be a whole number. Reject fractional birthdays before enabling the action; the invalid value was not submitted, so the resulting sync behavior was not tested. cc @kdenhartog

Timeline (10 of 14 events)
  1. 2026-09-05 03:11 Label added OS/macOS by iAnonymous3000
  2. 2026-09-05 03:11 Label added priority/P4 by iAnonymous3000
  3. 2026-09-05 03:11 Label added QA/Yes by iAnonymous3000
  4. 2026-09-05 03:11 Label added release-notes/include by iAnonymous3000
  5. 2026-09-05 03:11 Label added OS/Desktop by iAnonymous3000
  6. 2026-09-11 17:35 Referenced by brave-core#39811 by Douglashdaniel
  7. 2026-09-11 21:49 Closed completed brave-core#39811 by Douglashdaniel
  8. 2026-09-11 21:49 Milestone set 1.97.x - Nightly by brave-builds
  9. 2026-09-28 07:45 Label added QA Pass-macOS by srirambv
  10. 2026-10-06 13:20 Referenced by brave-browser#59720 by LaurenWags
Pull request

brave-core#39811 [Wallet]: Reject fractional Zcash birthday blocks

State: merged 2026-09-11 · created · closed · updated · discovered via search:shielded is:pr, search:zcash is:pr · matched title:zcash, body:zcash

CI/storybook-url feature/web3/wallet

Description - Fixes fractional Zcash account birthday (e.g. 1687104.5) - Birthday blocks must be whole numbers in range. Typing ., -, +, e/E, or a leading 0 is ignored; values that aren't a whole number are not committed. - Empty still means “use the default chain tip” when shielding a new account. Existing too-low / too-high errors are unchanged. Test plan - [ ] Open Shield account → Advanced settings. Enter 1687104.5 (or try to type a .). Confirm the decimal is not…

Timeline (4 of 6 events)
  1. 2026-09-11 21:49 Merged master by Douglashdaniel
  2. 2026-09-11 21:49 Closed by Douglashdaniel
  3. 2026-09-11 21:49 Milestone set 1.97.x - Nightly by brave-builds
  4. 2026-09-28 07:45 Referenced by brave-browser#58757 by srirambv

Recorded changes

  1. Release notes Release

    Desktop 1.97.56 release notes: Updated wallet to reject incorrect Zcash account birthday height. (#58757)

    Listed in Brave's Desktop Stable release notes for 1.97.56. Release notes are per platform; other platforms need their own entry.

    CHANGELOG_DESKTOP.md L8 brave-browser#58757
    Evidence
    • "Updated wallet to reject incorrect Zcash account birthday height. (#58757)"
    • captured at commit 23d9de6d

    Source time: · Detected: · Backfilled from source history

    2026-10-07T03:18:14Z
  2. In a build Release

    In Android Release 1.97.56: fix: reject fractional Zcash account birthday blocks

    The merged code (brave-core#39811) is now part of the Android Release build 1.97.56. This shows the code is in the build, not that every platform exposes the feature.

    brave-browser#58757
    Evidence
    • GitHub compare v1.97.56...748099ff: behind

    Source time: · Detected: · Backfilled from source history

    2026-10-07T03:18:14Z
  3. QA passed

    QA Pass-macOS: fix: reject fractional Zcash account birthday blocks

    Brave QA marked this as passed on macOS. Other platforms are not covered by this label.

    brave-browser#58757
    Evidence
    • label "QA Pass-macOS" added at 2026-09-28T07:45:14Z

    Source time: · Detected: · Backfilled from source history

    2026-09-28T07:45:14Z
  4. Issue closed Fix

    Closed (completed): fix: reject fractional Zcash account birthday blocks

    Closed as completed. Listed in Desktop Stable 1.97.56 release notes.

    brave-browser#58757 brave-core#39811
    Evidence
    • closed by Douglashdaniel at 2026-09-11T21:49:32Z
    • state reason: completed

    Source time: · Detected: · Backfilled from source history

    2026-09-11T21:49:32Z
  5. PR merged Fix

    Merged: [Wallet]: Reject fractional Zcash birthday blocks

    Merged into brave-core master on 2026-09-11. Only builds cut from master after this merge (Nightly first) can contain it; whether a published build does is checked per build (see build presence on the item). Beta and Release get it only after a branch cut or an uplift.

    brave-core#39811
    Evidence
    • merged 2026-09-11T21:49:30Z
    • repository brave/brave-core
    • base branch master

    Source time: · Detected: · Backfilled from source history

    2026-09-11T21:49:30Z
  6. New issue

    New bug report: fix: reject fractional Zcash account birthday blocks

    Opened in brave-browser#58757. This is a report or request, not a confirmed change to Brave Wallet.

    brave-browser#58757
    Evidence
    • created 2026-09-05T03:11:33Z

    Source time: · Detected: · Backfilled from source history

    2026-09-05T03:11:33Z