Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

fix: reject negative Zcash send amounts before review

In release notes Bug Transactions & fees

Lead item brave-browser#58755 · opened by iAnonymous3000 · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#39703 merged 2026-09-09 into master by Douglashdaniel
    [Wallet]: Reject negative and leading-zero amounts on Send and Swap
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

  • Desktop 1.97.56: “Updated wallet to reject negative Zcash "Send" amounts before review. (#58755)” changelog line

Release notes are per platform. Lines come from each platform’s Stable changelog. A platform without an entry is not covered by these lines.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)
  • QA Pass-macOS (Desktop only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.97.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: Douglashdaniel · PR authors: Douglashdaniel

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.97.56 (GitHub compare v1.97.56...aaa04be1: behind); later builds of the same history include it (brave-core#39703)Included 1.98.47in v1.97.56 (GitHub compare v1.97.56...aaa04be1: behind); later builds of the same history include it (brave-core#39703)Included 1.100.5in v1.97.56 (GitHub compare v1.97.56...aaa04be1: behind); later builds of the same history include it (brave-core#39703)
AndroidIncluded 1.97.57in v1.97.56 (GitHub compare v1.97.56...aaa04be1: behind); later builds of the same history include it (brave-core#39703)Included 1.98.52in v1.97.56 (GitHub compare v1.97.56...aaa04be1: behind); later builds of the same history include it (brave-core#39703)Included 1.100.5in v1.97.56 (GitHub compare v1.97.56...aaa04be1: behind); later builds of the same history include it (brave-core#39703)
iOSNot included 1.96.62GitHub compare v1.96.62...aaa04be1: diverged (brave-core#39703)Included 1.99.44in v1.97.56 (GitHub compare v1.97.56...aaa04be1: behind); later builds of the same history include it (brave-core#39703)Included 1.100.7in v1.97.56 (GitHub compare v1.97.56...aaa04be1: behind); later builds of the same history include it (brave-core#39703)

Members and their history

Issue

brave-browser#58755 fix: reject negative Zcash send amounts before review

State: closed (completed) · created · closed · updated · discovered via label:feature/web3/wallet/zcash, search:zcash, search:zec · matched label:feature/web3/wallet/zcash, title:zcash, body:zec

bug OS/macOS QA Pass-Win64 QA Pass-macOS priority/P4 QA/Yes release-notes/include feature/web3/wallet OS/Desktop front-end-change feature/web3/wallet/zcash

On macOS Nightly 1.97.1, entering -1 or -0.00000001 ZEC with a valid transparent recipient enables Review send, even with a zero balance. Reviewing -1 then produces a generic transaction error suggesting a smaller amount, instead of explaining that the amount must be positive. Reject negative amounts before enabling review; no successful transfer was observed. cc @kdenhartog

Timeline (11 of 15 events)
  1. 2026-09-05 03:10 Label added OS/macOS by iAnonymous3000
  2. 2026-09-05 03:10 Label added priority/P4 by iAnonymous3000
  3. 2026-09-05 03:10 Label added QA/Yes by iAnonymous3000
  4. 2026-09-05 03:10 Label added release-notes/include by iAnonymous3000
  5. 2026-09-05 03:10 Label added OS/Desktop by iAnonymous3000
  6. 2026-09-08 21:10 Referenced by brave-core#39703 by Douglashdaniel
  7. 2026-09-09 17:13 Closed completed brave-core#39703 by Douglashdaniel
  8. 2026-09-09 17:13 Milestone set 1.97.x - Nightly by brave-builds
  9. 2026-09-28 06:53 Label added QA Pass-Win64 by srirambv
  10. 2026-09-28 06:56 Label added QA Pass-macOS by srirambv
  11. 2026-10-06 13:20 Referenced by brave-browser#59720 by LaurenWags
Pull request

brave-core#39703 [Wallet]: Reject negative and leading-zero amounts on Send and Swap

State: merged 2026-09-09 · created · closed · updated · discovered via linked:brave/brave-browser#58755

CI/storybook-url feature/web3/wallet

Description - Blocks negative values on Send and Swap amount inputs. - Blocks leading zeros unless the next character is a decimal (allow 0.5, reject 05.5). - Shared via Amount.isInvalidAmountInput() so Send and both Swap fields stay consistent. Test plan - [ ] Send: typing - or a negative amount does not change the field - [ ] Send: 05 / 05.5 / 00 are rejected; 0, 0., 0.5, 0.05, and 10.5 still work - [ ] Swap from amount: same as Send - [ ] Swap to amount: same as Send - […

Timeline (4 of 6 events)
  1. 2026-09-09 17:13 Merged master by Douglashdaniel
  2. 2026-09-09 17:13 Closed by Douglashdaniel
  3. 2026-09-09 17:13 Milestone set 1.97.x - Nightly by brave-builds
  4. 2026-09-28 06:53 Referenced by brave-browser#58755 by srirambv

Recorded changes

  1. In a build Release

    In Android Release 1.97.56: fix: reject negative Zcash send amounts before review

    The merged code (brave-core#39703) is now part of the Android Release build 1.97.56. This shows the code is in the build, not that every platform exposes the feature.

    brave-browser#58755
    Evidence
    • GitHub compare v1.97.56...aaa04be1: behind

    Source time: · Detected: · Backfilled from source history

    2026-10-07T03:18:14Z
  2. Release notes Release

    Desktop 1.97.56 release notes: Updated wallet to reject negative Zcash "Send" amounts before review. (#58755)

    Listed in Brave's Desktop Stable release notes for 1.97.56. Release notes are per platform; other platforms need their own entry.

    CHANGELOG_DESKTOP.md L9 brave-browser#58755
    Evidence
    • "Updated wallet to reject negative Zcash "Send" amounts before review. (#58755)"
    • captured at commit 23d9de6d

    Source time: · Detected: · Backfilled from source history

    2026-10-07T03:18:14Z
  3. QA passed

    QA Pass-macOS: fix: reject negative Zcash send amounts before review

    Brave QA marked this as passed on macOS. Other platforms are not covered by this label.

    brave-browser#58755
    Evidence
    • label "QA Pass-macOS" added at 2026-09-28T06:56:27Z

    Source time: · Detected: · Backfilled from source history

    2026-09-28T06:56:27Z
  4. QA passed

    QA Pass-Win64: fix: reject negative Zcash send amounts before review

    Brave QA marked this as passed on Win64. Other platforms are not covered by this label.

    brave-browser#58755
    Evidence
    • label "QA Pass-Win64" added at 2026-09-28T06:53:26Z

    Source time: · Detected: · Backfilled from source history

    2026-09-28T06:53:26Z
  5. Issue closed Fix

    Closed (completed): fix: reject negative Zcash send amounts before review

    Closed as completed. Listed in Desktop Stable 1.97.56 release notes.

    brave-browser#58755 brave-core#39703
    Evidence
    • closed by Douglashdaniel at 2026-09-09T17:13:23Z
    • state reason: completed

    Source time: · Detected: · Backfilled from source history

    2026-09-09T17:13:23Z
  6. PR merged Fix

    Merged: [Wallet]: Reject negative and leading-zero amounts on Send and Swap

    Merged into brave-core master on 2026-09-09. Only builds cut from master after this merge (Nightly first) can contain it; whether a published build does is checked per build (see build presence on the item). Beta and Release get it only after a branch cut or an uplift.

    brave-core#39703
    Evidence
    • merged 2026-09-09T17:13:22Z
    • repository brave/brave-core
    • base branch master

    Source time: · Detected: · Backfilled from source history

    2026-09-09T17:13:22Z
  7. New issue

    New bug report: fix: reject negative Zcash send amounts before review

    Opened in brave-browser#58755. This is a report or request, not a confirmed change to Brave Wallet.

    brave-browser#58755
    Evidence
    • created 2026-09-05T03:10:46Z

    Source time: · Detected: · Backfilled from source history

    2026-09-05T03:10:46Z