Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Cancel pending wallet signing requests when a site's permission is revoked

In a Release build Bug Security & hardening Security

Lead item brave-browser#57645 · opened by kdenhartog · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#38854 merged 2026-08-28 into master by kdenhartog
    [wallet] Proactively reject pending requests when site permission is revoked
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

No platform changelog lists this item.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)
  • QA Pass-Android ARM (Android only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.96.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Android, Desktop

Owner: kdenhartog · PR authors: kdenhartog

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...78a6696c: behind); later builds of the same history include it (brave-core#38854)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...78a6696c: behind); later builds of the same history include it (brave-core#38854)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...78a6696c: behind); later builds of the same history include it (brave-core#38854)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...78a6696c: behind); later builds of the same history include it (brave-core#38854)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...78a6696c: behind); later builds of the same history include it (brave-core#38854)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...78a6696c: behind); later builds of the same history include it (brave-core#38854)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...78a6696c: behind); later builds of the same history include it (brave-core#38854)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...78a6696c: behind); later builds of the same history include it (brave-core#38854)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...78a6696c: behind); later builds of the same history include it (brave-core#38854)

Members and their history

Issue

brave-browser#57645 Cancel pending wallet signing requests when a site's permission is revoked

State: closed (completed) · created · closed · updated · discovered via linked:brave/brave-core#38854

bug security QA Pass-Win64 priority/P4 QA/Yes release-notes/exclude feature/web3/wallet OS/Android QA Pass - Android ARM OS/Desktop feature/web3/wallet/core

See internal issue for details: [GitHub link omitted]

Timeline (12 of 17 events)
  1. 2026-07-29 13:16 Label added priority/P4 by kdenhartog
  2. 2026-07-29 13:16 Label added QA/Yes by kdenhartog
  3. 2026-07-29 13:16 Label added release-notes/exclude by kdenhartog
  4. 2026-07-29 13:16 Label added OS/Android by kdenhartog
  5. 2026-07-29 13:16 Label added OS/Desktop by kdenhartog
  6. 2026-07-29 13:16 Label added OS/iOS by kdenhartog
  7. 2026-08-06 09:11 Referenced by brave-core#38854 by kdenhartog
  8. 2026-08-28 10:42 Closed completed brave-core#38854 by kdenhartog
  9. 2026-08-28 10:43 Milestone set 1.96.x - Nightly by brave-builds
  10. 2026-09-17 04:53 Label added QA Pass-Win64 by srirambv
  11. 2026-09-17 05:56 Label added QA Pass - Android ARM by srirambv
  12. 2026-09-17 06:03 Referenced by brave-browser#59096 by srirambv
Pull request

brave-core#38854 [wallet] Proactively reject pending requests when site permission is revoked

State: merged 2026-08-28 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:zcash is:pr

feature/web3/wallet feature/web3/wallet/core puLL-Merge

Fixes https://github.com/brave/brave-browser/issues/57645 Fixes [reference omitted] A queued transaction / sign request stayed visible in the panel after the user cleared the site's wallet permission via brave://settings/content/ethereum (which writes to HostContentSettingsMap directly, bypassing BraveWalletService::ResetPermission). The user could still open the panel and approve the stale request. Observe HostContentSettingsMap from BraveWalletServiceDelegateBase for…

Timeline (3 of 8 events)
  1. 2026-08-28 10:42 Merged master by kdenhartog
  2. 2026-08-28 10:42 Closed by kdenhartog
  3. 2026-08-28 10:43 Milestone set 1.96.x - Nightly by brave-builds

Recorded changes

  1. QA passed

    QA Pass - Android ARM: Cancel pending wallet signing requests when a site's permission is revoked

    Brave QA marked this as passed on Android ARM. Other platforms are not covered by this label.

    brave-browser#57645
    Evidence
    • label "QA Pass - Android ARM" added at 2026-09-17T05:56:59Z

    Source time: · Detected: · Backfilled from source history

    2026-09-17T05:56:59Z
  2. QA passed

    QA Pass-Win64: Cancel pending wallet signing requests when a site's permission is revoked

    Brave QA marked this as passed on Win64. Other platforms are not covered by this label.

    brave-browser#57645
    Evidence
    • label "QA Pass-Win64" added at 2026-09-17T04:53:53Z

    Source time: · Detected: · Backfilled from source history

    2026-09-17T04:53:53Z
  3. Issue closed Security

    Closed (completed): Cancel pending wallet signing requests when a site's permission is revoked

    Closed as completed; linked PR merged 2026-08-28. Code is in current Release builds for Desktop, Android, iOS.

    brave-browser#57645 brave-core#38854
    Evidence
    • closed by kdenhartog at 2026-08-28T10:42:58Z
    • state reason: completed

    Source time: · Detected: · Backfilled from source history

    2026-08-28T10:42:58Z
  4. PR merged Security

    Merged: [wallet] Proactively reject pending requests when site permission is revoked

    Merged into brave-core master on 2026-08-28. Only builds cut from master after this merge (Nightly first) can contain it; whether a published build does is checked per build (see build presence on the item). Beta and Release get it only after a branch cut or an uplift.

    brave-core#38854
    Evidence
    • merged 2026-08-28T10:42:57Z
    • repository brave/brave-core
    • base branch master

    Source time: · Detected: · Backfilled from source history

    2026-08-28T10:42:57Z
  5. New issue

    New bug report: Cancel pending wallet signing requests when a site's permission is revoked

    Opened in brave-browser#57645. This is a report or request, not a confirmed change to Brave Wallet.

    brave-browser#57645
    Evidence
    • created 2026-07-29T13:16:34Z

    Source time: · Detected: · Backfilled from source history

    2026-07-29T13:16:34Z