Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

[ZCash] Add Ironwood pool argument to orchard storage to keep ironwood related data.

In a Release build Task Ironwood pool & migration

Lead item brave-browser#57122 · opened by cypt4 · last source update

Part of [ZCash] Ironwood support root issue. (brave-browser#56872).

Issue state

Closed (completed)

Closed . GitHub type: Task.

Implementation

  • brave-core#37999 merged 2026-07-17 into master by cypt4
    [ZCash] Migrate database to support ironwood pool.
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

No platform changelog lists this item.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.94.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: cypt4 · PR authors: cypt4

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...9f1b4d71: behind); later builds of the same history include it (brave-core#37999)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...9f1b4d71: behind); later builds of the same history include it (brave-core#37999)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...9f1b4d71: behind); later builds of the same history include it (brave-core#37999)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...9f1b4d71: behind); later builds of the same history include it (brave-core#37999)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...9f1b4d71: behind); later builds of the same history include it (brave-core#37999)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...9f1b4d71: behind); later builds of the same history include it (brave-core#37999)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...9f1b4d71: behind); later builds of the same history include it (brave-core#37999)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...9f1b4d71: behind); later builds of the same history include it (brave-core#37999)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...9f1b4d71: behind); later builds of the same history include it (brave-core#37999)

Members and their history

Issue

brave-browser#57122 [ZCash] Add Ironwood pool argument to orchard storage to keep ironwood related data.

State: closed (completed) · created · closed · updated · discovered via search:ironwood, search:zcash · matched title:zcash, title:orchard, body:ironwood

QA Pass-Win64 priority/P3 QA/Yes release-notes/exclude feature/web3/wallet OS/Desktop feature/web3/wallet/core

Description Ironwood pool has a separate set of spendable notes, shard tree, etc.. OrchardStorage currently keeps this data for orchard pool, we need separate tables for ironwood pool. Steps to reproduce - Actual result - Expected result - Reproduces how often Easily reproduced Brave version (brave://version info) - Channel information - [ ] release (stable) - [ ] beta - [ ] nightly Reproducibility - [ ] with Brave Shields disabled - [ ] with Brave Rewards disabled - [ ] in…

Timeline (14 of 18 events)
  1. 2026-07-14 08:11 Label added OS/Desktop by cypt4
  2. 2026-07-14 08:17 Referenced by brave-browser#56872 by cypt4
  3. 2026-07-14 09:24 Referenced by brave-core#37999 by cypt4
  4. 2026-07-17 10:25 Closed completed brave-core#37999 by cypt4
  5. 2026-07-17 10:25 Milestone set 1.94.x - Nightly by brave-builds
  6. 2026-07-17 10:29 Label added priority/P3 by cypt4
  7. 2026-07-17 10:29 Label added QA/Yes by cypt4
  8. 2026-07-17 10:29 Label added release-notes/exclude by cypt4
  9. 2026-08-11 13:59 Label added QA Pass - Android ARM by srirambv
  10. 2026-08-12 08:38 Label removed QA Pass - Android ARM by srirambv
  11. 2026-08-13 14:22 Referenced by brave-browser#58130 by srirambv
  12. 2026-08-13 14:23 Label added QA/Blocked by srirambv
  13. 2026-08-24 11:06 Label removed QA/Blocked by srirambv
  14. 2026-08-24 11:06 Label added QA Pass-Win64 by srirambv
Pull request

brave-core#37999 [ZCash] Migrate database to support ironwood pool.

State: merged 2026-07-17 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:ironwood is:pr, search:orchard is:pr, search:zcash is:pr · matched title:zcash, body:orchard

needs-security-review feature/web3/wallet feature/web3/wallet/core puLL-Merge

This PR adds "pool" column to orchard storage database tables so we can keep data for both pools. Resolves https://github.com/brave/brave-browser/issues/57122 Testplan: Verify correct orchard funds migration from older version to the new one. Verify orchard funds(balance\spendings) are correctly working on the new version. Verify sync state is not reset after version update.

Timeline (8 of 14 events)
  1. 2026-07-14 09:36 Ready for review by cypt4
  2. 2026-07-17 09:41 Referenced by brave-browser#57227 by cypt4
  3. 2026-07-17 10:25 Merged master by cypt4
  4. 2026-07-17 10:25 Closed by cypt4
  5. 2026-07-17 10:25 Milestone set 1.94.x - Nightly by brave-builds
  6. 2026-07-17 14:14 Referenced by brave-core#38059 by cypt4
  7. 2026-08-11 13:58 Referenced by brave-browser#57122 by srirambv
  8. 2026-08-11 13:59 Referenced by brave-browser#56840 by srirambv

Also mentioned by (not linked as fixes): brave-browser#56872, brave-browser#58130

Recorded changes

  1. QA passed

    QA Pass-Win64: [ZCash] Add Ironwood pool argument to orchard storage to keep ironwood related data.

    Brave QA marked this as passed on Win64. Other platforms are not covered by this label.

    brave-browser#57122
    Evidence
    • label "QA Pass-Win64" added at 2026-08-24T11:06:36Z

    Source time: · Detected: · Backfilled from source history

    2026-08-24T11:06:36Z
  2. QA passed

    QA Pass - Android ARM: [ZCash] Add Ironwood pool argument to orchard storage to keep ironwood related data.

    Brave QA marked this as passed on Android ARM. Other platforms are not covered by this label.

    brave-browser#57122
    Evidence
    • label "QA Pass - Android ARM" added at 2026-08-11T13:59:01Z

    Source time: · Detected: · Backfilled from source history

    2026-08-11T13:59:01Z
  3. Issue closed Ironwood / migration

    Closed (completed): [ZCash] Add Ironwood pool argument to orchard storage to keep ironwood related data.

    Closed as completed; linked PR merged 2026-07-17. Code is in current Release builds for Desktop, Android, iOS.

    brave-browser#57122 brave-core#37999
    Evidence
    • closed by cypt4 at 2026-07-17T10:25:24Z
    • state reason: completed

    Source time: · Detected: · Backfilled from source history

    2026-07-17T10:25:24Z
  4. PR merged Ironwood / migration

    Merged: [ZCash] Migrate database to support ironwood pool.

    Merged into brave-core master on 2026-07-17. Only builds cut from master after this merge (Nightly first) can contain it; whether a published build does is checked per build (see build presence on the item). Beta and Release get it only after a branch cut or an uplift.

    brave-core#37999
    Evidence
    • merged 2026-07-17T10:25:23Z
    • repository brave/brave-core
    • base branch master

    Source time: · Detected: · Backfilled from source history

    2026-07-17T10:25:23Z
  5. New issue

    New issue: [ZCash] Add Ironwood pool argument to orchard storage to keep ironwood related data.

    Opened in brave-browser#57122. This is a report or request, not a confirmed change to Brave Wallet.

    brave-browser#57122
    Evidence
    • created 2026-07-14T08:11:15Z

    Source time: · Detected: · Backfilled from source history

    2026-07-14T08:11:15Z