Zcash × Brave WalletPersonal project

Type to search. Use ↑ ↓ and Enter to open a result.

[ZCash] Transactions is being stuck in pending state if not included to the blockchain.

In release notes Bug Transactions & fees

Lead item brave-browser#56490 · opened by cypt4 · last source update

Issue state

Closed (completed)

Closed . GitHub type: Bug.

Implementation

  • brave-core#37365 merged 2026-06-19 into master by cypt4
    [ZCash] Check expiry height even if transaction is not found.
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description, branch name brave_56490 (weaker evidence; titles share a keyword)

Uplifts to release branches

Release notes

  • Desktop 1.92.138: “Fixed issue where transactions could be stuck in pending state in certain cases. (#56490)” changelog line

Release notes are per platform. Lines come from each platform’s Stable changelog. A platform without an entry is not covered by these lines.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.92.x - Release #3

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: cypt4 · PR authors: cypt4, brave-builds

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...b54e8d4c: behind); later builds of the same history include it (brave-core#37365)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...b54e8d4c: behind); later builds of the same history include it (brave-core#37365)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...b54e8d4c: behind); later builds of the same history include it (brave-core#37365)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...b54e8d4c: behind); later builds of the same history include it (brave-core#37365)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...b54e8d4c: behind); later builds of the same history include it (brave-core#37365)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...b54e8d4c: behind); later builds of the same history include it (brave-core#37365)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...b54e8d4c: behind); later builds of the same history include it (brave-core#37365)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...b54e8d4c: behind); later builds of the same history include it (brave-core#37365)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...b54e8d4c: behind); later builds of the same history include it (brave-core#37365)

Members and their history

Issue

brave-browser#56490 [ZCash] Transactions is being stuck in pending state if not included to the blockchain.

State: closed (completed) · created · closed · updated · discovered via label:feature/web3/wallet/zcash, search:zcash · matched label:feature/web3/wallet/zcash, title:zcash

QA Pass-Win64 priority/P3 QA/Yes release-notes/include feature/web3/wallet OS/Desktop feature/web3/wallet/core feature/web3/wallet/zcash

Description There are several reports of swap transaction being stuck due pending state issue. Steps to reproduce 1. 2. 3. Actual result - Expected result - Reproduces how often Easily reproduced Brave version (brave://version info) - Channel information - [ ] release (stable) - [ ] beta - [ ] nightly Reproducibility - [ ] with Brave Shields disabled - [ ] with Brave Rewards disabled - [ ] in the latest version of Chrome Miscellaneous information _No response_

Timeline (13 of 16 events)
  1. 2026-06-18 07:30 Label added OS/Desktop by cypt4
  2. 2026-06-19 12:47 Referenced by brave-core#37365 by cypt4
  3. 2026-06-19 12:47 Label added QA/Yes by cypt4
  4. 2026-06-19 12:47 Label added release-notes/include by cypt4
  5. 2026-06-19 16:17 Closed completed brave-core#37365 by cypt4
  6. 2026-06-19 16:18 Milestone set 1.93.x - Nightly by brave-builds
  7. 2026-06-19 16:23 Referenced by brave-core#37407 by brave-builds
  8. 2026-06-19 16:23 Referenced by brave-core#37408 by brave-builds
  9. 2026-06-19 16:23 Label added priority/P3 by cypt4
  10. 2026-07-06 19:13 Milestone removed 1.93.x - Beta by brave-builds
  11. 2026-07-06 19:13 Milestone set 1.92.x - Release #3 by brave-builds
  12. 2026-07-07 13:33 Label added QA Pass-Win64 by srirambv
  13. 2026-07-08 12:40 Referenced by brave-browser#56986 by LaurenWags
Pull request

brave-core#37365 [ZCash] Check expiry height even if transaction is not found.

State: merged 2026-06-19 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:orchard is:pr, search:shielded is:pr, search:zcash is:pr · matched title:zcash, body:shielded

CI/storybook-url feature/web3/wallet feature/web3/wallet/core

This PR fixes transaction state if transaction is not found in blockchain after expiration hit. Test plan: 1) Initiate swap transaction(shielded -> solana) on a version before orchard crate bump. Ensure transaction is frozen in pending state(move system clocks 3h forward, wait 20 blocks added to the blockchain). Update to the new browser version check transaction state changed to rejected. 2) Test that transactions(swap, t->s, s->t, t->t) initiated on the new version work…

Timeline (6 of 9 events)
  1. 2026-06-19 16:17 Merged master by cypt4
  2. 2026-06-19 16:17 Closed by cypt4
  3. 2026-06-19 16:17 Milestone set 1.93.x - Nightly by brave-builds
  4. 2026-06-19 16:23 Referenced by brave-core#37407 by brave-builds
  5. 2026-06-19 16:23 Referenced by brave-core#37408 by brave-builds
  6. 2026-07-07 13:33 Referenced by brave-browser#56490 by srirambv
Uplift PR → 1.92.x

brave-core#37407 [ZCash] Check expiry height even if transaction is not found. (uplift to 1.92.x)

State: merged 2026-07-06 · created · closed · updated · discovered via search:zcash is:pr · matched title:zcash

CI/storybook-url feature/web3/wallet feature/web3/wallet/core

Uplift of #37365 Resolves https://github.com/brave/brave-browser/issues/56490 Pre-approval checklist: - [x] You have tested your change on Nightly. - [ ] This contains text which needs to be translated. - [ ] There are more than 7 days before the release. - [ ] I've notified folks in #l10n on Slack that translations are needed. - [x] The PR milestones match the branch they are landing to. Pre-merge checklist: - [x] You have checked CI and the builds, lint, and tests all…

Timeline (7 of 12 events)
  1. 2026-06-19 16:23 Milestone set 1.92.x - Beta by brave-builds
  2. 2026-07-03 06:30 Milestone removed 1.92.x - Release by kjozwiak
  3. 2026-07-03 06:30 Milestone set 1.92.x - Release #2 by kjozwiak
  4. 2026-07-06 19:12 Milestone removed 1.92.x - Release #2 by kjozwiak
  5. 2026-07-06 19:12 Milestone set 1.92.x - Release #3 by kjozwiak
  6. 2026-07-06 19:13 Merged 1.92.x by kjozwiak
  7. 2026-07-06 19:13 Closed by kjozwiak
Uplift PR → 1.91.x

brave-core#37408 [ZCash] Check expiry height even if transaction is not found. (uplift to 1.91.x)

State: closed without merge · created · closed · updated · discovered via search:zcash is:pr · matched title:zcash

CI/storybook-url feature/web3/wallet feature/web3/wallet/core

Uplift of #37365 Resolves https://github.com/brave/brave-browser/issues/56490 Pre-approval checklist: - [ ] You have tested your change on Nightly. - [ ] This contains text which needs to be translated. - [ ] There are more than 7 days before the release. - [ ] I've notified folks in #l10n on Slack that translations are needed. - [ ] The PR milestones match the branch they are landing to. Pre-merge checklist: - [ ] You have checked CI and the builds, lint, and tests all…

Timeline (3 of 6 events)
  1. 2026-06-19 16:23 Milestone set 1.91.x - Release #5 by brave-builds
  2. 2026-06-24 14:39 Closed by kjozwiak
  3. 2026-06-24 14:39 Milestone removed 1.91.x - Release #5 by kjozwiak

Recorded changes

  1. Release notes Release

    Desktop 1.92.138 release notes: Fixed issue where transactions could be stuck in pending state in certain cases. (#56490)

    Listed in Brave's Desktop Stable release notes for 1.92.138. Release notes are per platform; other platforms need their own entry.

    CHANGELOG_DESKTOP.md L250 brave-browser#56490
    Evidence
    • "Fixed issue where transactions could be stuck in pending state in certain cases. (#56490)"
    • captured at commit 23d9de6d

    Source time: · Detected: · Backfilled from source history

    2026-07-08T07:48:47Z
  2. QA passed

    QA Pass-Win64: [ZCash] Transactions is being stuck in pending state if not included to the blockchain.

    Brave QA marked this as passed on Win64. Other platforms are not covered by this label.

    brave-browser#56490
    Evidence
    • label "QA Pass-Win64" added at 2026-07-07T13:33:26Z

    Source time: · Detected: · Backfilled from source history

    2026-07-07T13:33:26Z
  3. Uplift merged Fix

    Uplifted to 1.92.x: [ZCash] Check expiry height even if transaction is not found. (uplift to 1.92.x)

    Merged into the 1.92.x branch. It ships when a 1.92.x build is published; see build presence on the item.

    brave-core#37407
    Evidence
    • merged 2026-07-06T19:13:47Z
    • repository brave/brave-core
    • base branch 1.92.x

    Source time: · Detected: · Backfilled from source history

    2026-07-06T19:13:47Z
  4. PR closed

    PR closed without merging: [ZCash] Check expiry height even if transaction is not found. (uplift to 1.91.x)

    This pull request was closed without being merged, so its change did not land through it.

    brave-core#37408
    Evidence
    • closed 2026-06-24T14:39:37Z
    • merged: no

    Source time: · Detected: · Backfilled from source history

    2026-06-24T14:39:37Z
  5. Issue closed Fix

    Closed (completed): [ZCash] Transactions is being stuck in pending state if not included to the blockchain.

    Closed as completed. Listed in Desktop Stable 1.92.138 release notes.

    brave-browser#56490 brave-core#37365
    Evidence
    • closed by cypt4 at 2026-06-19T16:17:56Z
    • state reason: completed

    Source time: · Detected: · Backfilled from source history

    2026-06-19T16:17:56Z
  6. PR merged Fix

    Merged: [ZCash] Check expiry height even if transaction is not found.

    Merged into brave-core master on 2026-06-19. Only builds cut from master after this merge (Nightly first) can contain it; whether a published build does is checked per build (see build presence on the item). Beta and Release get it only after a branch cut or an uplift.

    brave-core#37365
    Evidence
    • merged 2026-06-19T16:17:55Z
    • repository brave/brave-core
    • base branch master

    Source time: · Detected: · Backfilled from source history

    2026-06-19T16:17:55Z
  7. New issue

    New bug report: [ZCash] Transactions is being stuck in pending state if not included to the blockchain.

    Opened in brave-browser#56490. This is a report or request, not a confirmed change to Brave Wallet.

    brave-browser#56490
    Evidence
    • created 2026-06-18T07:30:36Z

    Source time: · Detected: · Backfilled from source history

    2026-06-18T07:30:36Z