Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Wallet transactions db should not be shared with incognito profile

In a Release build Issue Transactions & fees

Lead item brave-browser#54435 · opened by supermassive · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#35426 merged 2026-04-28 into master by supermassive
    [Wallet] Refactor TxStorageDelegateImpl
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

No platform changelog lists this item.

Validation

Not QA-tested (QA/No).

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.91.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: supermassive · PR authors: supermassive

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...095628a8: behind); later builds of the same history include it (brave-core#35426)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...095628a8: behind); later builds of the same history include it (brave-core#35426)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...095628a8: behind); later builds of the same history include it (brave-core#35426)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...095628a8: behind); later builds of the same history include it (brave-core#35426)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...095628a8: behind); later builds of the same history include it (brave-core#35426)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...095628a8: behind); later builds of the same history include it (brave-core#35426)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...095628a8: behind); later builds of the same history include it (brave-core#35426)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...095628a8: behind); later builds of the same history include it (brave-core#35426)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...095628a8: behind); later builds of the same history include it (brave-core#35426)

Members and their history

Issue

brave-browser#54435 Wallet transactions db should not be shared with incognito profile

State: closed (completed) · created · closed · updated · discovered via linked:brave/brave-core#35426

privacy QA/No release-notes/exclude feature/web3/wallet OS/Desktop feature/web3/wallet/core

Description In additional to in-memory tx list we also use database to persist and load it on browser restart. For incognito we just don't need to persist tx list.

Timeline (6 of 9 events)
  1. 2026-04-13 01:15 Referenced by brave-core#35426 by supermassive
  2. 2026-04-28 05:00 Closed completed brave-core#35426 by supermassive
  3. 2026-04-28 05:01 Milestone set 1.91.x - Nightly by brave-builds
  4. 2026-05-06 08:11 Label added QA/No by supermassive
  5. 2026-05-06 08:11 Label added release-notes/exclude by supermassive
  6. 2026-05-06 08:11 Label added OS/Desktop by supermassive
Pull request

brave-core#35426 [Wallet] Refactor TxStorageDelegateImpl

State: merged 2026-04-28 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:zcash is:pr

feature/web3/wallet feature/web3/wallet/core puLL-Merge

Resolves https://github.com/brave/brave-browser/issues/54435 - Refactored TxStorageDelegateImpl to TxStorage - ~For incognito there is now in-memory TxStorage is created (see brave_wallet_service.cc) changes.~

Timeline (6 of 9 events)
  1. 2026-04-13 10:25 Ready for review by supermassive
  2. 2026-04-14 13:14 Converted to draft by supermassive
  3. 2026-04-27 04:39 Ready for review by supermassive
  4. 2026-04-28 05:00 Merged master by supermassive
  5. 2026-04-28 05:00 Closed by supermassive
  6. 2026-04-28 05:00 Milestone set 1.91.x - Nightly by github-actions

Recorded changes

  1. Issue closed

    Closed (completed): Wallet transactions db should not be shared with incognito profile

    Closed as completed; linked PR merged 2026-04-28. Code is in current Release builds for Desktop, Android, iOS.

    brave-browser#54435 brave-core#35426
    Evidence
    • closed by supermassive at 2026-04-28T05:00:40Z
    • state reason: completed

    Source time: · Detected: · Backfilled from source history

    2026-04-28T05:00:40Z
  2. PR merged

    Merged: [Wallet] Refactor TxStorageDelegateImpl

    Merged into brave-core master on 2026-04-28. Only builds cut from master after this merge (Nightly first) can contain it; whether a published build does is checked per build (see build presence on the item). Beta and Release get it only after a branch cut or an uplift.

    brave-core#35426
    Evidence
    • merged 2026-04-28T05:00:38Z
    • repository brave/brave-core
    • base branch master

    Source time: · Detected: · Backfilled from source history

    2026-04-28T05:00:38Z
  3. New issue

    New issue: Wallet transactions db should not be shared with incognito profile

    Opened in brave-browser#54435. This is a report or request, not a confirmed change to Brave Wallet.

    brave-browser#54435
    Evidence
    • created 2026-04-13T01:15:24Z

    Source time: · Detected: · Backfilled from source history

    2026-04-13T01:15:24Z