Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

[Wallet] Zcash transaction continues to show loading spinner even after transaction is completed

In a Release build Bug Transactions & fees

Lead item brave-browser#53750 · opened by srirambv · last source update

Issue state

Closed (completed)

Closed . GitHub type: Bug.

Implementation

  • brave-core#35466 merged 2026-04-14 into master by onyb
    [Wallet] Fix bridge spinner and swap "()" in transaction activity
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Uplifts to release branches

Release notes

No platform changelog lists this item.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.90.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: onyb · PR authors: onyb, brave-builds

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...8616e885: behind); later builds of the same history include it (brave-core#35466)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...8616e885: behind); later builds of the same history include it (brave-core#35466)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...8616e885: behind); later builds of the same history include it (brave-core#35466)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...8616e885: behind); later builds of the same history include it (brave-core#35466)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...8616e885: behind); later builds of the same history include it (brave-core#35466)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...8616e885: behind); later builds of the same history include it (brave-core#35466)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...8616e885: behind); later builds of the same history include it (brave-core#35466)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...8616e885: behind); later builds of the same history include it (brave-core#35466)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...8616e885: behind); later builds of the same history include it (brave-core#35466)

Members and their history

Issue

brave-browser#53750 [Wallet] Zcash transaction continues to show loading spinner even after transaction is completed

State: closed (completed) · created · closed · updated · discovered via search:zcash · matched title:zcash, body:zcash

bug QA Pass-Win64 QA/Yes release-notes/exclude feature/web3/wallet OS/Desktop

Description Zcash transaction continues to show loading spinner even after transaction is completed Steps to reproduce 1. Submit a Zcash bridge transaction 2. Wait for the transaction confirmation 3. Go to transaction activity in Portfolio 4. Transaction state continues to show the loading spinner 5. Click on the transaction, shows confirmed Actual result [GitHub link omitted] Expected result Should show confirmed icon instead of loading spinner Reproduces how often Easily…

Timeline (10 of 12 events)
  1. 2026-03-18 12:50 Label added release-notes/exclude by srirambv
  2. 2026-03-18 12:50 Label added OS/Desktop by srirambv
  3. 2026-04-13 19:38 Referenced by brave-core#35466 by onyb
  4. 2026-04-14 08:20 Closed completed brave-core#35466 by onyb
  5. 2026-04-14 08:21 Milestone set 1.91.x - Nightly by brave-builds
  6. 2026-04-14 15:30 Label added QA/Yes by onyb
  7. 2026-04-15 06:58 Referenced by brave-core#35530 by brave-builds
  8. 2026-04-17 11:56 Milestone removed 1.91.x - Nightly by brave-builds
  9. 2026-04-17 11:56 Milestone set 1.90.x - Beta by brave-builds
  10. 2026-04-21 11:22 Label added QA Pass-Win64 by srirambv
Pull request

brave-core#35466 [Wallet] Fix bridge spinner and swap "()" in transaction activity

State: merged 2026-04-14 · created · closed · updated · discovered via linked:brave/brave-browser#53750

CI/storybook-url feature/web3/wallet

Use gate3 swap status in the activity list so confirmed bridge transactions no longer show a perpetual loading spinner. Extract getGate3EffectiveStatus into a shared utility for reuse. Guard the swap fiat value parentheses so empty destinationAmount doesn't render literal "()". Resolves https://github.com/brave/brave-browser/issues/53750 Resolves https://github.com/brave/brave-browser/issues/53751

Timeline (5 of 7 events)
  1. 2026-04-14 08:20 Merged master by onyb
  2. 2026-04-14 08:20 Closed by onyb
  3. 2026-04-14 08:20 Milestone set 1.91.x - Nightly by github-actions
  4. 2026-04-15 06:58 Referenced by brave-core#35530 by brave-builds
  5. 2026-04-17 11:56 Referenced by brave-browser#53750 by kjozwiak
Uplift PR → 1.90.x

brave-core#35530 [Wallet] Fix bridge spinner and swap "()" in transaction activity (uplift to 1.90.x)

State: merged 2026-04-17 · created · closed · updated · discovered via mentions:brave/brave-browser#53750

CI/storybook-url feature/web3/wallet

Uplift of #35466 Resolves https://github.com/brave/brave-browser/issues/53750 Resolves https://github.com/brave/brave-browser/issues/53751 Pre-approval checklist: - [x] You have tested your change on Nightly. - [ ] This contains text which needs to be translated. - [ ] There are more than 7 days before the release. - [ ] I've notified folks in #l10n on Slack that translations are needed. - [x] The PR milestones match the branch they are landing to. Pre-merge checklist: -…

Timeline (3 of 5 events)
  1. 2026-04-15 06:58 Milestone set 1.90.x - Beta by brave-builds
  2. 2026-04-17 11:55 Merged 1.90.x by kjozwiak
  3. 2026-04-17 11:55 Closed by kjozwiak

Recorded changes

  1. QA passed

    QA Pass-Win64: [Wallet] Zcash transaction continues to show loading spinner even after transaction is completed

    Brave QA marked this as passed on Win64. Other platforms are not covered by this label.

    brave-browser#53750
    Evidence
    • label "QA Pass-Win64" added at 2026-04-21T11:22:02Z

    Source time: · Detected: · Backfilled from source history

    2026-04-21T11:22:02Z
  2. Uplift merged Fix

    Uplifted to 1.90.x: [Wallet] Fix bridge spinner and swap "()" in transaction activity (uplift to 1.90.x)

    Merged into the 1.90.x branch. It ships when a 1.90.x build is published; see build presence on the item.

    brave-core#35530
    Evidence
    • merged 2026-04-17T11:55:46Z
    • repository brave/brave-core
    • base branch 1.90.x

    Source time: · Detected: · Backfilled from source history

    2026-04-17T11:55:46Z
  3. Issue closed Fix

    Closed (completed): [Wallet] Zcash transaction continues to show loading spinner even after transaction is completed

    Closed as completed; linked PR merged 2026-04-14. Code is in current Release builds for Desktop, Android, iOS.

    brave-browser#53750 brave-core#35466
    Evidence
    • closed by onyb at 2026-04-14T08:20:43Z
    • state reason: completed

    Source time: · Detected: · Backfilled from source history

    2026-04-14T08:20:43Z
  4. PR merged Fix

    Merged: [Wallet] Fix bridge spinner and swap "()" in transaction activity

    Merged into brave-core master on 2026-04-14. Only builds cut from master after this merge (Nightly first) can contain it; whether a published build does is checked per build (see build presence on the item). Beta and Release get it only after a branch cut or an uplift.

    brave-core#35466
    Evidence
    • merged 2026-04-14T08:20:41Z
    • repository brave/brave-core
    • base branch master

    Source time: · Detected: · Backfilled from source history

    2026-04-14T08:20:41Z
  5. New issue

    New bug report: [Wallet] Zcash transaction continues to show loading spinner even after transaction is completed

    Opened in brave-browser#53750. This is a report or request, not a confirmed change to Brave Wallet.

    brave-browser#53750
    Evidence
    • created 2026-03-18T12:50:53Z

    Source time: · Detected: · Backfilled from source history

    2026-03-18T12:50:53Z