Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

[iOS][Wallet] Fetch and use correct zec balance for checking gas token balance in zec tx

In a Release build Issue Transactions & fees

Lead item brave-browser#53740 · opened by nuo-xu · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#34811 merged 2026-03-20 into master by nuo-xu
    [iOS][Wallet] Correctly fetch and check ZEC Tx Gas Token Balance
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Uplifts to release branches

Release notes

No platform changelog lists this item.

Validation

QA required (QA/Yes).

  • QA Pass-iPhone (iOS only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.89.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): iOS

Owner: nuo-xu · PR authors: nuo-xu

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...09e1a46f: behind); later builds of the same history include it (brave-core#34811)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...09e1a46f: behind); later builds of the same history include it (brave-core#34811)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...09e1a46f: behind); later builds of the same history include it (brave-core#34811)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...09e1a46f: behind); later builds of the same history include it (brave-core#34811)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...09e1a46f: behind); later builds of the same history include it (brave-core#34811)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...09e1a46f: behind); later builds of the same history include it (brave-core#34811)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...09e1a46f: behind); later builds of the same history include it (brave-core#34811)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...09e1a46f: behind); later builds of the same history include it (brave-core#34811)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...09e1a46f: behind); later builds of the same history include it (brave-core#34811)

Members and their history

Issue

brave-browser#53740 [iOS][Wallet] Fetch and use correct zec balance for checking gas token balance in zec tx

State: closed (completed) · created · closed · updated · discovered via label:feature/web3/wallet/zcash, search:shielded wallet, search:zec · matched label:feature/web3/wallet/zcash, title:zec, body:zec

QA/Yes release-notes/exclude feature/web3/wallet OS/iOS feature/web3/wallet/zcash QA Pass - iPhone

need to use BraveWalletZcashWalletService to fetch BraveWalletZCashBalance which include both transparent and shielded ZEC balance. For different BraveWalletZcashTxType we need to use different balance to check gas token balance in order to correctly display the insufficient gas token balance error message in Tx Confirmation Screen.

Timeline (11 of 13 events)
  1. 2026-03-17 21:28 Label added QA/Yes by nuo-xu
  2. 2026-03-17 21:28 Label added release-notes/exclude by nuo-xu
  3. 2026-03-17 21:28 Label added OS/iOS by nuo-xu
  4. 2026-03-18 16:29 Referenced by brave-core#34811 by nuo-xu
  5. 2026-03-20 17:04 Closed completed brave-core#34811 by nuo-xu
  6. 2026-03-20 17:04 Milestone set 1.90.x - Nightly by brave-builds
  7. 2026-03-20 17:51 Referenced by brave-core#34873 by nuo-xu
  8. 2026-03-23 17:36 Milestone removed 1.90.x - Nightly by brave-builds
  9. 2026-03-23 17:36 Milestone set 1.89.x - Beta by brave-builds
  10. 2026-04-13 12:23 Label added QA Pass - iPhone by srirambv
  11. 2026-04-13 12:25 Referenced by brave-browser#53868 by srirambv
Pull request

brave-core#34811 [iOS][Wallet] Correctly fetch and check ZEC Tx Gas Token Balance

State: merged 2026-03-20 · created · closed · updated · discovered via search:shielded is:pr, search:zcash is:pr, search:zec is:pr · matched title:zec, body:zcashbalance

CI/skip-android CI/skip-windows-x64 CI/skip-macos-arm64 CI/skip-origin

Resolves https://github.com/brave/brave-browser/issues/53740 BraveWallet.ZcashBalance is fetched from BraveWallet.ZcashWalletService not the rpc service. Since zcash tx gas token is ZEC, and Zcash account has transparent balance and shielded balance, we need to check transparent balance for tx that does not use shielded pool and shielded balance otherwise. Test: prerequisite: 1. enable wallet webui and zcash shielded support 2. has some balance in both shield and…

Timeline (6 of 10 events)
  1. 2026-03-20 17:04 Merged master by nuo-xu
  2. 2026-03-20 17:04 Closed by nuo-xu
  3. 2026-03-20 17:04 Milestone set 1.90.x - Nightly by github-actions
  4. 2026-03-20 17:51 Referenced by brave-core#34873 by nuo-xu
  5. 2026-03-24 02:57 Referenced by brave-browser#53868 by nuo-xu
  6. 2026-04-13 12:23 Referenced by brave-browser#53740 by srirambv
Uplift PR → 1.89.x

brave-core#34873 [iOS][Wallet] Correctly fetch and check ZEC Tx Gas Token Balance (uplift to 1.89.x)

State: merged 2026-03-23 · created · closed · updated · discovered via search:zec is:pr · matched title:zec

CI/skip-android CI/skip-windows-x64 CI/skip-macos-arm64 CI/skip-origin

Uplift of #34811 Resolves https://github.com/brave/brave-browser/issues/53740

Timeline (3 of 7 events)
  1. 2026-03-23 17:33 Milestone set 1.89.x - Beta by kjozwiak
  2. 2026-03-23 17:35 Merged 1.89.x by kjozwiak
  3. 2026-03-23 17:35 Closed by kjozwiak

Also mentioned by (not linked as fixes): brave-browser#53868

Recorded changes

  1. QA passed

    QA Pass - iPhone: [iOS][Wallet] Fetch and use correct zec balance for checking gas token balance in zec tx

    Brave QA marked this as passed on iPhone. Other platforms are not covered by this label.

    brave-browser#53740
    Evidence
    • label "QA Pass - iPhone" added at 2026-04-13T12:23:49Z

    Source time: · Detected: · Backfilled from source history

    2026-04-13T12:23:49Z
  2. Uplift merged

    Uplifted to 1.89.x: [iOS][Wallet] Correctly fetch and check ZEC Tx Gas Token Balance (uplift to 1.89.x)

    Merged into the 1.89.x branch. It ships when a 1.89.x build is published; see build presence on the item.

    brave-core#34873
    Evidence
    • merged 2026-03-23T17:35:48Z
    • repository brave/brave-core
    • base branch 1.89.x

    Source time: · Detected: · Backfilled from source history

    2026-03-23T17:35:48Z
  3. Issue closed

    Closed (completed): [iOS][Wallet] Fetch and use correct zec balance for checking gas token balance in zec tx

    Closed as completed; linked PR merged 2026-03-20. Code is in current Release builds for Desktop, Android, iOS.

    brave-browser#53740 brave-core#34811
    Evidence
    • closed by nuo-xu at 2026-03-20T17:04:23Z
    • state reason: completed

    Source time: · Detected: · Backfilled from source history

    2026-03-20T17:04:23Z
  4. PR merged

    Merged: [iOS][Wallet] Correctly fetch and check ZEC Tx Gas Token Balance

    Merged into brave-core master on 2026-03-20. Only builds cut from master after this merge (Nightly first) can contain it; whether a published build does is checked per build (see build presence on the item). Beta and Release get it only after a branch cut or an uplift.

    brave-core#34811
    Evidence
    • merged 2026-03-20T17:04:21Z
    • repository brave/brave-core
    • base branch master

    Source time: · Detected: · Backfilled from source history

    2026-03-20T17:04:21Z
  5. New issue

    New issue: [iOS][Wallet] Fetch and use correct zec balance for checking gas token balance in zec tx

    Opened in brave-browser#53740. This is a report or request, not a confirmed change to Brave Wallet.

    brave-browser#53740
    Evidence
    • created 2026-03-17T21:28:41Z

    Source time: · Detected: · Backfilled from source history

    2026-03-17T21:28:41Z