Zcash × Brave WalletPersonal project

Type to search. Use ↑ ↓ and Enter to open a result.

[iOS][Wallet] Determine Zcash Tx Type in Tx Confirmation Screen

In a Release build Issue Transactions & fees

Lead item brave-browser#53733 · opened by nuo-xu · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#34794 merged 2026-03-18 into master by nuo-xu
    [iOS][Wallet] Determine zcash tx type and display correct confirm button title
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Uplifts to release branches

Release notes

No platform changelog lists this item.

Validation

QA required (QA/Yes).

  • QA Pass-iPhone (iOS only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.89.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): iOS

Owner: nuo-xu · PR authors: nuo-xu, brave-builds

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...a21bec59: behind); later builds of the same history include it (brave-core#34794)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...a21bec59: behind); later builds of the same history include it (brave-core#34794)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...a21bec59: behind); later builds of the same history include it (brave-core#34794)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...a21bec59: behind); later builds of the same history include it (brave-core#34794)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...a21bec59: behind); later builds of the same history include it (brave-core#34794)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...a21bec59: behind); later builds of the same history include it (brave-core#34794)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...a21bec59: behind); later builds of the same history include it (brave-core#34794)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...a21bec59: behind); later builds of the same history include it (brave-core#34794)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...a21bec59: behind); later builds of the same history include it (brave-core#34794)

Members and their history

Issue

brave-browser#53733 [iOS][Wallet] Determine Zcash Tx Type in Tx Confirmation Screen

State: closed (completed) · created · closed · updated · discovered via label:feature/web3/wallet/zcash, search:zcash, search:zec · matched label:feature/web3/wallet/zcash, title:zcash

QA/Yes release-notes/exclude feature/web3/wallet OS/iOS feature/web3/wallet/zcash QA Pass - iPhone

Current: [image] [image] [image] Expected: [image] [image] [image]

Timeline (10 of 12 events)
  1. 2026-03-17 16:52 Label added QA/Yes by nuo-xu
  2. 2026-03-17 16:52 Label added release-notes/exclude by nuo-xu
  3. 2026-03-17 16:52 Label added OS/iOS by nuo-xu
  4. 2026-03-17 17:13 Referenced by brave-core#34794 by nuo-xu
  5. 2026-03-18 20:42 Closed completed brave-core#34794 by nuo-xu
  6. 2026-03-18 20:42 Milestone set 1.90.x - Nightly by brave-builds
  7. 2026-03-19 16:32 Referenced by brave-core#34835 by brave-builds
  8. 2026-03-23 11:34 Milestone removed 1.90.x - Nightly by brave-builds
  9. 2026-03-23 11:34 Milestone set 1.89.x - Beta by brave-builds
  10. 2026-04-14 12:47 Label added QA Pass - iPhone by srirambv
Pull request

brave-core#34794 [iOS][Wallet] Determine zcash tx type and display correct confirm button title

State: merged 2026-03-18 · created · closed · updated · discovered via search:shielded is:pr, search:zcash is:pr, search:zec is:pr · matched title:zcash, body:zcash

CI/skip-android CI/skip-windows-x64 CI/skip-macos-arm64 CI/skip-origin

Resolves https://github.com/brave/brave-browser/issues/53733 Test: 1. Enable Zcash shielded and wallet webui feature flags 2. open wallet 3. make one shielded zec tx and one unshielded zec tx 4. verify the "confirm" button display with correct title (Shield ZEC for shield tx and Unshield ZEC for unshield tx) [image] [image] [image]

Timeline (4 of 8 events)
  1. 2026-03-18 20:42 Merged master by nuo-xu
  2. 2026-03-18 20:42 Closed by nuo-xu
  3. 2026-03-18 20:42 Milestone set 1.90.x - Nightly by github-actions
  4. 2026-03-19 16:32 Referenced by brave-core#34835 by brave-builds
Uplift PR → 1.89.x

brave-core#34835 [iOS][Wallet] Determine zcash tx type and display correct confirm button title (uplift to 1.89.x)

State: merged 2026-03-23 · created · closed · updated · discovered via search:zcash is:pr · matched title:zcash

CI/skip-android CI/skip-windows-x64 CI/skip-macos-arm64 CI/skip-origin

Uplift of #34794 Resolves https://github.com/brave/brave-browser/issues/53733 Pre-approval checklist: - [x] You have tested your change on Nightly. - [ ] This contains text which needs to be translated. - [ ] There are more than 7 days before the release. - [ ] I've notified folks in #l10n on Slack that translations are needed. - [x] The PR milestones match the branch they are landing to. Pre-merge checklist: - [x] You have checked CI and the builds, lint, and tests all…

Timeline (3 of 7 events)
  1. 2026-03-19 16:32 Milestone set 1.89.x - Beta by brave-builds
  2. 2026-03-23 11:34 Merged 1.89.x by kjozwiak
  3. 2026-03-23 11:34 Closed by kjozwiak

Recorded changes

  1. QA passed

    QA Pass - iPhone: [iOS][Wallet] Determine Zcash Tx Type in Tx Confirmation Screen

    Brave QA marked this as passed on iPhone. Other platforms are not covered by this label.

    brave-browser#53733
    Evidence
    • label "QA Pass - iPhone" added at 2026-04-14T12:47:48Z

    Source time: · Detected: · Backfilled from source history

    2026-04-14T12:47:48Z
  2. Uplift merged

    Uplifted to 1.89.x: [iOS][Wallet] Determine zcash tx type and display correct confirm button title (uplift to 1.89.x)

    Merged into the 1.89.x branch. It ships when a 1.89.x build is published; see build presence on the item.

    brave-core#34835
    Evidence
    • merged 2026-03-23T11:34:18Z
    • repository brave/brave-core
    • base branch 1.89.x

    Source time: · Detected: · Backfilled from source history

    2026-03-23T11:34:18Z
  3. Issue closed

    Closed (completed): [iOS][Wallet] Determine Zcash Tx Type in Tx Confirmation Screen

    Closed as completed; linked PR merged 2026-03-18. Code is in current Release builds for Desktop, Android, iOS.

    brave-browser#53733 brave-core#34794
    Evidence
    • closed by nuo-xu at 2026-03-18T20:42:18Z
    • state reason: completed

    Source time: · Detected: · Backfilled from source history

    2026-03-18T20:42:18Z
  4. PR merged

    Merged: [iOS][Wallet] Determine zcash tx type and display correct confirm button title

    Merged into brave-core master on 2026-03-18. Only builds cut from master after this merge (Nightly first) can contain it; whether a published build does is checked per build (see build presence on the item). Beta and Release get it only after a branch cut or an uplift.

    brave-core#34794
    Evidence
    • merged 2026-03-18T20:42:16Z
    • repository brave/brave-core
    • base branch master

    Source time: · Detected: · Backfilled from source history

    2026-03-18T20:42:16Z
  5. New issue

    New issue: [iOS][Wallet] Determine Zcash Tx Type in Tx Confirmation Screen

    Opened in brave-browser#53733. This is a report or request, not a confirmed change to Brave Wallet.

    brave-browser#53733
    Evidence
    • created 2026-03-17T16:52:11Z

    Source time: · Detected: · Backfilled from source history

    2026-03-17T16:52:11Z