Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Refactor ZCash tests

In a Release build Issue Testnet, tests & tooling

Lead item brave-browser#53026 · opened by supermassive · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#33971 merged 2026-03-04 into master by supermassive
    Refactor SyncState for zcash tests
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

No platform changelog lists this item.

Validation

Not QA-tested (QA/No).

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.89.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: supermassive · PR authors: supermassive

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...297eb1c5: behind); later builds of the same history include it (brave-core#33971)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...297eb1c5: behind); later builds of the same history include it (brave-core#33971)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...297eb1c5: behind); later builds of the same history include it (brave-core#33971)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...297eb1c5: behind); later builds of the same history include it (brave-core#33971)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...297eb1c5: behind); later builds of the same history include it (brave-core#33971)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...297eb1c5: behind); later builds of the same history include it (brave-core#33971)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...297eb1c5: behind); later builds of the same history include it (brave-core#33971)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...297eb1c5: behind); later builds of the same history include it (brave-core#33971)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...297eb1c5: behind); later builds of the same history include it (brave-core#33971)

Members and their history

Issue

brave-browser#53026 Refactor ZCash tests

State: closed (completed) · created · closed · updated · discovered via search:zcash · matched title:zcash, body:zcash

QA/No dev-concern release-notes/exclude feature/web3/wallet OS/Desktop feature/web3/wallet/core

Refactor ZCash tests to avoid lsan flaks.

Timeline (6 of 9 events)
  1. 2026-02-20 16:42 Referenced by brave-core#33971 by supermassive
  2. 2026-03-04 05:54 Closed completed brave-core#33971 by supermassive
  3. 2026-03-04 05:55 Milestone set 1.89.x - Nightly by brave-builds
  4. 2026-03-09 10:34 Label added QA/No by supermassive
  5. 2026-03-09 10:34 Label added release-notes/exclude by supermassive
  6. 2026-03-09 10:34 Label added OS/Desktop by supermassive
Pull request

brave-core#33971 Refactor SyncState for zcash tests

State: merged 2026-03-04 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:orchard is:pr, search:zcash is:pr · matched title:zcash

feature/web3/wallet feature/web3/wallet/core puLL-Merge

Resolves https://github.com/brave/brave-browser/issues/53026 - Remove duplicated instance of rpc, sync_state, etc in tests. - Properly wait for sync_state to finish in tests.

Timeline (4 of 11 events)
  1. 2026-02-19 10:39 Referenced by brave-browser#52985 by supermassive
  2. 2026-03-04 05:54 Merged master by supermassive
  3. 2026-03-04 05:54 Closed by supermassive
  4. 2026-03-04 05:55 Milestone set 1.89.x - Nightly by github-actions

Recorded changes

  1. Issue closed

    Closed (completed): Refactor ZCash tests

    Closed as completed; linked PR merged 2026-03-04. Code is in current Release builds for Desktop, Android, iOS.

    brave-browser#53026 brave-core#33971
    Evidence
    • closed by supermassive at 2026-03-04T05:54:59Z
    • state reason: completed

    Source time: · Detected: · Backfilled from source history

    2026-03-04T05:54:59Z
  2. PR merged

    Merged: Refactor SyncState for zcash tests

    Merged into brave-core master on 2026-03-04. Only builds cut from master after this merge (Nightly first) can contain it; whether a published build does is checked per build (see build presence on the item). Beta and Release get it only after a branch cut or an uplift.

    brave-core#33971
    Evidence
    • merged 2026-03-04T05:54:57Z
    • repository brave/brave-core
    • base branch master

    Source time: · Detected: · Backfilled from source history

    2026-03-04T05:54:57Z
  3. New issue

    New issue: Refactor ZCash tests

    Opened in brave-browser#53026. This is a report or request, not a confirmed change to Brave Wallet.

    brave-browser#53026
    Evidence
    • created 2026-02-20T16:40:26Z

    Source time: · Detected: · Backfilled from source history

    2026-02-20T16:40:26Z