Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Check against OFAC sanctioned addresses list when adding a new Brave Wallet account

In a Release build Issue Addresses, accounts & memos

Lead item brave-browser#52043 · opened by jamesmudgett · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#33537 merged 2026-03-10 into master by cmazakas
    [Wallet] add ofac checking for account-based coins
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

No platform changelog lists this item.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.90.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: cmazakas, cypt4 · PR authors: cmazakas

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...2a18724d: behind); later builds of the same history include it (brave-core#33537)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...2a18724d: behind); later builds of the same history include it (brave-core#33537)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...2a18724d: behind); later builds of the same history include it (brave-core#33537)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...2a18724d: behind); later builds of the same history include it (brave-core#33537)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...2a18724d: behind); later builds of the same history include it (brave-core#33537)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...2a18724d: behind); later builds of the same history include it (brave-core#33537)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...2a18724d: behind); later builds of the same history include it (brave-core#33537)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...2a18724d: behind); later builds of the same history include it (brave-core#33537)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...2a18724d: behind); later builds of the same history include it (brave-core#33537)

Members and their history

Issue

brave-browser#52043 Check against OFAC sanctioned addresses list when adding a new Brave Wallet account

State: closed (completed) · created · closed · updated · discovered via linked:brave/brave-core#33537

QA Pass-Win64 priority/P2 QA/Yes release-notes/exclude feature/web3/wallet OS/Desktop feature/web3/wallet/core

Description In order to meet compliance we should check and fail anytime a wallet address is created/imported that matches a sanctioned wallet address Steps to reproduce Create, import wallet Actual result Should fail if a positive match is made Expected result Should fail to create an account if a wallet address matches a sanctioned address Reproduces how often Easily reproduced Brave version (brave://version info) All Channel information - [x] release (stable) - [x] beta…

Timeline (9 of 11 events)
  1. 2026-01-16 15:21 Label added OS/Desktop by jamesmudgett
  2. 2026-01-22 16:00 Label added priority/P2 by Douglashdaniel
  3. 2026-01-29 11:38 Referenced by brave-core#33496 by cypt4
  4. 2026-01-30 22:58 Referenced by brave-core#33537 by cmazakas
  5. 2026-03-10 18:04 Closed completed brave-core#33537 by cmazakas
  6. 2026-03-10 18:05 Milestone set 1.90.x - Nightly by brave-builds
  7. 2026-03-11 14:29 Label added QA/Yes by cmazakas
  8. 2026-03-11 14:29 Label added release-notes/exclude by cmazakas
  9. 2026-04-22 12:07 Label added QA Pass-Win64 by srirambv
Pull request

brave-core#33537 [Wallet] add ofac checking for account-based coins

State: merged 2026-03-10 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:orchard is:pr, search:zcash is:pr

release-notes/exclude feature/wallet CI/storybook-url feature/web3/wallet feature/web3/wallet/core puLL-Merge

Resolves https://github.com/brave/brave-browser/issues/52043 Follow-up PRs: https://github.com/brave/brave-core/pull/34991 Update the KeyringService each individual account-based keyring to use the OFAC blacklist when attempting to create and import accounts. We introduce the :blockchain_utils build target so that gn check passes as now all the keyrings requires visibility of the blockchain_registry.h header file in order to compare against the blacklist. We also remove a…

Timeline (7 of 14 events)
  1. 2026-01-30 22:58 Label added release-notes/exclude by cmazakas
  2. 2026-01-30 22:58 Label added QA/No by cmazakas
  3. 2026-03-10 18:04 Merged master by cmazakas
  4. 2026-03-10 18:04 Closed by cmazakas
  5. 2026-03-10 18:05 Milestone set 1.90.x - Nightly by github-actions
  6. 2026-03-11 14:32 Label removed QA/No by cmazakas
  7. 2026-04-22 12:07 Referenced by brave-browser#52043 by srirambv

Recorded changes

  1. QA passed

    QA Pass-Win64: Check against OFAC sanctioned addresses list when adding a new Brave Wallet account

    Brave QA marked this as passed on Win64. Other platforms are not covered by this label.

    brave-browser#52043
    Evidence
    • label "QA Pass-Win64" added at 2026-04-22T12:07:17Z

    Source time: · Detected: · Backfilled from source history

    2026-04-22T12:07:17Z
  2. Issue closed

    Closed (completed): Check against OFAC sanctioned addresses list when adding a new Brave Wallet account

    Closed as completed; linked PR merged 2026-03-10. Code is in current Release builds for Desktop, Android, iOS.

    brave-browser#52043 brave-core#33537
    Evidence
    • closed by cmazakas at 2026-03-10T18:04:58Z
    • state reason: completed

    Source time: · Detected: · Backfilled from source history

    2026-03-10T18:04:58Z
  3. PR merged

    Merged: [Wallet] add ofac checking for account-based coins

    Merged into brave-core master on 2026-03-10. Only builds cut from master after this merge (Nightly first) can contain it; whether a published build does is checked per build (see build presence on the item). Beta and Release get it only after a branch cut or an uplift.

    brave-core#33537
    Evidence
    • merged 2026-03-10T18:04:56Z
    • repository brave/brave-core
    • base branch master

    Source time: · Detected: · Backfilled from source history

    2026-03-10T18:04:56Z
  4. New issue

    New issue: Check against OFAC sanctioned addresses list when adding a new Brave Wallet account

    Opened in brave-browser#52043. This is a report or request, not a confirmed change to Brave Wallet.

    brave-browser#52043
    Evidence
    • created 2026-01-16T15:21:30Z

    Source time: · Detected: · Backfilled from source history

    2026-01-16T15:21:30Z