Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

[SafeSign] Replace SwapInfoDeprecated with SwapInfo across transaction metadata

In a Release build Issue Transactions & fees

Lead item brave-browser#51978 · opened by onyb · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#33213 merged 2026-01-19 into master by onyb
    [SafeSign] Replace SwapInfoDeprecated with SwapInfo across transaction metadata
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

No platform changelog lists this item.

Validation

Not QA-tested (QA/No).

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.88.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: onyb · PR authors: onyb

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...9e0527d3: behind); later builds of the same history include it (brave-core#33213)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...9e0527d3: behind); later builds of the same history include it (brave-core#33213)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...9e0527d3: behind); later builds of the same history include it (brave-core#33213)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...9e0527d3: behind); later builds of the same history include it (brave-core#33213)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...9e0527d3: behind); later builds of the same history include it (brave-core#33213)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...9e0527d3: behind); later builds of the same history include it (brave-core#33213)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...9e0527d3: behind); later builds of the same history include it (brave-core#33213)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...9e0527d3: behind); later builds of the same history include it (brave-core#33213)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...9e0527d3: behind); later builds of the same history include it (brave-core#33213)

Members and their history

Issue

brave-browser#51978 [SafeSign] Replace SwapInfoDeprecated with SwapInfo across transaction metadata

State: closed (completed) · created · closed · updated · discovered via linked:brave/brave-core#33213

QA/No release-notes/exclude feature/web3/wallet OS/Desktop feature/web3/wallet/core feature/web3/wallet/swap

Add swap_info field to TransactionInfo via the corresponding TxMeta classes.

Timeline (6 of 9 events)
  1. 2026-01-14 16:47 Label added QA/No by onyb
  2. 2026-01-14 16:47 Label added release-notes/exclude by onyb
  3. 2026-01-14 16:47 Label added OS/Desktop by onyb
  4. 2026-01-14 16:47 Referenced by brave-core#33213 by onyb
  5. 2026-01-19 07:38 Closed completed brave-core#33213 by onyb
  6. 2026-01-19 07:38 Milestone set 1.88.x - Nightly by brave-builds
Pull request

brave-core#33213 [SafeSign] Replace SwapInfoDeprecated with SwapInfo across transaction metadata

State: merged 2026-01-19 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:zcash is:pr

CI/storybook-url feature/web3/wallet feature/web3/wallet/core puLL-Merge

This PR disables legacy SafeSign through the Transaction.swap_info_deprecated and exposes it via Transaction.swap_info. Client-side integration will be included in a subsequent PR. Resolves https://github.com/brave/brave-browser/issues/51978

Timeline (5 of 9 events)
  1. 2026-01-14 19:30 Referenced by brave-core#33191 by onyb
  2. 2026-01-15 08:01 Referenced by brave-core#33156 by onyb
  3. 2026-01-19 07:38 Merged master by onyb
  4. 2026-01-19 07:38 Closed by onyb
  5. 2026-01-19 07:38 Milestone set 1.88.x - Nightly by github-actions

Recorded changes

  1. Issue closed

    Closed (completed): [SafeSign] Replace SwapInfoDeprecated with SwapInfo across transaction metadata

    Closed as completed; linked PR merged 2026-01-19. Code is in current Release builds for Desktop, Android, iOS.

    brave-browser#51978 brave-core#33213
    Evidence
    • closed by onyb at 2026-01-19T07:38:25Z
    • state reason: completed

    Source time: · Detected: · Backfilled from source history

    2026-01-19T07:38:25Z
  2. PR merged

    Merged: [SafeSign] Replace SwapInfoDeprecated with SwapInfo across transaction metadata

    Merged into brave-core master on 2026-01-19. Only builds cut from master after this merge (Nightly first) can contain it; whether a published build does is checked per build (see build presence on the item). Beta and Release get it only after a branch cut or an uplift.

    brave-core#33213
    Evidence
    • merged 2026-01-19T07:38:24Z
    • repository brave/brave-core
    • base branch master

    Source time: · Detected: · Backfilled from source history

    2026-01-19T07:38:24Z
  3. New issue

    New issue: [SafeSign] Replace SwapInfoDeprecated with SwapInfo across transaction metadata

    Opened in brave-browser#51978. This is a report or request, not a confirmed change to Brave Wallet.

    brave-browser#51978
    Evidence
    • created 2026-01-14T16:47:07Z

    Source time: · Detected: · Backfilled from source history

    2026-01-14T16:47:07Z