Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

[ZCash] Customize unshielding messages for s->t transactions

In a Release build Task Shielded (Orchard) support

Lead item brave-browser#51179 · opened by cypt4 · last source update

This issue is open on GitHub. Fixes sometimes land through pull requests that do not link the issue (for example a later refactor); this tracker follows only explicit links (closing references, “Resolves” lines, brave_<issue> branch names, uplifts and the issue timeline).

Issue state

Open

Open. GitHub type: Task.

Implementation

  • brave-core#32640 merged 2025-12-24 into master by cypt4
    [ZCash] Customize messages for s->t transactions
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description, branch name brave_51179 (weaker evidence; titles share a keyword)

Release notes

No platform changelog lists this item.

Validation

QA required (QA/Yes).

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

No milestone set.

Platforms (OS labels): Desktop

Owner: cypt4 · PR authors: cypt4

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...946a6993: behind); later builds of the same history include it (brave-core#32640)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...946a6993: behind); later builds of the same history include it (brave-core#32640)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...946a6993: behind); later builds of the same history include it (brave-core#32640)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...946a6993: behind); later builds of the same history include it (brave-core#32640)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...946a6993: behind); later builds of the same history include it (brave-core#32640)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...946a6993: behind); later builds of the same history include it (brave-core#32640)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...946a6993: behind); later builds of the same history include it (brave-core#32640)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...946a6993: behind); later builds of the same history include it (brave-core#32640)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...946a6993: behind); later builds of the same history include it (brave-core#32640)

Members and their history

Issue

brave-browser#51179 [ZCash] Customize unshielding messages for s->t transactions

State: open · created · updated · discovered via label:feature/web3/wallet/zcash, search:zcash · matched label:feature/web3/wallet/zcash, title:zcash, title:unshielding, body:unshielding

QA/Yes release-notes/exclude OS/Desktop feature/web3/wallet/zcash

Description This is a part of s->t transactions support. Like we already have for t->s transactions we should customize s->t transaction buttons and messages to use "unshielding" instead of send when sending to internal accounts. Steps to reproduce - Actual result - Expected result - Reproduces how often Easily reproduced Brave version (brave://version info) - Channel information - [ ] release (stable) - [ ] beta - [ ] nightly Reproducibility - [ ] with Brave Shields…

Timeline (6 of 7 events)
  1. 2025-12-02 13:38 Label added OS/Desktop by cypt4
  2. 2025-12-02 13:38 Label added QA/No by cypt4
  3. 2025-12-02 13:38 Label added release-notes/exclude by cypt4
  4. 2025-12-24 19:13 Referenced by brave-core#32640 by cypt4
  5. 2025-12-24 19:14 Label removed QA/No by cypt4
  6. 2025-12-24 19:14 Label added QA/Yes by cypt4
Pull request

brave-core#32640 [ZCash] Customize messages for s->t transactions

State: merged 2025-12-24 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:shielded is:pr, search:zcash is:pr · matched title:zcash, body:shielded

CI/storybook-url feature/web3/wallet feature/web3/wallet/core

This PR adds new messages for s->t transactions when send funds from shielded account to wallet's transparent account. Similar messages we have for t->s transactions. Resolves https://github.com/brave/brave-browser/issues/51179 Testplan: Verify messages for unshielding operations: [image] [image] [image]

Timeline (4 of 9 events)
  1. 2025-12-15 12:47 Referenced by brave-core#32580 by cypt4
  2. 2025-12-24 19:12 Merged master by cypt4
  3. 2025-12-24 19:12 Closed by cypt4
  4. 2025-12-24 19:13 Milestone set 1.87.x - Nightly by github-actions

Recorded changes

  1. PR merged

    Merged: [ZCash] Customize messages for s->t transactions

    Merged into brave-core master on 2025-12-24. Only builds cut from master after this merge (Nightly first) can contain it; whether a published build does is checked per build (see build presence on the item). Beta and Release get it only after a branch cut or an uplift.

    brave-core#32640
    Evidence
    • merged 2025-12-24T19:12:55Z
    • repository brave/brave-core
    • base branch master

    Source time: · Detected: · Backfilled from source history

    2025-12-24T19:12:55Z
  2. New issue

    New issue: [ZCash] Customize unshielding messages for s->t transactions

    Opened in brave-browser#51179. This is a report or request, not a confirmed change to Brave Wallet.

    brave-browser#51179
    Evidence
    • created 2025-12-02T13:38:11Z

    Source time: · Detected: · Backfilled from source history

    2025-12-02T13:38:11Z