Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Replace std::unique_ptr<std::string> with std::optional<std::string> in SimpleURLLoader::DownloadToString* callbacks

In a Release build Task General Zcash support

Lead item brave-browser#51098 · opened by tmancey · last source update

Issue state

Closed (completed)

Closed . GitHub type: Task.

Implementation

  • brave-core#32658 merged 2025-12-12 into master by tmancey
    [CodeHealth] Replace std::unique_ptr<std::string> with std::optional<std::string> in SimpleURLLoader::DownloadToString* callbacks
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

No platform changelog lists this item.

Validation

Not QA-tested (QA/No).

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.87.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop, iOS

Owner: tmancey · PR authors: tmancey

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...8e588d25: behind); later builds of the same history include it (brave-core#32658)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...8e588d25: behind); later builds of the same history include it (brave-core#32658)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...8e588d25: behind); later builds of the same history include it (brave-core#32658)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...8e588d25: behind); later builds of the same history include it (brave-core#32658)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...8e588d25: behind); later builds of the same history include it (brave-core#32658)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...8e588d25: behind); later builds of the same history include it (brave-core#32658)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...8e588d25: behind); later builds of the same history include it (brave-core#32658)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...8e588d25: behind); later builds of the same history include it (brave-core#32658)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...8e588d25: behind); later builds of the same history include it (brave-core#32658)

Members and their history

Issue

brave-browser#51098 Replace std::unique_ptr<std::string> with std::optional<std::string> in SimpleURLLoader::DownloadToString* callbacks

State: closed (completed) · created · closed · updated · discovered via linked:brave/brave-core#32658

QA/No release-notes/exclude feature/web3/wallet OS/Desktop OS/iOS feature/web3/wallet/core code-health

SimpleURLLoader still includes the BodyAsStringCallbackDeprecated callback that uses std::unique_ptr to represent an optional response body. This approach forces every caller to deal with dynamic allocation even though the pointer is only used as a nullable indicator. A newer BodyAsStringCallback already exists using std::optional , which is a clearer and more appropriate way without heap allocation.

Timeline (7 of 10 events)
  1. 2025-12-03 15:03 Referenced by brave-core#32658 by tmancey
  2. 2025-12-12 13:46 Closed completed brave-core#32658 by tmancey
  3. 2025-12-12 13:47 Milestone set 1.87.x - Nightly by brave-builds
  4. 2025-12-15 16:26 Label added QA/No by tmancey
  5. 2025-12-15 16:26 Label added release-notes/exclude by tmancey
  6. 2025-12-15 16:26 Label added OS/Desktop by tmancey
  7. 2025-12-15 16:27 Label added OS/iOS by tmancey
Pull request

brave-core#32658 [CodeHealth] Replace std::unique_ptr<std::string> with std::optional<std::string> in SimpleURLLoader::DownloadToString* callbacks

State: merged 2025-12-12 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:zcash is:pr

feature/web3/wallet feature/web3/wallet/core

SimpleURLLoader still includes the BodyAsStringCallbackDeprecated callback that uses std::unique_ptr to represent an optional response body. This approach forces every caller to deal with dynamic allocation even though the pointer is only used as a nullable indicator. A newer BodyAsStringCallback already exists using std::optional , which is a clearer and more appropriate way without heap allocation. Resolves https://github.com/brave/brave-browser/issues/51098

Timeline (4 of 6 events)
  1. 2025-12-04 15:28 Ready for review by tmancey
  2. 2025-12-12 13:46 Merged master by tmancey
  3. 2025-12-12 13:46 Closed by tmancey
  4. 2025-12-12 13:46 Milestone set 1.87.x - Nightly by github-actions

Recorded changes

  1. Issue closed

    Closed (completed): Replace std::unique_ptr<std::string> with std::optional<std::string> in SimpleURLLoader::DownloadToString* callbacks

    Closed as completed; linked PR merged 2025-12-12. Code is in current Release builds for Desktop, Android, iOS.

    brave-browser#51098 brave-core#32658
    Evidence
    • closed by tmancey at 2025-12-12T13:46:41Z
    • state reason: completed

    Source time: · Detected: · Backfilled from source history

    2025-12-12T13:46:41Z
  2. PR merged

    Merged: [CodeHealth] Replace std::unique_ptr<std::string> with std::optional<std::string> in SimpleURLLoader::DownloadToString* callbacks

    Merged into brave-core master on 2025-12-12. Only builds cut from master after this merge (Nightly first) can contain it; whether a published build does is checked per build (see build presence on the item). Beta and Release get it only after a branch cut or an uplift.

    brave-core#32658
    Evidence
    • merged 2025-12-12T13:46:40Z
    • repository brave/brave-core
    • base branch master

    Source time: · Detected: · Backfilled from source history

    2025-12-12T13:46:40Z
  3. New issue

    New issue: Replace std::unique_ptr<std::string> with std::optional<std::string> in SimpleURLLoader::DownloadToString* callbacks

    Opened in brave-browser#51098. This is a report or request, not a confirmed change to Brave Wallet.

    brave-browser#51098
    Evidence
    • created 2025-11-26T13:29:28Z

    Source time: · Detected: · Backfilled from source history

    2025-11-26T13:29:28Z