Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

[ZCash] ZCashSerializer improvements for s->t tansactions

In a Release build Task Transactions & fees

Lead item brave-browser#50786 · opened by cypt4 · last source update

Issue state

Closed (completed)

Closed . GitHub type: Task.

Implementation

  • brave-core#32274 merged 2025-11-25 into master by cypt4
    [ZCash] ZCashSerializer improvements to support s->t transactions
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description, branch name brave_50786 (weaker evidence; titles share a keyword)

Release notes

No platform changelog lists this item.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.87.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: cypt4 · PR authors: cypt4

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...18f1a5cd: behind); later builds of the same history include it (brave-core#32274)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...18f1a5cd: behind); later builds of the same history include it (brave-core#32274)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...18f1a5cd: behind); later builds of the same history include it (brave-core#32274)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...18f1a5cd: behind); later builds of the same history include it (brave-core#32274)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...18f1a5cd: behind); later builds of the same history include it (brave-core#32274)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...18f1a5cd: behind); later builds of the same history include it (brave-core#32274)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...18f1a5cd: behind); later builds of the same history include it (brave-core#32274)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...18f1a5cd: behind); later builds of the same history include it (brave-core#32274)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...18f1a5cd: behind); later builds of the same history include it (brave-core#32274)

Members and their history

Issue

brave-browser#50786 [ZCash] ZCashSerializer improvements for s->t tansactions

State: closed (completed) · created · closed · updated · discovered via label:feature/web3/wallet/zcash, search:zcash · matched label:feature/web3/wallet/zcash, title:zcash, body:zcashserializer

QA Pass-Win64 QA/Yes release-notes/exclude feature/web3/wallet OS/Desktop feature/web3/wallet/core feature/web3/wallet/zcash

Description This is a part of s->t transactions support. ZCashSerializer signature methods don't handle s->t cases properly. We need to update tx id digest and sighash digest according https://zips.z.cash/zip-0244#signature-digest. Steps to reproduce - Actual result - Expected result - Reproduces how often Easily reproduced Brave version (brave://version info) - Channel information - [ ] release (stable) - [ ] beta - [ ] nightly Reproducibility - [ ] with Brave Shields…

Timeline (7 of 10 events)
  1. 2025-11-12 11:16 Label added OS/Desktop by cypt4
  2. 2025-11-12 11:56 Referenced by brave-core#32274 by cypt4
  3. 2025-11-25 13:07 Closed completed brave-core#32274 by cypt4
  4. 2025-11-25 13:07 Milestone set 1.87.x - Nightly by brave-builds
  5. 2025-11-25 16:47 Label added QA/Yes by cypt4
  6. 2025-11-25 16:47 Label added release-notes/exclude by cypt4
  7. 2026-01-14 10:46 Label added QA Pass-Win64 by srirambv
Pull request

brave-core#32274 [ZCash] ZCashSerializer improvements to support s->t transactions

State: merged 2025-11-25 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:orchard is:pr, search:zcash is:pr · matched title:zcash, body:zcash

feature/web3/wallet feature/web3/wallet/core puLL-Merge

Resolves https://github.com/brave/brave-browser/issues/50786 This PR brings missing coverage for ZCash transaction signatures of s->t type described in https://zips.z.cash/zip-0244#signature-digest. In CalculateTxIdDigest method transparent part was considered as empty if there are not transparent inputs or transparent outputs but actually this is true when there are no inputs and outputs. For the CalculateSignatureDigest method transparent part of sigdigest now has 2…

Timeline (5 of 10 events)
  1. 2025-11-25 13:07 Merged master by cypt4
  2. 2025-11-25 13:07 Closed by cypt4
  3. 2025-11-25 13:07 Milestone set 1.87.x - Nightly by github-actions
  4. 2025-11-25 15:45 Referenced by brave-core#32528 by cypt4
  5. 2026-01-14 10:46 Referenced by brave-browser#50786 by srirambv

Recorded changes

  1. QA passed

    QA Pass-Win64: [ZCash] ZCashSerializer improvements for s->t tansactions

    Brave QA marked this as passed on Win64. Other platforms are not covered by this label.

    brave-browser#50786
    Evidence
    • label "QA Pass-Win64" added at 2026-01-14T10:46:48Z

    Source time: · Detected: · Backfilled from source history

    2026-01-14T10:46:48Z
  2. Issue closed

    Closed (completed): [ZCash] ZCashSerializer improvements for s->t tansactions

    Closed as completed; linked PR merged 2025-11-25. Code is in current Release builds for Desktop, Android, iOS.

    brave-browser#50786 brave-core#32274
    Evidence
    • closed by cypt4 at 2025-11-25T13:07:28Z
    • state reason: completed

    Source time: · Detected: · Backfilled from source history

    2025-11-25T13:07:28Z
  3. PR merged

    Merged: [ZCash] ZCashSerializer improvements to support s->t transactions

    Merged into brave-core master on 2025-11-25. Only builds cut from master after this merge (Nightly first) can contain it; whether a published build does is checked per build (see build presence on the item). Beta and Release get it only after a branch cut or an uplift.

    brave-core#32274
    Evidence
    • merged 2025-11-25T13:07:27Z
    • repository brave/brave-core
    • base branch master

    Source time: · Detected: · Backfilled from source history

    2025-11-25T13:07:27Z
  4. New issue

    New issue: [ZCash] ZCashSerializer improvements for s->t tansactions

    Opened in brave-browser#50786. This is a report or request, not a confirmed change to Brave Wallet.

    brave-browser#50786
    Evidence
    • created 2025-11-12T11:16:22Z

    Source time: · Detected: · Backfilled from source history

    2025-11-12T11:16:22Z