Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

[ZCash] Refactor tx fee calculation

In a Release build Issue Transactions & fees

Lead item brave-browser#50537 · opened by cypt4 · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#32090 merged 2025-11-13 into master by cypt4
    [ZCash] Refactor zcash fee calculation
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description, branch name brave_50537 (weaker evidence; titles share a keyword)

Release notes

No platform changelog lists this item.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.86.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: cypt4 · PR authors: cypt4

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...b79f8ac9: behind); later builds of the same history include it (brave-core#32090)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...b79f8ac9: behind); later builds of the same history include it (brave-core#32090)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...b79f8ac9: behind); later builds of the same history include it (brave-core#32090)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...b79f8ac9: behind); later builds of the same history include it (brave-core#32090)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...b79f8ac9: behind); later builds of the same history include it (brave-core#32090)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...b79f8ac9: behind); later builds of the same history include it (brave-core#32090)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...b79f8ac9: behind); later builds of the same history include it (brave-core#32090)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...b79f8ac9: behind); later builds of the same history include it (brave-core#32090)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...b79f8ac9: behind); later builds of the same history include it (brave-core#32090)

Members and their history

Issue

brave-browser#50537 [ZCash] Refactor tx fee calculation

State: closed (completed) · created · closed · updated · discovered via label:feature/web3/wallet/zcash, search:zcash · matched label:feature/web3/wallet/zcash, title:zcash

QA Pass-Win64 QA/Yes release-notes/exclude feature/web3/wallet OS/Desktop feature/web3/wallet/core feature/web3/wallet/zcash

Description This is a part of s->t support. Fee calculation needs to be refactored to properly calculate fee in the s->t case. Steps to reproduce - Actual result - Expected result - Reproduces how often Easily reproduced Brave version (brave://version info) - Channel information - [ ] release (stable) - [ ] beta - [ ] nightly Reproducibility - [ ] with Brave Shields disabled - [ ] with Brave Rewards disabled - [ ] in the latest version of Chrome Miscellaneous information…

Timeline (7 of 10 events)
  1. 2025-10-29 11:32 Label added OS/Desktop by cypt4
  2. 2025-10-29 14:43 Referenced by brave-core#32090 by cypt4
  3. 2025-11-13 08:22 Closed completed brave-core#32090 by cypt4
  4. 2025-11-13 08:22 Milestone set 1.86.x - Nightly by brave-builds
  5. 2025-11-14 10:26 Label added QA/Yes by cypt4
  6. 2025-11-14 10:26 Label added release-notes/exclude by cypt4
  7. 2026-01-06 10:31 Label added QA Pass-Win64 by srirambv
Pull request

brave-core#32090 [ZCash] Refactor zcash fee calculation

State: merged 2025-11-13 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:orchard is:pr, search:shielded is:pr, search:zcash is:pr · matched title:zcash, body:orchard

feature/web3/wallet feature/web3/wallet/core puLL-Merge

Resolves https://github.com/brave/brave-browser/issues/50537 Testplan: Test t->t, s->t, s->s transaction to adequate fee. It should be max(2, max (transparent inputs count, transparent outputs count) + max(2, 0, orchard outputs) ) 5000. Inputs\outputs could be taken from the tx details page.

Timeline (4 of 7 events)
  1. 2025-10-30 07:59 Ready for review by cypt4
  2. 2025-11-13 08:22 Merged master by cypt4
  3. 2025-11-13 08:22 Closed by cypt4
  4. 2025-11-13 08:22 Milestone set 1.86.x - Nightly by github-actions

Recorded changes

  1. QA passed

    QA Pass-Win64: [ZCash] Refactor tx fee calculation

    Brave QA marked this as passed on Win64. Other platforms are not covered by this label.

    brave-browser#50537
    Evidence
    • label "QA Pass-Win64" added at 2026-01-06T10:31:51Z

    Source time: · Detected: · Backfilled from source history

    2026-01-06T10:31:51Z
  2. Issue closed

    Closed (completed): [ZCash] Refactor tx fee calculation

    Closed as completed; linked PR merged 2025-11-13. Code is in current Release builds for Desktop, Android, iOS.

    brave-browser#50537 brave-core#32090
    Evidence
    • closed by cypt4 at 2025-11-13T08:22:14Z
    • state reason: completed

    Source time: · Detected: · Backfilled from source history

    2025-11-13T08:22:14Z
  3. PR merged

    Merged: [ZCash] Refactor zcash fee calculation

    Merged into brave-core master on 2025-11-13. Only builds cut from master after this merge (Nightly first) can contain it; whether a published build does is checked per build (see build presence on the item). Beta and Release get it only after a branch cut or an uplift.

    brave-core#32090
    Evidence
    • merged 2025-11-13T08:22:13Z
    • repository brave/brave-core
    • base branch master

    Source time: · Detected: · Backfilled from source history

    2025-11-13T08:22:13Z
  4. New issue

    New issue: [ZCash] Refactor tx fee calculation

    Opened in brave-browser#50537. This is a report or request, not a confirmed change to Brave Wallet.

    brave-browser#50537
    Evidence
    • created 2025-10-29T11:32:22Z

    Source time: · Detected: · Backfilled from source history

    2025-10-29T11:32:22Z