Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

[Part 6 enable_brave_wallet flag] Add static_assert for ENABLE_BRAVE_WALLET in wallet headers

Merged, build presence unknown Pull request Testnet, tests & tooling

Lead item brave-core#32552 · opened by bbondy · last source update

Issue state

No tracked issue; this group is led by a pull request.

Implementation

  • brave-core#32552 merged 2025-11-28 into wallet-build-flag-5 by bbondy
    [Part 6 enable_brave_wallet flag] Add static_assert for ENABLE_BRAVE_WALLET in wallet headers
    Linked by: issue timeline (closing cross-reference or closed by this PR)

Release notes

No platform changelog lists this item.

Validation

No QA label.

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

No milestone set.

Platforms (OS labels): none

Owner: unassigned · PR authors: bbondy

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopUnknown 1.97.59merged into feature branch wallet-build-flag-5; the PR that carried it to master is not tracked (brave-core#32552)Unknown 1.98.47merged into feature branch wallet-build-flag-5; the PR that carried it to master is not tracked (brave-core#32552)Unknown 1.100.5merged into feature branch wallet-build-flag-5; the PR that carried it to master is not tracked (brave-core#32552)
AndroidUnknown 1.97.57merged into feature branch wallet-build-flag-5; the PR that carried it to master is not tracked (brave-core#32552)Unknown 1.98.52merged into feature branch wallet-build-flag-5; the PR that carried it to master is not tracked (brave-core#32552)Unknown 1.100.5merged into feature branch wallet-build-flag-5; the PR that carried it to master is not tracked (brave-core#32552)
iOSUnknown 1.96.62merged into feature branch wallet-build-flag-5; the PR that carried it to master is not tracked (brave-core#32552)Unknown 1.99.44merged into feature branch wallet-build-flag-5; the PR that carried it to master is not tracked (brave-core#32552)Unknown 1.100.7merged into feature branch wallet-build-flag-5; the PR that carried it to master is not tracked (brave-core#32552)

Members and their history

Pull request

brave-core#32552 [Part 6 enable_brave_wallet flag] Add static_assert for ENABLE_BRAVE_WALLET in wallet headers

State: merged 2025-11-28 · created · closed · updated · discovered via search:zcash is:pr · matched body:zcash

CI/skip CI/run-network-audit feature/web3/wallet feature/web3/wallet/core

Adds compile-time assertions to wallet headers to ensure they are only included when wallet is enabled. This prevents accidental usage of wallet APIs when enable_brave_wallet=false. Added static_assert(BUILDFLAG(ENABLE_BRAVE_WALLET)) to: browser/brave_wallet/ (11 files): - asset_ratio_service_factory.h - brave_wallet_context_utils.h - brave_wallet_ipfs_service_factory.h - brave_wallet_provider_delegate_impl.h - brave_wallet_service_factory.h - brave_wallet_tab_helper.h -…

Timeline (3 of 7 events)
  1. 2025-11-26 03:20 Referenced by brave-core#32484 by bbondy
  2. 2025-11-28 12:59 Merged wallet-build-flag-5 by bbondy
  3. 2025-11-28 12:59 Closed by bbondy