Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

[wallet][safe-numerics] Improve `BtcLikeSerializerStream` use

In a Release build Pull request General Zcash support

Lead item brave-core#31886 · opened by cdesouza-chromium · last source update

Issue state

No tracked issue; this group is led by a pull request.

Implementation

  • brave-core#31886 merged 2025-10-23 into master by cdesouza-chromium
    [wallet][safe-numerics] Improve `BtcLikeSerializerStream` use
    Linked by: issue timeline (closing cross-reference or closed by this PR)

Release notes

No platform changelog lists this item.

Validation

No QA label.

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.86.x - Release

A milestone is a target set by Brave, not a release promise. Brave renames milestones as branches move from Nightly to Beta to Release.

Platforms (OS labels): none

Owner: unassigned · PR authors: cdesouza-chromium

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...37817d76: behind); later builds of the same history include it (brave-core#31886)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...37817d76: behind); later builds of the same history include it (brave-core#31886)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...37817d76: behind); later builds of the same history include it (brave-core#31886)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...37817d76: behind); later builds of the same history include it (brave-core#31886)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...37817d76: behind); later builds of the same history include it (brave-core#31886)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...37817d76: behind); later builds of the same history include it (brave-core#31886)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...37817d76: behind); later builds of the same history include it (brave-core#31886)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...37817d76: behind); later builds of the same history include it (brave-core#31886)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...37817d76: behind); later builds of the same history include it (brave-core#31886)

Members and their history

Pull request

brave-core#31886 [wallet][safe-numerics] Improve `BtcLikeSerializerStream` use

State: merged 2025-10-23 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:orchard is:pr, search:zcash is:pr

feature/web3/wallet feature/web3/wallet/core puLL-Merge

This PR greatly simplifies BtcLikeSerializerStream, but making the vector used as a buffer part of the class itself. This lines up with how all uses of this class occur, with the vector created just before the serialiser, so making the vector a member of the serialiser simplifies things significantly. A few checked_casts have been added to avoid future mistakes around this particular area of the code. Bug https://github.com/brave/brave-browser/issues/50271

Timeline (3 of 6 events)
  1. 2025-10-23 15:20 Merged master by cdesouza-chromium
  2. 2025-10-23 15:20 Closed by cdesouza-chromium
  3. 2025-10-23 15:20 Milestone set 1.86.x - Nightly by github-actions

Recorded changes

  1. PR merged

    Merged: [wallet][safe-numerics] Improve `BtcLikeSerializerStream` use

    Merged into brave-core master on 2025-10-23. Only builds cut from master after this merge (Nightly first) can contain it; whether a published build does is checked per build (see build presence on the item). Beta and Release get it only after a branch cut or an uplift.

    brave-core#31886
    Evidence
    • merged 2025-10-23T15:20:08Z
    • repository brave/brave-core
    • base branch master

    Source time: · Detected: · Backfilled from source history

    2025-10-23T15:20:08Z