Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

[CodeHealth] Mark global constants as `constexpr`

In a Release build Pull request Testnet, tests & tooling

Lead item brave-core#26588 · opened by cdesouza-chromium · last source update

Issue state

No tracked issue; this group is led by a pull request.

Implementation

  • brave-core#26588 merged 2024-11-18 into master by cdesouza-chromium
    [CodeHealth] Mark global constants as `constexpr`
    Linked by: issue timeline (closing cross-reference or closed by this PR)

Release notes

No platform changelog lists this item.

Validation

No QA label.

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.75.x - Release

A milestone is a target set by Brave, not a release promise. Brave renames milestones as branches move from Nightly to Beta to Release.

Platforms (OS labels): none

Owner: unassigned · PR authors: cdesouza-chromium

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...0c6e0301: behind); later builds of the same history include it (brave-core#26588)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...0c6e0301: behind); later builds of the same history include it (brave-core#26588)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...0c6e0301: behind); later builds of the same history include it (brave-core#26588)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...0c6e0301: behind); later builds of the same history include it (brave-core#26588)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...0c6e0301: behind); later builds of the same history include it (brave-core#26588)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...0c6e0301: behind); later builds of the same history include it (brave-core#26588)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...0c6e0301: behind); later builds of the same history include it (brave-core#26588)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...0c6e0301: behind); later builds of the same history include it (brave-core#26588)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...0c6e0301: behind); later builds of the same history include it (brave-core#26588)

Members and their history

Pull request

brave-core#26588 [CodeHealth] Mark global constants as `constexpr`

State: merged 2024-11-18 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:orchard is:pr, search:zcash is:pr

CI/run-network-audit feature/web3/wallet feature/web3/wallet/core puLL-Merge

This PR tags various global constants as constexpr. This is a better approach to constant values, as it can result in better codegen overall. This is a mechanical change. Resolves Submitter Checklist: - [ ] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [ ] There is a ticket for my issue - [ ] Used Github auto-closing keywords in the PR description above - [ ] Wrote a good PR/commit description -…

Timeline (3 of 7 events)
  1. 2024-11-18 12:41 Merged master by cdesouza-chromium
  2. 2024-11-18 12:41 Closed by cdesouza-chromium
  3. 2024-11-18 12:41 Milestone set 1.75.x - Nightly by github-actions