Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

[CodeHealth] Use `constexpr` strings

In a Release build Pull request Security & hardening

Lead item brave-core#25810 · opened by cdesouza-chromium · last source update

Issue state

No tracked issue; this group is led by a pull request.

Implementation

  • brave-core#25810 merged 2024-10-04 into master by cdesouza-chromium
    [CodeHealth] Use `constexpr` strings
    Linked by: issue timeline (closing cross-reference or closed by this PR)

Release notes

No platform changelog lists this item.

Validation

No QA label.

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.73.x - Release

A milestone is a target set by Brave, not a release promise. Brave renames milestones as branches move from Nightly to Beta to Release.

Platforms (OS labels): none

Owner: unassigned · PR authors: cdesouza-chromium

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...e1f8a284: behind); later builds of the same history include it (brave-core#25810)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...e1f8a284: behind); later builds of the same history include it (brave-core#25810)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...e1f8a284: behind); later builds of the same history include it (brave-core#25810)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...e1f8a284: behind); later builds of the same history include it (brave-core#25810)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...e1f8a284: behind); later builds of the same history include it (brave-core#25810)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...e1f8a284: behind); later builds of the same history include it (brave-core#25810)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...e1f8a284: behind); later builds of the same history include it (brave-core#25810)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...e1f8a284: behind); later builds of the same history include it (brave-core#25810)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...e1f8a284: behind); later builds of the same history include it (brave-core#25810)

Members and their history

Pull request

brave-core#25810 [CodeHealth] Use `constexpr` strings

State: merged 2024-10-04 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash

CI/run-network-audit needs-security-review feature/web3/wallet feature/web3/wallet/core puLL-Merge

This PR changes moves away from uses of const char with two approaches. For .cc files, these types are turned into constexpr ones, which gives the compiler more leeway for optimisations. For the constants on header files, we are converting these instances to inline constexpr, in order to also reduce string duplication across the binary. This change was generated with a tool. Resolves Submitter Checklist: - [ ] I confirm that no security/privacy review is needed and no other…

Timeline (3 of 8 events)
  1. 2024-10-04 17:01 Merged master by bridiver
  2. 2024-10-04 17:01 Closed by bridiver
  3. 2024-10-04 17:01 Milestone set 1.72.x - Nightly by github-actions