Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

[Polkadot] [Wallet] PolkadotImportKeyring needs unary predicate constructor support

In a Release build Issue Addresses, accounts & memos

Lead item brave-browser#53528 · opened by cmazakas · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#34991 merged 2026-03-27 into master by cmazakas
    [Polkadot] [Wallet] add OFAC address checking to PolkadotImportKeyring
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

No platform changelog lists this item.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.90.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: cmazakas · PR authors: cmazakas

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...363cc1cf: behind); later builds of the same history include it (brave-core#34991)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...363cc1cf: behind); later builds of the same history include it (brave-core#34991)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...363cc1cf: behind); later builds of the same history include it (brave-core#34991)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...363cc1cf: behind); later builds of the same history include it (brave-core#34991)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...363cc1cf: behind); later builds of the same history include it (brave-core#34991)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...363cc1cf: behind); later builds of the same history include it (brave-core#34991)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...363cc1cf: behind); later builds of the same history include it (brave-core#34991)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...363cc1cf: behind); later builds of the same history include it (brave-core#34991)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...363cc1cf: behind); later builds of the same history include it (brave-core#34991)

Members and their history

Issue

brave-browser#53528 [Polkadot] [Wallet] PolkadotImportKeyring needs unary predicate constructor support

State: closed (completed) · created · closed · updated · discovered via linked:brave/brave-core#34991

QA Pass-Win64 QA/Yes release-notes/exclude feature/web3/wallet OS/Desktop feature/web3/wallet/core feature/web3/polkadot

The PolkadotImportKeyring must be like the other account-based keyrings and accept a unary predicate it stores internally for address validity checking.

Timeline (10 of 13 events)
  1. 2026-03-11 16:08 Label added QA/No by cmazakas
  2. 2026-03-11 16:08 Label added release-notes/exclude by cmazakas
  3. 2026-03-11 16:09 Referenced by brave-core#34431 by cmazakas
  4. 2026-03-25 17:28 Referenced by brave-core#34991 by cmazakas
  5. 2026-03-27 20:51 Closed completed by cmazakas
  6. 2026-03-27 20:51 Milestone set 1.90.x - Nightly by brave-builds
  7. 2026-03-30 13:53 Label removed QA/No by cmazakas
  8. 2026-03-30 13:53 Label added QA/Yes by cmazakas
  9. 2026-03-30 13:53 Label added OS/Desktop by cmazakas
  10. 2026-04-27 06:29 Label added QA Pass-Win64 by srirambv
Pull request

brave-core#34991 [Polkadot] [Wallet] add OFAC address checking to PolkadotImportKeyring

State: merged 2026-03-27 · created · closed · updated · discovered via search:zec is:pr · matched body:zec

release-notes/exclude feature/web3/wallet feature/web3/wallet/core QA/No

Resolves https://github.com/brave/brave-browser/issues/53528 Update the PolkadotImportKeyring to support OFAC address sanctioning via our unary predicate method. We update the KeyringService to support grabbing the string representation of a given account's address in line with other coins such as BTC, ZEC, ADA. QA Test Plan: add banned Polkadot address to the OFAC list attempting to import the corresponding account should fail

Timeline (7 of 11 events)
  1. 2026-03-25 17:28 Label added release-notes/exclude by cmazakas
  2. 2026-03-25 17:28 Label added QA/No by cmazakas
  3. 2026-03-25 17:35 Referenced by brave-core#33537 by cmazakas
  4. 2026-03-27 20:51 Merged master by cmazakas
  5. 2026-03-27 20:51 Closed by cmazakas
  6. 2026-03-27 20:51 Milestone set 1.90.x - Nightly by github-actions
  7. 2026-04-27 06:29 Referenced by brave-browser#53528 by srirambv