Zcash × Brave WalletPersonal project

Type to search. Use ↑ ↓ and Enter to open a result.

[Wallet] Webview crashes when trying to select tokens in Send/Swap/Bridge screen

In a Release build Bug Transactions & fees

Lead item brave-browser#52346 · opened by srirambv · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#33468 merged 2026-01-28 into master by Douglashdaniel
    [Wallet]: Select Token Modal Optimizations
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Uplifts to release branches

Release notes

No platform changelog lists this item.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.86.x - Release #6

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: Douglashdaniel · PR authors: Douglashdaniel, brave-builds

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...7825c990: behind); later builds of the same history include it (brave-core#33468)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...7825c990: behind); later builds of the same history include it (brave-core#33468)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...7825c990: behind); later builds of the same history include it (brave-core#33468)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...7825c990: behind); later builds of the same history include it (brave-core#33468)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...7825c990: behind); later builds of the same history include it (brave-core#33468)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...7825c990: behind); later builds of the same history include it (brave-core#33468)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...7825c990: behind); later builds of the same history include it (brave-core#33468)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...7825c990: behind); later builds of the same history include it (brave-core#33468)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...7825c990: behind); later builds of the same history include it (brave-core#33468)

Members and their history

Issue

brave-browser#52346 [Wallet] Webview crashes when trying to select tokens in Send/Swap/Bridge screen

State: closed (completed) · created · closed · updated · discovered via search:zcash · matched body:zcash

crash QA Pass-Win64 perf QA/Yes release-notes/exclude feature/web3/wallet OS/Desktop front-end-change

IMPORTANT: Your crash has already been automatically reported to our crash system. Please file this bug only if you can provide more information about it. Brave Version: 1.88.71 Chromium: 144.0.7559.97 Operating System: Windows NT 10.0.26200 URL (if applicable) where crash occurred: Can you reproduce this crash? Yes What steps will reproduce this crash? (If it's not reproducible, what were you doing just before the crash?) 1. Select Zcash token in Send screen 2. Stay on the…

Timeline (13 of 17 events)
  1. 2026-01-28 15:10 Label added QA/Yes by srirambv
  2. 2026-01-28 15:10 Label added release-notes/exclude by srirambv
  3. 2026-01-28 17:25 Referenced by brave-core#33468 by Douglashdaniel
  4. 2026-01-28 19:31 Closed completed brave-core#33468 by Douglashdaniel
  5. 2026-01-28 19:32 Milestone set 1.88.x - Nightly by brave-builds
  6. 2026-01-29 13:46 Referenced by brave-core#33479 by kjozwiak
  7. 2026-01-29 13:46 Referenced by brave-core#33480 by kjozwiak
  8. 2026-01-29 13:48 Milestone removed 1.88.x - Nightly by brave-builds
  9. 2026-01-29 13:48 Milestone set 1.87.x - Beta by brave-builds
  10. 2026-01-29 13:48 Milestone removed 1.87.x - Beta by brave-builds
  11. 2026-01-29 13:48 Milestone set 1.86.x - Release #6 by brave-builds
  12. 2026-02-02 04:36 Label added OS/Desktop by Douglashdaniel
  13. 2026-02-03 14:02 Label added QA Pass-Win64 by srirambv
Pull request

brave-core#33468 [Wallet]: Select Token Modal Optimizations

State: merged 2026-01-28 · created · closed · updated · discovered via search:shielded is:pr, search:zcash is:pr · matched body:zcash

CI/storybook-url feature/web3/wallet

Description - Heavy API calls (tokens registry, combined tokens, balances, spot prices) are now gated behind a shouldFetchModalData state, which will allow the modal to be painted before making calls. - Wrapped ListItem and VirtualizedTokenList in a memo so they only re-render when their props change (e.g. when spot prices or list data change), reducing work when the modal re-renders. Resolves Test plan: 1. Open the Wallet and navigate to the Send screen 2. Open the Select…

Timeline (6 of 8 events)
  1. 2026-01-28 19:31 Merged master by Douglashdaniel
  2. 2026-01-28 19:31 Closed by Douglashdaniel
  3. 2026-01-28 19:32 Milestone set 1.88.x - Nightly by github-actions
  4. 2026-01-28 21:40 Referenced by brave-core#33479 by brave-builds
  5. 2026-01-28 21:40 Referenced by brave-core#33480 by brave-builds
  6. 2026-02-03 14:02 Referenced by brave-browser#52346 by srirambv
Uplift PR → 1.87.x

brave-core#33479 [Wallet]: Select Token Modal Optimizations (uplift to 1.87.x)

State: merged 2026-01-29 · created · closed · updated · discovered via mentions:brave/brave-browser#52346, mentions:brave/brave-core#33468

CI/storybook-url feature/web3/wallet

Uplift of #33468 Resolves https://github.com/brave/brave-browser/issues/52346 Pre-approval checklist: - [x] You have tested your change on Nightly. - [ ] This contains text which needs to be translated. - [ ] There are more than 7 days before the release. - [ ] I've notified folks in #l10n on Slack that translations are needed. - [x] The PR milestones match the branch they are landing to. Pre-merge checklist: - [x] You have checked CI and the builds, lint, and tests all…

Timeline (3 of 5 events)
  1. 2026-01-28 21:40 Milestone set 1.87.x - Beta by brave-builds
  2. 2026-01-29 13:48 Merged 1.87.x by kjozwiak
  3. 2026-01-29 13:48 Closed by kjozwiak
Uplift PR → 1.86.x

brave-core#33480 [Wallet]: Select Token Modal Optimizations (uplift to 1.86.x)

State: merged 2026-01-29 · created · closed · updated · discovered via mentions:brave/brave-browser#52346, mentions:brave/brave-core#33468

CI/storybook-url feature/web3/wallet

Uplift of #33468 Resolves https://github.com/brave/brave-browser/issues/52346 Pre-approval checklist: - [x] You have tested your change on Nightly. - [ ] This contains text which needs to be translated. - [ ] There are more than 7 days before the release. - [ ] I've notified folks in #l10n on Slack that translations are needed. - [x] The PR milestones match the branch they are landing to. Pre-merge checklist: - [x] You have checked CI and the builds, lint, and tests all…

Timeline (3 of 5 events)
  1. 2026-01-28 21:40 Milestone set 1.86.x - Release #6 by brave-builds
  2. 2026-01-29 13:48 Merged 1.86.x by kjozwiak
  3. 2026-01-29 13:48 Closed by kjozwiak