Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Add SafeSign for Gate3 swaps

In release notes Feature Swaps, bridge & on-ramps

Lead item brave-browser#51936 · opened by onyb · last source update

Issue state

Closed (completed)

Closed . GitHub type: Enhancement.

Implementation

  • brave-core#33156 merged 2026-01-19 into master by onyb
    [SafeSign] Enable SafeSign for Gate3 swaps via swap_info metadata
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

  • Desktop 1.88.127: “Added "SafeSign" for "Gate3" swaps. (#51936)” changelog line

Release notes are per platform. Lines come from each platform’s Stable changelog. A platform without an entry is not covered by these lines.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.88.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: onyb · PR authors: onyb

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...a799843b: behind); later builds of the same history include it (brave-core#33156)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...a799843b: behind); later builds of the same history include it (brave-core#33156)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...a799843b: behind); later builds of the same history include it (brave-core#33156)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...a799843b: behind); later builds of the same history include it (brave-core#33156)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...a799843b: behind); later builds of the same history include it (brave-core#33156)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...a799843b: behind); later builds of the same history include it (brave-core#33156)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...a799843b: behind); later builds of the same history include it (brave-core#33156)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...a799843b: behind); later builds of the same history include it (brave-core#33156)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...a799843b: behind); later builds of the same history include it (brave-core#33156)

Members and their history

Issue

brave-browser#51936 Add SafeSign for Gate3 swaps

State: closed (completed) · created · closed · updated · discovered via linked:brave/brave-core#33156

QA Pass-Win64 QA/Yes release-notes/include feature/web3/wallet OS/Desktop feature/web3/wallet/core feature/web3/wallet/swap

Description In order to make this work universally, we need to capture swap metadata and store it in prefs as part of the TransactionInfo object. This is especially required for Near Intents transactions, since they do not have calldata and rely solely on deposit addresses created uniquely for the swap order. Steps to reproduce 1. Go to Bridge 2. Create a SOL -> BTC transaction 3. The confirmation panel pops up Actual result SafeSign either does not work, or shows…

Timeline (8 of 11 events)
  1. 2026-01-12 20:17 Label added OS/Desktop by onyb
  2. 2026-01-12 20:18 Label added QA/Yes by onyb
  3. 2026-01-12 20:18 Label added release-notes/include by onyb
  4. 2026-01-12 20:18 Referenced by brave-core#33156 by onyb
  5. 2026-01-19 16:12 Closed completed brave-core#33156 by onyb
  6. 2026-01-19 16:13 Milestone set 1.88.x - Nightly by brave-builds
  7. 2026-02-25 11:31 Label added QA Pass-Win64 by srirambv
  8. 2026-03-10 12:49 Referenced by brave-browser#53504 by LaurenWags
Pull request

brave-core#33156 [SafeSign] Enable SafeSign for Gate3 swaps via swap_info metadata

State: merged 2026-01-19 · created · closed · updated · discovered via search:zcash is:pr · matched body:zcash

CI/storybook-url feature/web3/wallet feature/web3/wallet/core puLL-Merge

Overview This PR introduces SafeSign support for swaps facilitated by Gate3. Instead of parsing swap details from transaction data after-the-fact, we now capture and store comprehensive swap metadata (SwapInfo) at transaction creation time. Resolves https://github.com/brave/brave-browser/issues/51936 What's Different from Legacy SafeSign? - ✅ Universal blockchain support - Works on EVM, Bitcoin, Solana, Cardano, ZCash (not just EVM) - ✅ Complete metadata - Full swap…

Timeline (8 of 12 events)
  1. 2026-01-13 15:15 Converted to draft by onyb
  2. 2026-01-14 19:45 Ready for review by onyb
  3. 2026-01-16 12:44 Referenced by brave-browser#34829 by onyb
  4. 2026-01-19 10:17 Referenced by brave-browser#52082 by onyb
  5. 2026-01-19 16:12 Merged master by onyb
  6. 2026-01-19 16:12 Closed by onyb
  7. 2026-01-19 16:13 Milestone set 1.88.x - Nightly by github-actions
  8. 2026-02-25 11:31 Referenced by brave-browser#51936 by srirambv