Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

[ZCash] Add ZCashTransaction validation checks

In a Release build Task Security & hardening

Lead item brave-browser#50762 · opened by cypt4 · last source update

Issue state

Closed (completed)

Closed . GitHub type: Task.

Implementation

  • brave-core#32249 merged 2025-11-17 into master by cypt4
    [ZCash] Add transacation validation before sending.
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description, branch name brave_50762 (weaker evidence; titles share a keyword)

Release notes

No platform changelog lists this item.

Validation

Not QA-tested (QA/No).

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.86.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: cypt4 · PR authors: cypt4

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...aac110a7: behind); later builds of the same history include it (brave-core#32249)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...aac110a7: behind); later builds of the same history include it (brave-core#32249)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...aac110a7: behind); later builds of the same history include it (brave-core#32249)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...aac110a7: behind); later builds of the same history include it (brave-core#32249)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...aac110a7: behind); later builds of the same history include it (brave-core#32249)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...aac110a7: behind); later builds of the same history include it (brave-core#32249)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...aac110a7: behind); later builds of the same history include it (brave-core#32249)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...aac110a7: behind); later builds of the same history include it (brave-core#32249)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...aac110a7: behind); later builds of the same history include it (brave-core#32249)

Members and their history

Issue

brave-browser#50762 [ZCash] Add ZCashTransaction validation checks

State: closed (completed) · created · closed · updated · discovered via search:zcash · matched title:zcash

QA/No release-notes/exclude feature/web3/wallet OS/Desktop

Description Check inputs and outputs are correct before signing and sending Steps to reproduce - Actual result - Expected result - Reproduces how often Easily reproduced Brave version (brave://version info) - Channel information - [ ] release (stable) - [ ] beta - [ ] nightly Reproducibility - [ ] with Brave Shields disabled - [ ] with Brave Rewards disabled - [ ] in the latest version of Chrome Miscellaneous information _No response_

Timeline (6 of 9 events)
  1. 2025-11-11 14:12 Label added OS/Desktop by cypt4
  2. 2025-11-11 16:13 Referenced by brave-core#32249 by cypt4
  3. 2025-11-17 16:29 Closed completed brave-core#32249 by cypt4
  4. 2025-11-17 16:29 Label added QA/No by cypt4
  5. 2025-11-17 16:29 Label added release-notes/exclude by cypt4
  6. 2025-11-17 16:30 Milestone set 1.86.x - Nightly by brave-builds
Pull request

brave-core#32249 [ZCash] Add transacation validation before sending.

State: merged 2025-11-17 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:zcash is:pr · matched title:zcash

feature/web3/wallet feature/web3/wallet/core

Resolves https://github.com/brave/brave-browser/issues/50762 Added additional check before transaction sending to check whether there are no missing inputs and inputs sum = outputs sum + fee.

Timeline (3 of 5 events)
  1. 2025-11-17 16:29 Merged master by cypt4
  2. 2025-11-17 16:29 Closed by cypt4
  3. 2025-11-17 16:29 Milestone set 1.86.x - Nightly by github-actions

Recorded changes

  1. Issue closed

    Closed (completed): [ZCash] Add ZCashTransaction validation checks

    Closed as completed; linked PR merged 2025-11-17. Code is in current Release builds for Desktop, Android, iOS.

    brave-browser#50762 brave-core#32249
    Evidence
    • closed by cypt4 at 2025-11-17T16:29:34Z
    • state reason: completed

    Source time: · Detected: · Backfilled from source history

    2025-11-17T16:29:34Z
  2. PR merged

    Merged: [ZCash] Add transacation validation before sending.

    Merged into brave-core master on 2025-11-17. Only builds cut from master after this merge (Nightly first) can contain it; whether a published build does is checked per build (see build presence on the item). Beta and Release get it only after a branch cut or an uplift.

    brave-core#32249
    Evidence
    • merged 2025-11-17T16:29:33Z
    • repository brave/brave-core
    • base branch master

    Source time: · Detected: · Backfilled from source history

    2025-11-17T16:29:33Z
  3. New issue

    New issue: [ZCash] Add ZCashTransaction validation checks

    Opened in brave-browser#50762. This is a report or request, not a confirmed change to Brave Wallet.

    brave-browser#50762
    Evidence
    • created 2025-11-11T14:12:39Z

    Source time: · Detected: · Backfilled from source history

    2025-11-11T14:12:39Z