Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Remove inferable `operator!=`

In a Release build Issue Testnet, tests & tooling

Lead item brave-browser#50319 · opened by cdesouza-chromium · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#31905 merged 2025-10-23 into master by cdesouza-chromium
    [CodeHealth] Remove inferable `operator!=`
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

No platform changelog lists this item.

Validation

Not QA-tested (QA/No).

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.86.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: cdesouza-chromium · PR authors: cdesouza-chromium

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...236b1042: behind); later builds of the same history include it (brave-core#31905)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...236b1042: behind); later builds of the same history include it (brave-core#31905)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...236b1042: behind); later builds of the same history include it (brave-core#31905)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...236b1042: behind); later builds of the same history include it (brave-core#31905)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...236b1042: behind); later builds of the same history include it (brave-core#31905)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...236b1042: behind); later builds of the same history include it (brave-core#31905)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...236b1042: behind); later builds of the same history include it (brave-core#31905)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...236b1042: behind); later builds of the same history include it (brave-core#31905)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...236b1042: behind); later builds of the same history include it (brave-core#31905)

Members and their history

Issue

brave-browser#50319 Remove inferable `operator!=`

State: closed (completed) · created · closed · updated · discovered via linked:brave/brave-core#31905

QA/No dev-concern release-notes/exclude QA/Test-Plan-Specified feature/web3/wallet OS/Desktop feature/web3/wallet/core code-health

As of C++20, the compiler can synthesize operator!= from operator==.

Timeline (7 of 11 events)
  1. 2025-10-19 16:36 Label added QA/No by cdesouza-chromium
  2. 2025-10-19 16:36 Label added release-notes/exclude by cdesouza-chromium
  3. 2025-10-19 16:36 Label added QA/Test-Plan-Specified by cdesouza-chromium
  4. 2025-10-19 16:36 Label added OS/Desktop by cdesouza-chromium
  5. 2025-10-19 16:39 Referenced by brave-core#31905 by cdesouza-chromium
  6. 2025-10-23 11:01 Closed completed brave-core#31905 by cdesouza-chromium
  7. 2025-10-23 11:01 Milestone set 1.86.x - Nightly by brave-builds
Pull request

brave-core#31905 [CodeHealth] Remove inferable `operator!=`

State: merged 2025-10-23 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash

feature/web3/wallet feature/web3/wallet/core puLL-Merge

As of C++20, the compiler can synthesize operator!= in terms of operator==, so we no longer need to manually supply that definition. https://en.cppreference.com/w/cpp/language/overload_resolution.html#Call_to_an_overloaded_operator Resolves https://github.com/brave/brave-browser/issues/50319

Timeline (3 of 6 events)
  1. 2025-10-23 11:01 Merged master by cdesouza-chromium
  2. 2025-10-23 11:01 Closed by cdesouza-chromium
  3. 2025-10-23 11:01 Milestone set 1.86.x - Nightly by github-actions

Recorded changes

  1. Issue closed

    Closed (completed): Remove inferable `operator!=`

    Closed as completed; linked PR merged 2025-10-23. Code is in current Release builds for Desktop, Android, iOS.

    brave-browser#50319 brave-core#31905
    Evidence
    • closed by cdesouza-chromium at 2025-10-23T11:01:10Z
    • state reason: completed

    Source time: · Detected: · Backfilled from source history

    2025-10-23T11:01:10Z
  2. PR merged

    Merged: [CodeHealth] Remove inferable `operator!=`

    Merged into brave-core master on 2025-10-23. Only builds cut from master after this merge (Nightly first) can contain it; whether a published build does is checked per build (see build presence on the item). Beta and Release get it only after a branch cut or an uplift.

    brave-core#31905
    Evidence
    • merged 2025-10-23T11:01:09Z
    • repository brave/brave-core
    • base branch master

    Source time: · Detected: · Backfilled from source history

    2025-10-23T11:01:09Z
  3. New issue

    New issue: Remove inferable `operator!=`

    Opened in brave-browser#50319. This is a report or request, not a confirmed change to Brave Wallet.

    brave-browser#50319
    Evidence
    • created 2025-10-19T16:36:53Z

    Source time: · Detected: · Backfilled from source history

    2025-10-19T16:36:53Z