Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

[Zcash] Remove reduntant chain_id argument

In a Release build Task General Zcash support

Lead item brave-browser#50148 · opened by cypt4 · last source update

Issue state

Closed (completed)

Closed . GitHub type: Task.

Implementation

  • brave-core#31802 merged 2025-10-16 into master by cypt4
    [ZCash] Remove redundant chain_id parameters from function calls
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description, branch name brave_50148 (weaker evidence; titles share a keyword)

Release notes

No platform changelog lists this item.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.85.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: cypt4 · PR authors: cypt4

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...d4db62f6: behind); later builds of the same history include it (brave-core#31802)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...d4db62f6: behind); later builds of the same history include it (brave-core#31802)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...d4db62f6: behind); later builds of the same history include it (brave-core#31802)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...d4db62f6: behind); later builds of the same history include it (brave-core#31802)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...d4db62f6: behind); later builds of the same history include it (brave-core#31802)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...d4db62f6: behind); later builds of the same history include it (brave-core#31802)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...d4db62f6: behind); later builds of the same history include it (brave-core#31802)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...d4db62f6: behind); later builds of the same history include it (brave-core#31802)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...d4db62f6: behind); later builds of the same history include it (brave-core#31802)

Members and their history

Issue

brave-browser#50148 [Zcash] Remove reduntant chain_id argument

State: closed (completed) · created · closed · updated · discovered via label:feature/web3/wallet/zcash, search:zcash · matched label:feature/web3/wallet/zcash, title:zcash, body:zcash

QA Pass-Win64 dev-concern QA/Yes release-notes/exclude feature/web3/wallet OS/Desktop feature/web3/wallet/core feature/web3/wallet/zcash code-health

Description Since Zcash has only one chain_id per keyring_id we can remove redundant chain_id argument Test plan: Minimal set of Zcash use cases should be tested - balance resolution, tx sending, syncing. Steps to reproduce - Actual result - Expected result - Reproduces how often Easily reproduced Brave version (brave://version info) - Channel information - [ ] release (stable) - [ ] beta - [ ] nightly Reproducibility - [ ] with Brave Shields disabled - [ ] with Brave…

Timeline (7 of 12 events)
  1. 2025-10-14 10:32 Label added OS/Desktop by cypt4
  2. 2025-10-14 10:51 Referenced by brave-core#31802 by cypt4
  3. 2025-10-14 11:30 Label added QA/Yes by cypt4
  4. 2025-10-14 11:30 Label added release-notes/exclude by cypt4
  5. 2025-10-16 08:35 Closed completed brave-core#31802 by cypt4
  6. 2025-10-16 08:35 Milestone set 1.85.x - Nightly by brave-builds
  7. 2025-11-14 15:50 Label added QA Pass-Win64 by srirambv
Pull request

brave-core#31802 [ZCash] Remove redundant chain_id parameters from function calls

State: merged 2025-10-16 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:zcash is:pr, search:zec is:pr · matched title:zcash, body:zcash

CI/storybook-url feature/web3/wallet feature/web3/wallet/core puLL-Merge

Resolves https://github.com/brave/brave-browser/issues/50148 This is a part of ZCash testnet support - removes redundant chain_id argument since account already contains information whether it is testnet or not.

Timeline (4 of 8 events)
  1. 2025-10-14 11:35 Ready for review by cypt4
  2. 2025-10-16 08:35 Merged master by cypt4
  3. 2025-10-16 08:35 Closed by cypt4
  4. 2025-10-16 08:35 Milestone set 1.85.x - Nightly by github-actions

Recorded changes

  1. QA passed

    QA Pass-Win64: [Zcash] Remove reduntant chain_id argument

    Brave QA marked this as passed on Win64. Other platforms are not covered by this label.

    brave-browser#50148
    Evidence
    • label "QA Pass-Win64" added at 2025-11-14T15:50:35Z

    Source time: · Detected: · Backfilled from source history

    2025-11-14T15:50:35Z