Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Implement additional unit tests for ZEC Wallet Service - MakeAccountSheilded

Open Issue Testnet, tests & tooling

Lead item brave-browser#50129 · opened by kdenhartog · last source update

This issue is open on GitHub. Fixes sometimes land through pull requests that do not link the issue (for example a later refactor); this tracker follows only explicit links (closing references, “Resolves” lines, brave_<issue> branch names, uplifts and the issue timeline).

Issue state

Open

Open.

Implementation

No pull request is linked by closing keywords, GitHub’s closing references, a brave_<issue> branch name or the issue timeline.

Release notes

No platform changelog lists this item.

Validation

No QA label.

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

No milestone set.

Platforms (OS labels): none

Owner: cypt4

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopUnknown 1.97.59no merged PR is linked, so presence in this build is unknownUnknown 1.98.47no merged PR is linked, so presence in this build is unknownUnknown 1.100.5no merged PR is linked, so presence in this build is unknown
AndroidUnknown 1.97.57no merged PR is linked, so presence in this build is unknownUnknown 1.98.52no merged PR is linked, so presence in this build is unknownUnknown 1.100.5no merged PR is linked, so presence in this build is unknown
iOSUnknown 1.96.62no merged PR is linked, so presence in this build is unknownUnknown 1.99.44no merged PR is linked, so presence in this build is unknownUnknown 1.100.7no merged PR is linked, so presence in this build is unknown

Members and their history

Issue

brave-browser#50129 Implement additional unit tests for ZEC Wallet Service - MakeAccountSheilded

State: open · created · updated · discovered via label:feature/web3/wallet/zcash, search:shielded wallet, search:zcash, search:zec · matched label:feature/web3/wallet/zcash, title:zec, body:zcash_wallet_service

priority/P3 dev-concern feature/web3/wallet feature/web3/wallet/core feature/web3/wallet/zcash

We need Additional Zcash_wallet_service test cases for the following aspects: MakeAccountShielded Failure Cases - [ ] MakeAccountShielded_AlreadyShielded - Tests the idempotency scenario where an account that already has a shield birthday is being made shielded again. This could occur if users click the "enable shielded" button multiple times or if there's a race condition in the UI. The test should verify that the service either succeeds (as a no-op) or returns a clear…

Timeline (1 of 5 events)
  1. 2026-01-16 04:52 Label added priority/P3 by kdenhartog