Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Implement additional unit tests for ZEC Wallet Service - GetTransactionType

In a Release build Task Testnet, tests & tooling

Lead item brave-browser#50125 · opened by kdenhartog · last source update

Issue state

Closed (completed)

Closed . GitHub type: Task.

Implementation

  • brave-core#32235 merged 2025-11-13 into master by cypt4
    [ZCash] Additional tests for transaction types
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description, branch name brave_50125_1 (weaker evidence; titles share a keyword)

Release notes

No platform changelog lists this item.

Validation

Not QA-tested (QA/No).

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.86.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Android, Desktop, iOS

Owner: cypt4 · PR authors: cypt4

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...10438849: behind); later builds of the same history include it (brave-core#32235)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...10438849: behind); later builds of the same history include it (brave-core#32235)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...10438849: behind); later builds of the same history include it (brave-core#32235)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...10438849: behind); later builds of the same history include it (brave-core#32235)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...10438849: behind); later builds of the same history include it (brave-core#32235)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...10438849: behind); later builds of the same history include it (brave-core#32235)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...10438849: behind); later builds of the same history include it (brave-core#32235)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...10438849: behind); later builds of the same history include it (brave-core#32235)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...10438849: behind); later builds of the same history include it (brave-core#32235)

Members and their history

Issue

brave-browser#50125 Implement additional unit tests for ZEC Wallet Service - GetTransactionType

State: closed (completed) · created · closed · updated · discovered via label:feature/web3/wallet/zcash, search:zcash, search:zec · matched label:feature/web3/wallet/zcash, title:zec, body:zcash_wallet_service

QA/No release-notes/exclude feature/web3/wallet OS/Android OS/Desktop OS/iOS feature/web3/wallet/core feature/web3/wallet/zcash

We need Additional Zcash_wallet_service test cases for the following aspects: GetTransactionType Edge Cases - [ ] GetTransactionType_EmptyAddress - Tests handling of an empty string address input. This boundary condition could occur due to form validation issues, API misuse, or malformed requests. The test should verify that the service returns an appropriate error or unknown type rather than crashing on empty input, ensuring robust input validation at the service boundary.…

Timeline (8 of 11 events)
  1. 2025-11-10 19:53 Referenced by brave-core#32235 by cypt4
  2. 2025-11-13 13:00 Closed completed brave-core#32235 by cypt4
  3. 2025-11-13 13:00 Milestone set 1.86.x - Nightly by brave-builds
  4. 2025-11-28 12:02 Label added QA/No by cypt4
  5. 2025-11-28 12:02 Label added release-notes/exclude by cypt4
  6. 2025-12-02 10:14 Label added OS/Android by cypt4
  7. 2025-12-02 10:14 Label added OS/Desktop by cypt4
  8. 2025-12-02 10:14 Label added OS/iOS by cypt4
Pull request

brave-core#32235 [ZCash] Additional tests for transaction types

State: merged 2025-11-13 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:zcash is:pr · matched title:zcash

feature/web3/wallet feature/web3/wallet/core

Resolves https://github.com/brave/brave-browser/issues/50125 Resolves

Timeline (3 of 5 events)
  1. 2025-11-13 13:00 Merged master by cypt4
  2. 2025-11-13 13:00 Closed by cypt4
  3. 2025-11-13 13:00 Milestone set 1.86.x - Nightly by github-actions

Recorded changes

  1. Issue closed

    Closed (completed): Implement additional unit tests for ZEC Wallet Service - GetTransactionType

    Closed as completed; linked PR merged 2025-11-13. Code is in current Release builds for Desktop, Android, iOS.

    brave-browser#50125 brave-core#32235
    Evidence
    • closed by cypt4 at 2025-11-13T13:00:16Z
    • state reason: completed

    Source time: · Detected: · Backfilled from source history

    2025-11-13T13:00:16Z
  2. PR merged

    Merged: [ZCash] Additional tests for transaction types

    Merged into brave-core master on 2025-11-13. Only builds cut from master after this merge (Nightly first) can contain it; whether a published build does is checked per build (see build presence on the item). Beta and Release get it only after a branch cut or an uplift.

    brave-core#32235
    Evidence
    • merged 2025-11-13T13:00:14Z
    • repository brave/brave-core
    • base branch master

    Source time: · Detected: · Backfilled from source history

    2025-11-13T13:00:14Z