Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Handle Confirm Shield in New Confirmation Panel

In release notes Feature Shielded (Orchard) support

Lead item brave-browser#49621 · opened by Douglashdaniel · last source update

Issue state

Closed (completed)

Closed . GitHub type: Enhancement.

Implementation

  • brave-core#31412 merged 2025-09-25 into master by Douglashdaniel
    feat(wallet): Handle Confirm Shield in New Confirmation Panel
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Uplifts to release branches

Release notes

  • Desktop 1.84.132: “Updated "Confirm Shield" panel UI for ZEC Shield transactions. (#49621)” changelog line

Release notes are per platform. Lines come from each platform’s Stable changelog. A platform without an entry is not covered by these lines.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)
  • QA Pass-macOS (Desktop only)
  • QA Pass-Linux (Desktop only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.84.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: Douglashdaniel · PR authors: Douglashdaniel, brave-builds

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...c763f8cd: behind); later builds of the same history include it (brave-core#31412)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...c763f8cd: behind); later builds of the same history include it (brave-core#31412)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...c763f8cd: behind); later builds of the same history include it (brave-core#31412)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...c763f8cd: behind); later builds of the same history include it (brave-core#31412)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...c763f8cd: behind); later builds of the same history include it (brave-core#31412)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...c763f8cd: behind); later builds of the same history include it (brave-core#31412)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...c763f8cd: behind); later builds of the same history include it (brave-core#31412)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...c763f8cd: behind); later builds of the same history include it (brave-core#31412)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...c763f8cd: behind); later builds of the same history include it (brave-core#31412)

Members and their history

Issue

brave-browser#49621 Handle Confirm Shield in New Confirmation Panel

State: closed (completed) · created · closed · updated · discovered via linked:brave/brave-core#31412

QA Pass-Win64 QA Pass-macOS QA Pass-Linux QA/Yes release-notes/include feature-request feature/web3/wallet OS/Desktop QA/Test-All-Platforms front-end-change feature/web3/wallet/core

Platforms Windows, macOS, Linux Description We need to handle Confirm Shield in the new Confirm Send panel [image]

Timeline (14 of 18 events)
  1. 2025-09-24 20:59 Label added QA/Yes by Douglashdaniel
  2. 2025-09-24 20:59 Label added release-notes/include by Douglashdaniel
  3. 2025-09-24 20:59 Label added OS/Desktop by Douglashdaniel
  4. 2025-09-24 21:06 Referenced by brave-core#31412 by Douglashdaniel
  5. 2025-09-25 17:22 Closed completed brave-core#31412 by Douglashdaniel
  6. 2025-09-25 17:22 Milestone set 1.85.x - Nightly by brave-builds
  7. 2025-09-26 15:49 Milestone removed 1.85.x - Nightly by brave-builds
  8. 2025-09-26 15:49 Milestone set 1.84.x - Beta by brave-builds
  9. 2025-09-26 15:49 Referenced by brave-core#31439 by kjozwiak
  10. 2025-10-07 12:27 Label added QA/Test-All-Platforms by srirambv
  11. 2025-10-07 13:00 Label added QA Pass-Win64 by srirambv
  12. 2025-10-07 13:00 Label added QA Pass-macOS by srirambv
  13. 2025-10-07 13:00 Label added QA Pass-Linux by srirambv
  14. 2025-10-28 13:02 Referenced by brave-browser#50515 by LaurenWags
Pull request

brave-core#31412 feat(wallet): Handle Confirm Shield in New Confirmation Panel

State: merged 2025-09-25 · created · closed · updated · discovered via search:zec is:pr · matched body:zec

CI/storybook-url feature/web3/wallet feature/web3/wallet/core

Description Handles Confirm Shield in the new Confirmation Panel UI Resolves Test Plan: 1. Create a Shield Funds transaction and wait for the Confirmation panel to pop up 2. The title should be Confirm shield 3. The amount label should be Shielding 4. The confirm button should say Shield ZEC Before: [image] After: [image]

Timeline (5 of 8 events)
  1. 2025-09-25 17:22 Merged master by Douglashdaniel
  2. 2025-09-25 17:22 Closed by Douglashdaniel
  3. 2025-09-25 17:22 Milestone set 1.85.x - Nightly by github-actions
  4. 2025-09-25 21:10 Referenced by brave-core#31439 by brave-builds
  5. 2025-10-07 13:00 Referenced by brave-browser#49621 by srirambv
Uplift PR → 1.84.x

brave-core#31439 feat(wallet): Handle Confirm Shield in New Confirmation Panel (uplift to 1.84.x)

State: merged 2025-09-26 · created · closed · updated · discovered via mentions:brave/brave-core#31412

CI/storybook-url feature/web3/wallet feature/web3/wallet/core

Uplift of #31412 Resolves https://github.com/brave/brave-browser/issues/49621 Pre-approval checklist: - [x] You have tested your change on Nightly. - [ ] This contains text which needs to be translated. - [ ] There are more than 7 days before the release. - [ ] I've notified folks in #l10n on Slack that translations are needed. - [x] The PR milestones match the branch they are landing to. Pre-merge checklist: - [x] You have checked CI and the builds, lint, and tests all…

Timeline (3 of 6 events)
  1. 2025-09-25 21:10 Milestone set 1.84.x - Beta by brave-builds
  2. 2025-09-26 15:48 Merged 1.84.x by kjozwiak
  3. 2025-09-26 15:48 Closed by kjozwiak