Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

[Zcash] Fix t->s tx amount type

In a Release build Bug Transactions & fees

Lead item brave-browser#47994 · opened by cypt4 · last source update

Issue state

Closed (completed)

Closed . GitHub type: Bug.

Implementation

  • brave-core#30332 merged 2025-08-01 into master by cypt4
    [ZCash] Change orchard notes amount type to uint64
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description, branch name brave_47994_1 (weaker evidence; titles share a keyword)

Uplifts to release branches

Release notes

No platform changelog lists this item.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.81.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: cypt4 · PR authors: cypt4, brave-builds

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...a1a191f5: behind); later builds of the same history include it (brave-core#30332)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...a1a191f5: behind); later builds of the same history include it (brave-core#30332)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...a1a191f5: behind); later builds of the same history include it (brave-core#30332)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...a1a191f5: behind); later builds of the same history include it (brave-core#30332)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...a1a191f5: behind); later builds of the same history include it (brave-core#30332)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...a1a191f5: behind); later builds of the same history include it (brave-core#30332)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...a1a191f5: behind); later builds of the same history include it (brave-core#30332)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...a1a191f5: behind); later builds of the same history include it (brave-core#30332)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...a1a191f5: behind); later builds of the same history include it (brave-core#30332)

Members and their history

Issue

brave-browser#47994 [Zcash] Fix t->s tx amount type

State: closed (completed) · created · closed · updated · discovered via label:feature/web3/wallet/zcash, search:zcash · matched label:feature/web3/wallet/zcash, title:zcash, body:orchard

QA Pass-Win64 priority/P2 QA/Yes release-notes/exclude feature/web3/wallet OS/Desktop feature/web3/wallet/core feature/web3/wallet/zcash

Description Orchard notes amount value is uint32_t but should be uint64_t STR/Cases: Looks like some context/information can be found via https://github.com/brave/brave-core/pull/30332#issue-3273259948. Steps to reproduce - Actual result - Expected result - Reproduces how often Easily reproduced Brave version (brave://version info) - Channel information - [ ] release (stable) - [ ] beta - [ ] nightly Reproducibility - [ ] with Brave Shields disabled - [ ] with Brave Rewards…

Timeline (15 of 18 events)
  1. 2025-07-29 10:55 Label added OS/Desktop by cypt4
  2. 2025-07-29 11:29 Referenced by brave-core#30332 by cypt4
  3. 2025-07-29 13:56 Label added priority/P2 by cypt4
  4. 2025-08-01 14:54 Closed completed brave-core#30332 by cypt4
  5. 2025-08-01 14:54 Milestone set 1.83.x - Nightly by brave-builds
  6. 2025-08-01 15:10 Referenced by brave-core#30422 by brave-builds
  7. 2025-08-01 15:10 Referenced by brave-core#30423 by brave-builds
  8. 2025-08-01 15:47 Label added QA/Yes by kjozwiak
  9. 2025-08-04 15:56 Label added release-notes/exclude by LaurenWags
  10. 2025-08-04 17:28 Milestone removed 1.83.x - Nightly by brave-builds
  11. 2025-08-04 17:28 Milestone set 1.82.x - Beta by brave-builds
  12. 2025-08-04 17:29 Milestone removed 1.82.x - Beta by brave-builds
  13. 2025-08-04 17:29 Milestone set 1.81.x - Release by brave-builds
  14. 2025-08-05 13:24 Label added QA Pass-Win64 by srirambv
  15. 2025-10-02 10:44 Referenced by brave-browser#49840 by cypt4
Pull request

brave-core#30332 [ZCash] Change orchard notes amount type to uint64

State: merged 2025-08-01 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:orchard is:pr, search:shielded is:pr, search:zcash is:pr, search:zec is:pr · matched title:zcash, title:orchard

feature/web3/wallet feature/web3/wallet/core puLL-Merge

Resolves https://github.com/brave/brave-browser/issues/47994 TEST PLAN: Ideally transactions with a big amounts should be tested(t->t, t->s, s->s) - maybe just checking confirmation panel without confirmation itself. If not possible we just need to test with normal amounts.

Timeline (8 of 11 events)
  1. 2025-07-29 13:55 Ready for review by cypt4
  2. 2025-08-01 14:54 Merged master by cypt4
  3. 2025-08-01 14:54 Closed by cypt4
  4. 2025-08-01 14:54 Milestone set 1.83.x - Nightly by github-actions
  5. 2025-08-01 15:10 Referenced by brave-core#30422 by brave-builds
  6. 2025-08-01 15:10 Referenced by brave-core#30423 by brave-builds
  7. 2025-08-01 15:48 Referenced by brave-browser#47994 by kjozwiak
  8. 2025-10-08 18:30 Referenced by zcash/zips#1102 by shielded-nate
Uplift PR → 1.82.x

brave-core#30422 [ZCash] Change orchard notes amount type to uint64 (uplift to 1.82.x)

State: merged 2025-08-04 · created · closed · updated · discovered via search:orchard is:pr, search:zcash is:pr · matched title:zcash, title:orchard

feature/web3/wallet feature/web3/wallet/core

Uplift of #30332 Resolves https://github.com/brave/brave-browser/issues/47994 Pre-approval checklist: - [x] You have tested your change on Nightly. - [ ] This contains text which needs to be translated. - [ ] There are more than 7 days before the release. - [ ] I've notified folks in #l10n on Slack that translations are needed. - [x] The PR milestones match the branch they are landing to. Pre-merge checklist: - [x] You have checked CI and the builds, lint, and tests all…

Timeline (3 of 5 events)
  1. 2025-08-01 15:10 Milestone set 1.82.x - Beta by brave-builds
  2. 2025-08-04 17:28 Merged 1.82.x by LaurenWags
  3. 2025-08-04 17:28 Closed by LaurenWags
Uplift PR → 1.81.x

brave-core#30423 [ZCash] Change orchard notes amount type to uint64 (uplift to 1.81.x)

State: merged 2025-08-04 · created · closed · updated · discovered via search:orchard is:pr, search:zcash is:pr · matched title:zcash, title:orchard

feature/web3/wallet feature/web3/wallet/core

Uplift of #30332 Resolves https://github.com/brave/brave-browser/issues/47994 Pre-approval checklist: - [x] You have tested your change on Nightly. - [ ] This contains text which needs to be translated. - [ ] There are more than 7 days before the release. - [ ] I've notified folks in #l10n on Slack that translations are needed. - [x] The PR milestones match the branch they are landing to. Pre-merge checklist: - [x] You have checked CI and the builds, lint, and tests all…

Timeline (3 of 5 events)
  1. 2025-08-01 15:10 Milestone set 1.81.x - Release by brave-builds
  2. 2025-08-04 17:29 Merged 1.81.x by LaurenWags
  3. 2025-08-04 17:29 Closed by LaurenWags

Also mentioned by (not linked as fixes): brave-browser#49840