Zcash × Brave WalletPersonal project

Type to search. Use ↑ ↓ and Enter to open a result.

Browser crash when trying to send Zcash

In a Release build Bug Security & hardening

Lead item brave-browser#47965 · opened by srirambv · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#30338 merged 2025-07-29 into master by nuo-xu
    fix(wallet): Use correct BraveCore wallet api to add unapproved zcash tx
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Uplifts to release branches

Release notes

No platform changelog lists this item.

Validation

QA required (QA/Yes).

  • QA Pass-iPhone (iOS only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.81.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): iOS

Owner: nuo-xu · PR authors: nuo-xu, brave-builds

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...454d7ded: behind); later builds of the same history include it (brave-core#30338)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...454d7ded: behind); later builds of the same history include it (brave-core#30338)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...454d7ded: behind); later builds of the same history include it (brave-core#30338)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...454d7ded: behind); later builds of the same history include it (brave-core#30338)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...454d7ded: behind); later builds of the same history include it (brave-core#30338)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...454d7ded: behind); later builds of the same history include it (brave-core#30338)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...454d7ded: behind); later builds of the same history include it (brave-core#30338)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...454d7ded: behind); later builds of the same history include it (brave-core#30338)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...454d7ded: behind); later builds of the same history include it (brave-core#30338)

Members and their history

Issue

brave-browser#47965 Browser crash when trying to send Zcash

State: closed (completed) · created · closed · updated · discovered via search:zcash · matched title:zcash, body:zcash

crash release/blocking QA/Yes release-notes/exclude feature/web3/wallet OS/iOS QA Pass - iPhone

Description Browser crash when trying to send Zcash Steps to reproduce 1. Enable Zcash via flags 2. Initiate Send transaction between Zcash accounts 3. Enter amount and Tap on Send, Browser crashes Actual result Browser crash when trying to send Zcash Expected result No crash. Should be able to send Zcash Reproduces how often Easily reproduced Brave version Chromium | 1.81.122 Chromium: 139.0.7258.42 (Official Build) beta (64-bit) -- | -- Revision | 35e58fbb8ec2... OS | iOS…

Timeline (8 of 11 events)
  1. 2025-07-28 10:08 Label added QA/Yes by srirambv
  2. 2025-07-28 10:08 Label added release-notes/exclude by srirambv
  3. 2025-07-28 10:08 Label added OS/iOS by srirambv
  4. 2025-07-29 14:12 Milestone set 1.81.x - Beta by jamesmudgett
  5. 2025-07-29 15:28 Referenced by brave-core#30338 by nuo-xu
  6. 2025-07-29 17:36 Closed completed brave-core#30338 by nuo-xu
  7. 2025-07-29 17:40 Referenced by brave-core#30340 by brave-builds
  8. 2025-07-31 15:01 Label added QA Pass - iPhone by srirambv
Pull request

brave-core#30338 fix(wallet): Use correct BraveCore wallet api to add unapproved zcash tx

State: merged 2025-07-29 · created · closed · updated · discovered via search:zcash is:pr · matched title:zcash, body:zcash

CI/skip-android CI/skip-windows-x64 CI/skip-macos-arm64

Resolves https://github.com/brave/brave-browser/issues/47965 Crash is caused by using wrong api to send zcash tx after https://github.com/brave/brave-core/pull/28975 is merged. This PR uses the correct api to add unapproved zcash tx.

Timeline (4 of 9 events)
  1. 2025-07-29 17:36 Merged master by nuo-xu
  2. 2025-07-29 17:36 Closed by nuo-xu
  3. 2025-07-29 17:36 Milestone set 1.82.x - Nightly by github-actions
  4. 2025-07-29 17:40 Referenced by brave-core#30340 by brave-builds
Uplift PR → 1.81.x

brave-core#30340 fix(wallet): Use correct BraveCore wallet api to add unapproved zcash tx (uplift to 1.81.x)

State: merged 2025-07-30 · created · closed · updated · discovered via search:zcash is:pr · matched title:zcash

CI/skip-android CI/skip-windows-x64 CI/skip-macos-arm64

Uplift of #30338 Resolves https://github.com/brave/brave-browser/issues/47965 Pre-approval checklist: - [ ] You have tested your change on Nightly. - [ ] This contains text which needs to be translated. - [ ] There are more than 7 days before the release. - [ ] I've notified folks in #l10n on Slack that translations are needed. - [ ] The PR milestones match the branch they are landing to. Pre-merge checklist: - [ ] You have checked CI and the builds, lint, and tests all…

Timeline (3 of 8 events)
  1. 2025-07-29 17:40 Milestone set 1.81.x - Beta by brave-builds
  2. 2025-07-30 15:34 Merged 1.81.x by kjozwiak
  3. 2025-07-30 15:34 Closed by kjozwiak