Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

[msan] Uninitialised read with `Orchard*` structs

In a Release build Issue Shielded (Orchard) support

Lead item brave-browser#47823 · opened by cdesouza-chromium · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#30195 merged 2025-07-22 into master by cdesouza-chromium
    [msan] Fix uninitialised reads for `Orchard*` structs
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Uplifts to release branches

Release notes

No platform changelog lists this item.

Validation

Not QA-tested (QA/No).

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.80.x - Release #7

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: cdesouza-chromium · PR authors: cdesouza-chromium, brave-builds

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...92693c59: behind); later builds of the same history include it (brave-core#30195)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...92693c59: behind); later builds of the same history include it (brave-core#30195)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...92693c59: behind); later builds of the same history include it (brave-core#30195)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...92693c59: behind); later builds of the same history include it (brave-core#30195)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...92693c59: behind); later builds of the same history include it (brave-core#30195)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...92693c59: behind); later builds of the same history include it (brave-core#30195)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...92693c59: behind); later builds of the same history include it (brave-core#30195)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...92693c59: behind); later builds of the same history include it (brave-core#30195)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...92693c59: behind); later builds of the same history include it (brave-core#30195)

Members and their history

Issue

brave-browser#47823 [msan] Uninitialised read with `Orchard*` structs

State: closed (completed) · created · closed · updated · discovered via search:orchard wallet · matched title:orchard

QA/No dev-concern release-notes/exclude QA/Test-Plan-Specified feature/web3/wallet OS/Desktop feature/web3/wallet/core code-health

[code]

Timeline (13 of 17 events)
  1. 2025-07-22 14:43 Label added QA/No by cdesouza-chromium
  2. 2025-07-22 14:43 Label added release-notes/exclude by cdesouza-chromium
  3. 2025-07-22 14:43 Label added QA/Test-Plan-Specified by cdesouza-chromium
  4. 2025-07-22 14:43 Label added OS/Desktop by cdesouza-chromium
  5. 2025-07-22 15:21 Referenced by brave-core#30195 by cdesouza-chromium
  6. 2025-07-22 19:45 Closed completed brave-core#30195 by cdesouza-chromium
  7. 2025-07-22 19:45 Milestone set 1.82.x - Nightly by brave-builds
  8. 2025-07-22 20:08 Referenced by brave-core#30204 by brave-builds
  9. 2025-07-22 20:09 Referenced by brave-core#30205 by brave-builds
  10. 2025-07-22 23:38 Milestone removed 1.82.x - Nightly by brave-builds
  11. 2025-07-22 23:38 Milestone set 1.81.x - Beta by brave-builds
  12. 2025-07-22 23:38 Milestone removed 1.81.x - Beta by brave-builds
  13. 2025-07-22 23:38 Milestone set 1.80.x - Release #7 by brave-builds
Pull request

brave-core#30195 [msan] Fix uninitialised reads for `Orchard*` structs

State: merged 2025-07-22 · created · closed · updated · discovered via search:orchard is:pr · matched title:orchard

feature/web3/wallet feature/web3/wallet/core

There has been a few places where these structs are being instantiated but the arrays fields are being left uninitialised, which is leading to very complex cases of uninitialised reads. This change initialises all arrays to default values. Resolves https://github.com/brave/brave-browser/issues/47823

Timeline (5 of 7 events)
  1. 2025-07-22 19:45 Merged master by cdesouza-chromium
  2. 2025-07-22 19:45 Closed by cdesouza-chromium
  3. 2025-07-22 19:45 Milestone set 1.82.x - Nightly by github-actions
  4. 2025-07-22 20:08 Referenced by brave-core#30204 by brave-builds
  5. 2025-07-22 20:09 Referenced by brave-core#30205 by brave-builds
Uplift PR → 1.80.x

brave-core#30205 [msan] Fix uninitialised reads for `Orchard*` structs (uplift to 1.80.x)

State: merged 2025-07-22 · created · closed · updated · discovered via search:orchard is:pr · matched title:orchard

feature/web3/wallet feature/web3/wallet/core

Uplift of #30195 Resolves https://github.com/brave/brave-browser/issues/47823 Pre-approval checklist: - [ ] You have tested your change on Nightly. - [ ] This contains text which needs to be translated. - [ ] There are more than 7 days before the release. - [ ] I've notified folks in #l10n on Slack that translations are needed. - [x] The PR milestones match the branch they are landing to. Pre-merge checklist: - [x] You have checked CI and the builds, lint, and tests all…

Timeline (3 of 5 events)
  1. 2025-07-22 20:09 Milestone set 1.80.x - Release #7 by brave-builds
  2. 2025-07-22 23:38 Merged 1.80.x by kjozwiak
  3. 2025-07-22 23:38 Closed by kjozwiak
Uplift PR → 1.81.x

brave-core#30204 [msan] Fix uninitialised reads for `Orchard*` structs (uplift to 1.81.x)

State: merged 2025-07-22 · created · closed · updated · discovered via search:orchard is:pr · matched title:orchard

feature/web3/wallet feature/web3/wallet/core

Uplift of #30195 Resolves https://github.com/brave/brave-browser/issues/47823 Pre-approval checklist: - [ ] You have tested your change on Nightly. - [ ] This contains text which needs to be translated. - [ ] There are more than 7 days before the release. - [ ] I've notified folks in #l10n on Slack that translations are needed. - [x] The PR milestones match the branch they are landing to. Pre-merge checklist: - [x] You have checked CI and the builds, lint, and tests all…

Timeline (3 of 5 events)
  1. 2025-07-22 20:08 Milestone set 1.81.x - Beta by brave-builds
  2. 2025-07-22 23:38 Merged 1.81.x by kjozwiak
  3. 2025-07-22 23:38 Closed by kjozwiak