Zcash × Brave WalletPersonal project

Type to search. Use ↑ ↓ and Enter to open a result.

Cleanup wallet's unit_tests

In a Release build Issue Testnet, tests & tooling

Lead item brave-browser#47671 · opened by supermassive · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#30072 merged 2025-07-16 into master by supermassive
    Fix wallet's tests depending on content
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

No platform changelog lists this item.

Validation

Not QA-tested (QA/No).

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.82.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: supermassive · PR authors: supermassive

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...826aff93: behind); later builds of the same history include it (brave-core#30072)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...826aff93: behind); later builds of the same history include it (brave-core#30072)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...826aff93: behind); later builds of the same history include it (brave-core#30072)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...826aff93: behind); later builds of the same history include it (brave-core#30072)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...826aff93: behind); later builds of the same history include it (brave-core#30072)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...826aff93: behind); later builds of the same history include it (brave-core#30072)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...826aff93: behind); later builds of the same history include it (brave-core#30072)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...826aff93: behind); later builds of the same history include it (brave-core#30072)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...826aff93: behind); later builds of the same history include it (brave-core#30072)

Members and their history

Issue

brave-browser#47671 Cleanup wallet's unit_tests

State: closed (completed) · created · closed · updated · discovered via linked:brave/brave-core#30072

QA/No dev-concern release-notes/exclude feature/web3/wallet OS/Desktop feature/web3/wallet/core

Description - Restrict dependencies on content - !is_ios -> use_blink - Fix test-only deps being copied to out folder

Timeline (6 of 9 events)
  1. 2025-07-16 07:55 Referenced by brave-core#30072 by supermassive
  2. 2025-07-16 14:40 Closed completed brave-core#30072 by supermassive
  3. 2025-07-16 14:40 Milestone set 1.82.x - Nightly by brave-builds
  4. 2025-07-16 16:20 Label added QA/No by supermassive
  5. 2025-07-16 16:20 Label added release-notes/exclude by supermassive
  6. 2025-07-16 16:20 Label added OS/Desktop by supermassive
Pull request

brave-core#30072 Fix wallet's tests depending on content

State: merged 2025-07-16 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash

feature/web3/wallet feature/web3/wallet/core

Resolves https://github.com/brave/brave-browser/issues/47671 https://github.com/brave/brave-core/pull/29603/files/b44a3857fe7faac6c4d580ac5ab14a5ec2aa1fb9#r2208964068 - Restrict dependencies on content - !is_ios -> use_blink - Fix test-only deps being copied to out folder

Timeline (6 of 8 events)
  1. 2025-07-16 07:56 Ready for review by supermassive
  2. 2025-07-16 09:47 Referenced by brave-core#29992 by supermassive
  3. 2025-07-16 14:40 Merged master by supermassive
  4. 2025-07-16 14:40 Closed by supermassive
  5. 2025-07-16 14:40 Milestone set 1.82.x - Nightly by github-actions
  6. 2025-07-17 07:29 Referenced by brave-core#29603 by supermassive