Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

[Polkadot] Add sr25519 crate dependency and basic methods

In a Release build Task Dependencies & Rust crates

Lead item brave-browser#47369 · opened by cypt4 · last source update

Issue state

Closed (completed)

Closed . GitHub type: Task.

Implementation

  • brave-core#30162 merged 2025-07-25 into master by cmazakas
    add schnorrkel v0.11.4 crate
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description
  • brave-core#29995 merged 2025-08-04 into master by cmazakas
    Sr25519 support
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

No platform changelog lists this item.

Validation

Not QA-tested (QA/No).

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.82.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: cmazakas · PR authors: cmazakas

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...8c4a3f33: behind); later builds of the same history include it (brave-core#30162)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...8c4a3f33: behind); later builds of the same history include it (brave-core#30162)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...8c4a3f33: behind); later builds of the same history include it (brave-core#30162)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...8c4a3f33: behind); later builds of the same history include it (brave-core#30162)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...8c4a3f33: behind); later builds of the same history include it (brave-core#30162)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...8c4a3f33: behind); later builds of the same history include it (brave-core#30162)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...8c4a3f33: behind); later builds of the same history include it (brave-core#30162)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...8c4a3f33: behind); later builds of the same history include it (brave-core#30162)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...8c4a3f33: behind); later builds of the same history include it (brave-core#30162)

Members and their history

Issue

brave-browser#47369 [Polkadot] Add sr25519 crate dependency and basic methods

State: closed (completed) · created · closed · updated · discovered via search:zcash · matched body:zcash

QA/No release-notes/exclude feature/web3/wallet OS/Desktop feature/web3/wallet/core feature/web3/polkadot

Description Dependency review has been passed here [GitHub link omitted] Reference integration: https://github.com/brave/brave-core/pull/28781 1) Add sr25519 crate to the browser dependencies. 2) Add brave/components/brave_wallet/internal/polkadot component with basic wrapper methods to work with the crate. Reference implementation - [GitHub link omitted] Should be similar to the Zcash implementation with basic methods like CreateMasterKey, DeriveChild, GetPublicKey etc..…

Timeline (9 of 12 events)
  1. 2025-07-03 10:53 Label added OS/Desktop by cypt4
  2. 2025-07-10 17:45 Referenced by brave-core#29995 by cmazakas
  3. 2025-07-21 19:05 Referenced by brave-core#30162 by cmazakas
  4. 2025-07-25 22:44 Closed completed brave-core#30162 by cmazakas
  5. 2025-07-25 22:44 Milestone set 1.82.x - Nightly by brave-builds
  6. 2025-07-28 14:29 Reopened by cmazakas
  7. 2025-08-04 19:45 Closed completed brave-core#29995 by cmazakas
  8. 2025-08-05 15:21 Label added release-notes/exclude by rebron
  9. 2025-08-05 15:21 Label added QA/No by rebron
Pull request

brave-core#30162 add schnorrkel v0.11.4 crate

State: merged 2025-07-25 · created · closed · updated · discovered via linked:brave/brave-browser#47369

CI/run-audit-deps feature/web3/wallet feature/web3/wallet/core

Add a dependency to the schnorrkel crate, which provides primitives we'll need for Polkadot. Resolves https://github.com/brave/brave-browser/issues/47369

Timeline (4 of 7 events)
  1. 2025-07-21 19:06 Referenced by brave-core#29995 by cmazakas
  2. 2025-07-25 22:44 Merged master by cmazakas
  3. 2025-07-25 22:44 Closed by cmazakas
  4. 2025-07-25 22:44 Milestone set 1.82.x - Nightly by github-actions
Pull request

brave-core#29995 Sr25519 support

State: merged 2025-08-04 · created · closed · updated · discovered via linked:brave/brave-browser#47369

CI/run-audit-deps feature/web3/wallet feature/web3/wallet/core

Add impl of HDKeySr25519, introducing a dependency on the schnorrkel crate. We introduce a patch that manually applies the LICENSE file to the getrandom_or_panic crate, which seems to be missing from this version of the dependency. Resolves https://github.com/brave/brave-browser/issues/47369

Timeline (4 of 9 events)
  1. 2025-07-21 18:25 Ready for review by cmazakas
  2. 2025-08-04 19:45 Merged master by cmazakas
  3. 2025-08-04 19:45 Closed by cmazakas
  4. 2025-08-04 19:45 Milestone set 1.83.x - Nightly by github-actions