Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Fix IWYU for `LOG`, `CHECK` and associated macros

In a Release build Issue Testnet, tests & tooling

Lead item brave-browser#46707 · opened by cdesouza-chromium · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#29489 merged 2025-06-10 into master by cdesouza-chromium
    [IWYU] Fixing logging inclusions for Wallet
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

No platform changelog lists this item.

Validation

Not QA-tested (QA/No).

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.81.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: cdesouza-chromium · PR authors: cdesouza-chromium

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...079e20b1: behind); later builds of the same history include it (brave-core#29489)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...079e20b1: behind); later builds of the same history include it (brave-core#29489)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...079e20b1: behind); later builds of the same history include it (brave-core#29489)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...079e20b1: behind); later builds of the same history include it (brave-core#29489)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...079e20b1: behind); later builds of the same history include it (brave-core#29489)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...079e20b1: behind); later builds of the same history include it (brave-core#29489)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...079e20b1: behind); later builds of the same history include it (brave-core#29489)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...079e20b1: behind); later builds of the same history include it (brave-core#29489)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...079e20b1: behind); later builds of the same history include it (brave-core#29489)

Members and their history

Issue

brave-browser#46707 Fix IWYU for `LOG`, `CHECK` and associated macros

State: closed (completed) · created · closed · updated · discovered via linked:brave/brave-core#29489

QA/No dev-concern release-notes/exclude QA/Test-Plan-Specified feature/web3/wallet OS/Desktop feature/web3/wallet/core code-health

There are a couple of macros that are used for sanity check from base. These macros are spread across multiple headers. We should correct their inclusions across the codebase.

Timeline (17 of 21 events)
  1. 2025-06-10 17:38 Label added QA/No by cdesouza-chromium
  2. 2025-06-10 17:38 Label added release-notes/exclude by cdesouza-chromium
  3. 2025-06-10 17:38 Label added QA/Test-Plan-Specified by cdesouza-chromium
  4. 2025-06-10 17:38 Label added OS/Desktop by cdesouza-chromium
  5. 2025-06-10 17:47 Referenced by brave-core#29488 by cdesouza-chromium
  6. 2025-06-10 18:14 Referenced by brave-core#29489 by cdesouza-chromium
  7. 2025-06-10 19:37 Referenced by brave-core#29496 by cdesouza-chromium
  8. 2025-06-10 20:22 Closed completed brave-core#29488 by cdesouza-chromium
  9. 2025-06-10 20:22 Milestone set 1.81.x - Nightly by brave-builds
  10. 2025-06-10 21:31 Referenced by brave-core#29503 by cdesouza-chromium
  11. 2025-06-10 21:45 Referenced by brave-core#29504 by cdesouza-chromium
  12. 2025-06-11 11:32 Referenced by brave-core#29511 by cdesouza-chromium
  13. 2025-06-11 11:35 Referenced by brave-core#29512 by cdesouza-chromium
  14. 2025-06-11 11:43 Referenced by brave-core#29513 by cdesouza-chromium
  15. 2025-06-11 20:14 Referenced by brave-core#29529 by cdesouza-chromium
  16. 2025-06-11 20:24 Referenced by brave-core#29530 by cdesouza-chromium
  17. 2025-06-11 20:26 Referenced by brave-core#29531 by cdesouza-chromium
Pull request

brave-core#29489 [IWYU] Fixing logging inclusions for Wallet

State: merged 2025-06-10 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:zcash is:pr

feature/web3/wallet feature/web3/wallet/core puLL-Merge

This change is one of many fixing inclusion for the following files: - base/notimplemented.h - base/notreached.h - base/check.h - base/dcheck_is_on.h - base/check_deref.h - base/check_op.h - base/logging/log_severity.h - base/logging.h This change is a mechanical change done with the following script: https://github.com/brave/brave-browser/issues/46707#issuecomment-2960116515 Resolves https://github.com/brave/brave-browser/issues/46707

Timeline (3 of 6 events)
  1. 2025-06-10 21:03 Merged master by cdesouza-chromium
  2. 2025-06-10 21:03 Closed by cdesouza-chromium
  3. 2025-06-10 21:04 Milestone set 1.81.x - Nightly by github-actions