Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Display a "Shield account" button on transparent accounts when no shielded account exists

In release notes Issue Shielded (Orchard) support

Lead item brave-browser#46598 · opened by jamesmudgett · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#29429 merged 2025-06-06 into master by Douglashdaniel
    feat(wallet): Add Shield Account Alert to Account Details
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

  • Desktop 1.81.131: “Added a "Shield Account" alert on the "Account Details" panel for Zcash accounts. (#46598)” changelog line
  • Android 1.81.131: “Added a "Shield Account" alert on the "Account Details" panel for Zcash accounts. (#46598)” changelog line

Release notes are per platform. Lines come from each platform’s Stable changelog. A platform without an entry is not covered by these lines.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)
  • QA Pass-Android ARM (Android only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.81.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Android, Desktop

Owner: Douglashdaniel · PR authors: Douglashdaniel

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...1d0a11e1: behind); later builds of the same history include it (brave-core#29429)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...1d0a11e1: behind); later builds of the same history include it (brave-core#29429)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...1d0a11e1: behind); later builds of the same history include it (brave-core#29429)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...1d0a11e1: behind); later builds of the same history include it (brave-core#29429)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...1d0a11e1: behind); later builds of the same history include it (brave-core#29429)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...1d0a11e1: behind); later builds of the same history include it (brave-core#29429)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...1d0a11e1: behind); later builds of the same history include it (brave-core#29429)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...1d0a11e1: behind); later builds of the same history include it (brave-core#29429)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...1d0a11e1: behind); later builds of the same history include it (brave-core#29429)

Members and their history

Issue

brave-browser#46598 Display a "Shield account" button on transparent accounts when no shielded account exists

State: closed (completed) · created · closed · updated · discovered via label:feature/web3/wallet/zcash, search:shielded wallet · matched label:feature/web3/wallet/zcash, title:shielded, body:shielded

QA Pass-Win64 priority/P3 QA/Yes release-notes/include feature/web3/wallet OS/Android QA Pass - Android ARM OS/Desktop front-end-change feature/web3/wallet/core feature/web3/wallet/zcash

[image] [image] This should be controlled by the front-end code to display a shield account button when no shielded accounts exist (given 1 shielded account limit). The goal is to make shielding an account more obvious. Additionally the design to sync the shielded account should be updated to match the above example.

Timeline (12 of 16 events)
  1. 2025-06-05 16:53 Label added priority/P3 by jamesmudgett
  2. 2025-06-06 00:39 Referenced by brave-core#29429 by Douglashdaniel
  3. 2025-06-06 00:40 Label added QA/Yes by Douglashdaniel
  4. 2025-06-06 00:40 Label added release-notes/include by Douglashdaniel
  5. 2025-06-06 00:40 Label added OS/Android by Douglashdaniel
  6. 2025-06-06 00:40 Label added OS/Desktop by Douglashdaniel
  7. 2025-06-06 17:12 Closed completed brave-core#29429 by Douglashdaniel
  8. 2025-06-06 17:12 Milestone set 1.81.x - Nightly by brave-builds
  9. 2025-06-25 10:08 Label added QA Pass-Win64 by srirambv
  10. 2025-06-25 10:14 Label added QA Pass - Android ARM by srirambv
  11. 2025-08-05 00:45 Referenced by brave-browser#48160 by hffvld
  12. 2025-08-05 13:08 Referenced by brave-browser#48168 by LaurenWags
Pull request

brave-core#29429 feat(wallet): Add Shield Account Alert to Account Details

State: merged 2025-06-06 · created · closed · updated · discovered via search:zcash is:pr · matched body:zcash

CI/storybook-url feature/web3/wallet feature/web3/wallet/core

Description Will now display a Shield Account alert on the Account Details screen if you are able to shield a Zcash account Resolves Test Plan: 1. Create a brand new profile and wallet 2. Navigate to the Accounts screen and open you Zcash account details 3. You should see the Shield Account alert at the top of the page 4. Click Shield Account and the Shield Account Modal should popup 5. Shield your account and the Modal and Alert should both disapear 6. Ensure that your…

Timeline (4 of 7 events)
  1. 2025-06-06 17:12 Merged master by Douglashdaniel
  2. 2025-06-06 17:12 Closed by Douglashdaniel
  3. 2025-06-06 17:12 Milestone set 1.81.x - Nightly by github-actions
  4. 2025-06-25 10:08 Referenced by brave-browser#46598 by srirambv