Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Fix IWYU for `base/strings/string_number_conversions.h`

In a Release build Issue Testnet, tests & tooling

Lead item brave-browser#46382 · opened by cdesouza-chromium · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#29269 merged 2025-05-28 into master by cdesouza-chromium
    [iwyu] Fixing inclusions for `string_number_conversions.h`
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

No platform changelog lists this item.

Validation

Not QA-tested (QA/No).

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.81.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: cdesouza-chromium · PR authors: cdesouza-chromium

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...feb56e3c: behind); later builds of the same history include it (brave-core#29269)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...feb56e3c: behind); later builds of the same history include it (brave-core#29269)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...feb56e3c: behind); later builds of the same history include it (brave-core#29269)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...feb56e3c: behind); later builds of the same history include it (brave-core#29269)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...feb56e3c: behind); later builds of the same history include it (brave-core#29269)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...feb56e3c: behind); later builds of the same history include it (brave-core#29269)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...feb56e3c: behind); later builds of the same history include it (brave-core#29269)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...feb56e3c: behind); later builds of the same history include it (brave-core#29269)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...feb56e3c: behind); later builds of the same history include it (brave-core#29269)

Members and their history

Issue

brave-browser#46382 Fix IWYU for `base/strings/string_number_conversions.h`

State: closed (completed) · created · closed · updated · discovered via linked:brave/brave-core#29269

QA/No dev-concern release-notes/exclude QA/Test-Plan-Specified feature/web3/wallet OS/Desktop feature/web3/wallet/core code-health

There are many places in our codebase where we are relying no transient inclusions for this header.

Timeline (7 of 11 events)
  1. 2025-05-27 21:06 Label added QA/No by cdesouza-chromium
  2. 2025-05-27 21:06 Label added release-notes/exclude by cdesouza-chromium
  3. 2025-05-27 21:06 Label added QA/Test-Plan-Specified by cdesouza-chromium
  4. 2025-05-27 21:06 Label added OS/Desktop by cdesouza-chromium
  5. 2025-05-27 21:11 Referenced by brave-core#29269 by cdesouza-chromium
  6. 2025-05-28 20:12 Closed completed brave-core#29269 by cdesouza-chromium
  7. 2025-05-28 20:13 Milestone set 1.81.x - Nightly by brave-builds
Pull request

brave-core#29269 [iwyu] Fixing inclusions for `string_number_conversions.h`

State: merged 2025-05-28 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash

CI/run-network-audit feature/web3/wallet feature/web3/wallet/core puLL-Merge

Files that use base::NumberToString() and friends should include string_number_conversions.h directly instead of depending on transitive includes from far away. This is a mechanical change done with the following script. [code] Resolves https://github.com/brave/brave-browser/issues/46382

Timeline (3 of 7 events)
  1. 2025-05-28 20:12 Merged master by cdesouza-chromium
  2. 2025-05-28 20:12 Closed by cdesouza-chromium
  3. 2025-05-28 20:12 Milestone set 1.81.x - Nightly by github-actions