Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Hide Edit Gas Buttons for Zcash Transactions

In release notes Bug Transactions & fees

Lead item brave-browser#45748 · opened by Douglashdaniel · last source update

Issue state

Closed (completed)

Closed . GitHub type: Bug.

Implementation

  • brave-core#28872 merged 2025-04-29 into master by Douglashdaniel
    fix(wallet): Hide Edit Gas Buttons for Zcash Transactions
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

  • Desktop 1.80.113: “Removed the "Edit" gas button for Zcash transactions. (#45748)” changelog line

Release notes are per platform. Lines come from each platform’s Stable changelog. A platform without an entry is not covered by these lines.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.80.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: Douglashdaniel · PR authors: Douglashdaniel

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...4b26e49a: behind); later builds of the same history include it (brave-core#28872)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...4b26e49a: behind); later builds of the same history include it (brave-core#28872)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...4b26e49a: behind); later builds of the same history include it (brave-core#28872)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...4b26e49a: behind); later builds of the same history include it (brave-core#28872)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...4b26e49a: behind); later builds of the same history include it (brave-core#28872)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...4b26e49a: behind); later builds of the same history include it (brave-core#28872)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...4b26e49a: behind); later builds of the same history include it (brave-core#28872)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...4b26e49a: behind); later builds of the same history include it (brave-core#28872)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...4b26e49a: behind); later builds of the same history include it (brave-core#28872)

Members and their history

Issue

brave-browser#45748 Hide Edit Gas Buttons for Zcash Transactions

State: closed (completed) · created · closed · updated · discovered via search:zcash · matched title:zcash, body:zcash

bug QA Pass-Win64 QA/Yes release-notes/include feature/web3/wallet OS/Desktop front-end-change

Description Currently when you are previewing a Zcash transaction to submit, there are Edit gas buttons displayed in the information. It is not possible to Edit gas for Zcash Steps to reproduce 1. Open the Wallet and navigate to the Send screen 2. Create a Zcash transaction and wait for the Confirmation panel to show up 3. You will see the Edit gas buttons. Actual result [image] Expected result There should not be any Edit gas buttons for Zcash transactions [image]…

Timeline (8 of 11 events)
  1. 2025-04-28 20:32 Label added OS/Desktop by Douglashdaniel
  2. 2025-04-28 20:32 Label added QA/Yes by Douglashdaniel
  3. 2025-04-28 20:32 Label added release-notes/include by Douglashdaniel
  4. 2025-04-28 20:36 Referenced by brave-core#28872 by Douglashdaniel
  5. 2025-04-29 13:33 Closed completed brave-core#28872 by Douglashdaniel
  6. 2025-04-29 13:34 Milestone set 1.80.x - Nightly by brave-builds
  7. 2025-06-06 11:49 Label added QA Pass-Win64 by srirambv
  8. 2025-06-25 12:30 Referenced by brave-browser#47103 by LaurenWags
Pull request

brave-core#28872 fix(wallet): Hide Edit Gas Buttons for Zcash Transactions

State: merged 2025-04-29 · created · closed · updated · discovered via search:zcash is:pr · matched title:zcash, body:zcash

CI/storybook-url feature/web3/wallet

Description Hides the Edit Gas buttons in the Confirm Transaction panels for Zcash transactions. Resolves Test Plan: 1. Open the Wallet and navigate to the Send screen 2. Create a Zcash transaction and wait for the Confirmation panel to show up 3. You should not see the Edit gas buttons. Before: [image] After: [image]

Timeline (4 of 6 events)
  1. 2025-04-29 13:33 Merged master by Douglashdaniel
  2. 2025-04-29 13:33 Closed by Douglashdaniel
  3. 2025-04-29 13:34 Milestone set 1.80.x - Nightly by github-actions
  4. 2025-06-06 11:49 Referenced by brave-browser#45748 by srirambv