Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Remove the use of `std::list<std::pair<>>` from `CardanoWalletService`

In a Release build Issue Testnet, tests & tooling

Lead item brave-browser#45527 · opened by cdesouza-chromium · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#28772 merged 2025-04-28 into master by supermassive
    Refactor wallet tasks
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

No platform changelog lists this item.

Validation

Not QA-tested (QA/No).

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.80.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: supermassive, cdesouza-chromium · PR authors: supermassive

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...8a397e51: behind); later builds of the same history include it (brave-core#28772)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...8a397e51: behind); later builds of the same history include it (brave-core#28772)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...8a397e51: behind); later builds of the same history include it (brave-core#28772)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...8a397e51: behind); later builds of the same history include it (brave-core#28772)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...8a397e51: behind); later builds of the same history include it (brave-core#28772)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...8a397e51: behind); later builds of the same history include it (brave-core#28772)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...8a397e51: behind); later builds of the same history include it (brave-core#28772)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...8a397e51: behind); later builds of the same history include it (brave-core#28772)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...8a397e51: behind); later builds of the same history include it (brave-core#28772)

Members and their history

Issue

brave-browser#45527 Remove the use of `std::list<std::pair<>>` from `CardanoWalletService`

State: closed (completed) · created · closed · updated · discovered via linked:brave/brave-core#28772

priority/P4 QA/No dev-concern release-notes/exclude QA/Test-Plan-Specified feature/web3/wallet OS/Desktop feature/web3/wallet/core

The use of something like absl::flat_hash_map , GetUtxosCallback, base::UniquePtrComparator> is more natural, as we are using it for for association. It can be either flat_hash_map or flat_hash_node as both are performant enough to replace the linked list.

Timeline (8 of 11 events)
  1. 2025-04-17 13:37 Label added OS/Desktop by cdesouza-chromium
  2. 2025-04-17 13:37 Label added QA/No by cdesouza-chromium
  3. 2025-04-17 13:37 Label added QA/Test-Plan-Specified by cdesouza-chromium
  4. 2025-04-17 13:37 Label added release-notes/exclude by cdesouza-chromium
  5. 2025-04-23 09:02 Referenced by brave-core#28772 by supermassive
  6. 2025-04-23 17:10 Label added priority/P4 by jamesmudgett
  7. 2025-04-28 04:39 Closed completed brave-core#28772 by supermassive
  8. 2025-04-28 04:39 Milestone set 1.80.x - Nightly by brave-builds
Pull request

brave-core#28772 Refactor wallet tasks

State: merged 2025-04-28 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:zcash is:pr · matched body:zcash

feature/web3/wallet feature/web3/wallet/core puLL-Merge

Unify Task classes for Bitcoin Zcash and Cardano coins: - Start() accepts a callback. That's the only outcome of a task execution(no more calls like CreateTransactionTaskDone) - Use absl::flat_hash_set as a task container - No RefCountedThreadSafe for Task classes, all of them are owned by corresponding services. Resolves https://github.com/brave/brave-browser/issues/45527

Timeline (4 of 7 events)
  1. 2025-04-23 09:07 Ready for review by supermassive
  2. 2025-04-28 04:39 Merged master by supermassive
  3. 2025-04-28 04:39 Closed by supermassive
  4. 2025-04-28 04:39 Milestone set 1.80.x - Nightly by github-actions