Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

Review send screen doesn't show any transaction details

In a Release build Bug Transactions & fees

Lead item brave-browser#45523 · opened by srirambv · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#28883 merged 2025-05-07 into master by simoarpe
    (Wallet) Implement ZCash support on Android Wallet
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

No platform changelog lists this item.

Validation

QA required (QA/Yes).

  • QA Pass-Android ARM (Android only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.80.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Android

Owner: simoarpe · PR authors: simoarpe

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...7850105d: behind); later builds of the same history include it (brave-core#28883)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...7850105d: behind); later builds of the same history include it (brave-core#28883)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...7850105d: behind); later builds of the same history include it (brave-core#28883)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...7850105d: behind); later builds of the same history include it (brave-core#28883)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...7850105d: behind); later builds of the same history include it (brave-core#28883)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...7850105d: behind); later builds of the same history include it (brave-core#28883)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...7850105d: behind); later builds of the same history include it (brave-core#28883)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...7850105d: behind); later builds of the same history include it (brave-core#28883)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...7850105d: behind); later builds of the same history include it (brave-core#28883)

Members and their history

Issue

brave-browser#45523 Review send screen doesn't show any transaction details

State: closed (completed) · created · closed · updated · discovered via label:feature/web3/wallet/zcash, search:zcash · matched label:feature/web3/wallet/zcash, body:zcash

bug priority/P3 QA/Yes release-notes/exclude feature/web3/wallet OS/Android QA Pass - Android ARM feature/web3/wallet/zcash

Description Review send screen doesn't show any transaction details Steps to reproduce 1. Submit a Send transaction from Zcash account 2. Wait for transaction review to show up 3. No details are shown Actual result [GitHub link omitted] Expected result Should show the transaction details Reproduces how often Easily reproduced Brave version 1.79.24 Device - Brand/model: Google Pixel 8 - Android version: 15 Channel information - [ ] release (stable) - [ ] beta - [x] nightly…

Timeline (8 of 12 events)
  1. 2025-04-17 11:10 Label added OS/Android by srirambv
  2. 2025-04-17 11:10 Label added QA/Yes by srirambv
  3. 2025-04-17 11:10 Label added release-notes/exclude by srirambv
  4. 2025-04-21 15:10 Label added priority/P3 by jamesmudgett
  5. 2025-04-29 15:42 Referenced by brave-core#28883 by simoarpe
  6. 2025-05-07 18:01 Closed completed brave-core#28883 by simoarpe
  7. 2025-05-07 18:01 Milestone set 1.80.x - Nightly by brave-builds
  8. 2025-06-09 12:17 Label added QA Pass - Android ARM by srirambv
Pull request

brave-core#28883 (Wallet) Implement ZCash support on Android Wallet

State: merged 2025-05-07 · created · closed · updated · discovered via search:shielded is:pr, search:zcash is:pr, search:zec is:pr · matched title:zcash, body:zcash

CI/skip-ios feature/web3/wallet CI/skip-windows-x64 puLL-Merge CI/skip-macos-arm64

Resolves https://github.com/brave/brave-browser/issues/45523 Related issue: https://github.com/brave/brave-browser/issues/45776 👆 Note: The issue above was created as a follow up for not clogging the current PR that has already increased quite substiantially beacuse of the NullAway transition that forced me to refactor the code. The warnings that still need to be addressed are less severe and are about long lines and class fields not starting with m char. This PR includes…

Timeline (4 of 10 events)
  1. 2025-04-30 08:38 Referenced by brave-browser#45776 by simoarpe
  2. 2025-05-07 18:01 Merged master by simoarpe
  3. 2025-05-07 18:01 Closed by simoarpe
  4. 2025-05-07 18:01 Milestone set 1.80.x - Nightly by github-actions