Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

[Wallet] keyring service fires accounts changed event even when there is no actual change for Zcash accounts

In a Release build Issue Addresses, accounts & memos

Lead item brave-browser#45197 · opened by nuo-xu · last source update

Issue state

Closed (completed)

Closed .

Implementation

  • brave-core#28513 merged 2025-04-08 into master by nuo-xu
    fix(wallet): Not firing AccountsChanged() observer event when there is no the next unused address changed for Zcash accounts.
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description

Release notes

No platform changelog lists this item.

Validation

Not QA-tested (QA/No).

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.79.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Android, Desktop, iOS

Owner: nuo-xu · PR authors: nuo-xu

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...577eee87: behind); later builds of the same history include it (brave-core#28513)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...577eee87: behind); later builds of the same history include it (brave-core#28513)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...577eee87: behind); later builds of the same history include it (brave-core#28513)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...577eee87: behind); later builds of the same history include it (brave-core#28513)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...577eee87: behind); later builds of the same history include it (brave-core#28513)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...577eee87: behind); later builds of the same history include it (brave-core#28513)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...577eee87: behind); later builds of the same history include it (brave-core#28513)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...577eee87: behind); later builds of the same history include it (brave-core#28513)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...577eee87: behind); later builds of the same history include it (brave-core#28513)

Members and their history

Issue

brave-browser#45197 [Wallet] keyring service fires accounts changed event even when there is no actual change for Zcash accounts

State: closed (completed) · created · closed · updated · discovered via label:feature/web3/wallet/zcash, search:zcash · matched label:feature/web3/wallet/zcash, title:zcash

QA/No release-notes/exclude feature/web3/wallet OS/Android OS/Desktop OS/iOS feature/web3/wallet/core feature/web3/wallet/zcash

https://github.com/brave/brave-core/blob/888ed4e62bf254220035969e0222dc3068145a38/components/brave_wallet/browser/keyring_service.cc#L2621 We should check if next_receive_index/next_change_index are actually different than account.bitcoin_next_receive_address_index/account.bitcoin_next_change_address_index before calling NotifyAccountsChanged()

Timeline (8 of 11 events)
  1. 2025-04-04 21:41 Referenced by brave-core#28513 by nuo-xu
  2. 2025-04-08 14:57 Closed completed brave-core#28513 by nuo-xu
  3. 2025-04-08 14:58 Milestone set 1.79.x - Nightly by brave-builds
  4. 2025-04-11 13:59 Label added QA/No by nuo-xu
  5. 2025-04-11 13:59 Label added release-notes/exclude by nuo-xu
  6. 2025-05-05 14:20 Label added OS/Android by nuo-xu
  7. 2025-05-05 14:20 Label added OS/Desktop by nuo-xu
  8. 2025-05-05 14:20 Label added OS/iOS by nuo-xu
Pull request

brave-core#28513 fix(wallet): Not firing AccountsChanged() observer event when there is no the next unused address changed for Zcash accounts.

State: merged 2025-04-08 · created · closed · updated · discovered via search:zcash is:pr · matched title:zcash

feature/web3/wallet feature/web3/wallet/core

Resolves https://github.com/brave/brave-browser/issues/45197

Timeline (3 of 5 events)
  1. 2025-04-08 14:57 Merged master by nuo-xu
  2. 2025-04-08 14:57 Closed by nuo-xu
  3. 2025-04-08 14:58 Milestone set 1.79.x - Nightly by github-actions