Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

[Polkadot] ss58 address space support

In a Release build Task Addresses, accounts & memos

Lead item brave-browser#44748 · opened by cypt4 · last source update

Issue state

Closed (completed)

Closed . GitHub type: Task.

Implementation

  • brave-core#28880 merged 2025-05-09 into master by cypt4
    [Polkadot] Ss58 support
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description, branch name brave_44748 (weaker evidence; titles share a keyword)

Release notes

No platform changelog lists this item.

Validation

No QA label.

No QA pass labels.

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

No milestone set.

Platforms (OS labels): Desktop

Owner: cypt4 · PR authors: cypt4

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...b1928696: behind); later builds of the same history include it (brave-core#28880)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...b1928696: behind); later builds of the same history include it (brave-core#28880)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...b1928696: behind); later builds of the same history include it (brave-core#28880)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...b1928696: behind); later builds of the same history include it (brave-core#28880)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...b1928696: behind); later builds of the same history include it (brave-core#28880)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...b1928696: behind); later builds of the same history include it (brave-core#28880)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...b1928696: behind); later builds of the same history include it (brave-core#28880)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...b1928696: behind); later builds of the same history include it (brave-core#28880)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...b1928696: behind); later builds of the same history include it (brave-core#28880)

Members and their history

Issue

brave-browser#44748 [Polkadot] ss58 address space support

State: closed (completed) · created · closed · updated · discovered via linked:brave/brave-core#28880

feature/web3/wallet OS/Desktop feature/web3/polkadot

Description Support of generating ss58 addresses Steps to reproduce - Actual result - Expected result - Reproduces how often Easily reproduced Brave version (brave://version info) - Channel information - [ ] release (stable) - [ ] beta - [ ] nightly Reproducibility - [ ] with Brave Shields disabled - [ ] with Brave Rewards disabled - [ ] in the latest version of Chrome Miscellaneous information _No response_

Timeline (3 of 5 events)
  1. 2025-03-18 15:49 Label added OS/Desktop by cypt4
  2. 2025-05-09 13:30 Closed completed by cypt4
  3. 2025-12-15 15:45 Referenced by brave-core#28880 by cypt4
Pull request

brave-core#28880 [Polkadot] Ss58 support

State: merged 2025-05-09 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash

feature/web3/wallet feature/web3/wallet/core

Resolves https://github.com/brave/brave-browser/issues/44748 Implements ss58 address encoding as in the reference impl : [GitHub link omitted] Ss58 encoding shortly : 1) Add prefix to the output 2) Add public key to the output 3) Calculate blake2b hash 4) Add first 2 bytes to the output 5) Apply base58

Timeline (4 of 6 events)
  1. 2025-04-29 11:31 Ready for review by cypt4
  2. 2025-05-09 13:30 Merged master by cypt4
  3. 2025-05-09 13:30 Closed by cypt4
  4. 2025-05-09 13:30 Milestone set 1.80.x - Nightly by github-actions