Zcash × Brave WalletPersonal project
Search/ Updated
Menu

Type to search. Use ↑ ↓ and Enter to open a result.

[Zcash] Add internal shielding type to the ZCashWalletService::GetTransactionType

In a Release build Task Shielded (Orchard) support

Lead item brave-browser#44541 · opened by cypt4 · last source update

Issue state

Closed (completed)

Closed . GitHub type: Task.

Implementation

  • brave-core#28046 merged 2025-03-11 into master by cypt4
    [ZCash] Add Shielding tx type
    Linked by: GitHub closing reference, “Resolves/Fixes” line in the PR description, branch name brave_44541 (weaker evidence; titles share a keyword)

Uplifts to release branches

Release notes

No platform changelog lists this item.

Validation

QA required (QA/Yes).

  • QA Pass-Win64 (Desktop only)

QA labels are Brave’s own validation records per OS. They are not independent verification by this tracker.

Target

1.77.x - Release

For closed issues Brave sets the milestone to the earliest version line it believes the change landed in, and renames milestones as branches move from Nightly to Beta to Release. This tracker shows it but relies on build ancestry and release notes for availability.

Platforms (OS labels): Desktop

Owner: cypt4 · PR authors: cypt4

Build presence

Whether a merged pull request in this group is an ancestor of the brave-core tag of each platform’s current build (from versions.brave.com). Code presence is not the same as a feature being exposed on that platform.

PlatformReleaseBetaNightly
DesktopIncluded 1.97.59in v1.96.61 (GitHub compare v1.96.61...7baa49ea: behind); later builds of the same history include it (brave-core#28046)Included 1.98.47in v1.96.61 (GitHub compare v1.96.61...7baa49ea: behind); later builds of the same history include it (brave-core#28046)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...7baa49ea: behind); later builds of the same history include it (brave-core#28046)
AndroidIncluded 1.97.57in v1.96.61 (GitHub compare v1.96.61...7baa49ea: behind); later builds of the same history include it (brave-core#28046)Included 1.98.52in v1.96.61 (GitHub compare v1.96.61...7baa49ea: behind); later builds of the same history include it (brave-core#28046)Included 1.100.5in v1.96.61 (GitHub compare v1.96.61...7baa49ea: behind); later builds of the same history include it (brave-core#28046)
iOSIncluded 1.96.62in v1.96.61 (GitHub compare v1.96.61...7baa49ea: behind); later builds of the same history include it (brave-core#28046)Included 1.99.44in v1.96.61 (GitHub compare v1.96.61...7baa49ea: behind); later builds of the same history include it (brave-core#28046)Included 1.100.7in v1.96.61 (GitHub compare v1.96.61...7baa49ea: behind); later builds of the same history include it (brave-core#28046)

Members and their history

Issue

brave-browser#44541 [Zcash] Add internal shielding type to the ZCashWalletService::GetTransactionType

State: closed (completed) · created · closed · updated · discovered via label:feature/web3/wallet/zcash, search:zcash · matched label:feature/web3/wallet/zcash, title:zcash, body:shielded

QA Pass-Win64 QA/Yes release-notes/exclude feature/web3/wallet OS/Desktop feature/web3/wallet/core feature/web3/wallet/zcash

Description Required for UI customization, should be returned for t->s transactions when internal shielded address is used as a recipient Steps to reproduce - Actual result - Expected result - Reproduces how often Easily reproduced Brave version (brave://version info) - Channel information - [ ] release (stable) - [ ] beta - [ ] nightly Reproducibility - [ ] with Brave Shields disabled - [ ] with Brave Rewards disabled - [ ] in the latest version of Chrome Miscellaneous…

Timeline (11 of 14 events)
  1. 2025-03-10 09:39 Label added OS/Desktop by cypt4
  2. 2025-03-10 14:23 Referenced by brave-core#28046 by cypt4
  3. 2025-03-11 15:16 Closed completed brave-core#28046 by cypt4
  4. 2025-03-11 15:16 Closed completed by cypt4
  5. 2025-03-11 15:16 Milestone set 1.78.x - Nightly by brave-builds
  6. 2025-03-12 13:28 Label added QA/Yes by cypt4
  7. 2025-03-12 13:28 Label added release-notes/exclude by cypt4
  8. 2025-03-12 14:54 Referenced by brave-core#28105 by kjozwiak
  9. 2025-03-13 18:40 Milestone removed 1.78.x - Nightly by brave-builds
  10. 2025-03-13 18:40 Milestone set 1.77.x - Beta by brave-builds
  11. 2025-03-24 10:07 Label added QA Pass-Win64 by srirambv
Pull request

brave-core#28046 [ZCash] Add Shielding tx type

State: merged 2025-03-11 · created · closed · updated · discovered via path:components/brave_wallet/browser/zcash, search:zcash is:pr · matched title:zcash

CI/storybook-url feature/web3/wallet feature/web3/wallet/core

Resolves https://github.com/brave/brave-browser/issues/44541 Submitter Checklist: - [ ] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [ ] There is a ticket for my issue - [ ] Used Github auto-closing keywords in the PR description above - [ ] Wrote a good PR/commit description - [ ] Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the…

Timeline (5 of 8 events)
  1. 2025-03-11 15:16 Merged master by cypt4
  2. 2025-03-11 15:16 Closed by cypt4
  3. 2025-03-11 15:16 Milestone set 1.78.x - Nightly by github-actions
  4. 2025-03-12 07:17 Referenced by brave-core#28105 by cypt4
  5. 2025-03-24 10:06 Referenced by brave-browser#44541 by srirambv
Uplift PR → 1.77.x

brave-core#28105 [ZCash] Uplift pr28046 and pr27994 (1.77.x)

State: merged 2025-03-13 · created · closed · updated · discovered via search:shielded is:pr, search:zcash is:pr, search:zec is:pr · matched title:zcash

CI/storybook-url feature/web3/wallet feature/web3/wallet/core

Uplift of https://github.com/brave/brave-core/pull/27994 Uplift of https://github.com/brave/brave-core/pull/28046 Resolves https://github.com/brave/brave-browser/issues/42250 Resolves https://github.com/brave/brave-browser/issues/44055 Resolves https://github.com/brave/brave-browser/issues/44541 Submitter Checklist: - [ ] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them - [ ] There is a ticket for my…

Timeline (3 of 6 events)
  1. 2025-03-12 14:52 Milestone set 1.77.x - Beta by kjozwiak
  2. 2025-03-13 18:39 Merged 1.77.x by kjozwiak
  3. 2025-03-13 18:39 Closed by kjozwiak